Skip to content

Commit 52607dc

Browse files
authored
Merge pull request #577 from dotnet/dev/TJ/MacChanges
[DeveloperBalance] A few changes for Mac Accessibility
2 parents ba61de3 + a98cd51 commit 52607dc

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

9.0/Apps/DeveloperBalance/Pages/Controls/CategoryChart.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</Grid>
2222
</shimmer:SfShimmer.CustomView>
2323
<shimmer:SfShimmer.Content>
24-
<chart:SfCircularChart x:Name="Chart">
24+
<chart:SfCircularChart x:Name="Chart" SemanticProperties.Description="Task Categories Chart">
2525
<chart:DoughnutSeries
2626
ItemsSource="{Binding TodoCategoryData}"
2727
PaletteBrushes="{Binding TodoCategoryColors}"
@@ -30,7 +30,7 @@
3030
ShowDataLabels="True"
3131
EnableTooltip="False"
3232
x:Name="doughnutSeries"
33-
Radius="{OnIdiom 0.7, Phone=0.5}"
33+
Radius="{OnIdiom 0.6, Phone=0.5}"
3434
InnerRadius="0.7" >
3535
<chart:DoughnutSeries.LabelTemplate>
3636
<DataTemplate >

9.0/Apps/DeveloperBalance/Pages/Controls/ProjectCardView.xaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
xmlns:shimmer="clr-namespace:Syncfusion.Maui.Toolkit.Shimmer;assembly=Syncfusion.Maui.Toolkit"
99
x:Class="DeveloperBalance.Pages.Controls.ProjectCardView"
1010
Style="{StaticResource CardStyle}"
11+
SemanticProperties.Description="{Binding Name, StringFormat='{0} Project'}"
1112
x:DataType="models:Project">
1213
<shimmer:SfShimmer
1314
BackgroundColor="Transparent"

9.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@
9999
<DataTemplate x:DataType="models:IconData">
100100
<Grid RowDefinitions="Auto,4" RowSpacing="{StaticResource size60}"
101101
SemanticProperties.Description="{Binding Description}"
102-
SemanticProperties.Hint="Icon representing the type of task . Tap to select">
102+
SemanticProperties.Hint="Icon representing the type of task . Tap to select"
103+
InputTransparent="True">
103104
<VisualStateManager.VisualStateGroups>
104105
<VisualStateGroup x:Name="CommonStates">
105106
<VisualState x:Name="Normal">
@@ -127,6 +128,11 @@
127128
HorizontalOptions="Center"
128129
TextColor="{AppThemeBinding Light={StaticResource DarkOnLightBackground},Dark={StaticResource LightOnDarkBackground}}"/>
129130
<BoxView x:Name="SelectedIndicator" Color="{StaticResource Primary}" HeightRequest="4" HorizontalOptions="Fill" Grid.Row="1"/>
131+
132+
<!-- This TapGestureRecognizer ensures that the grid is treated as a button for accessibility purposes on iOS -->
133+
<Grid.GestureRecognizers>
134+
<TapGestureRecognizer />
135+
</Grid.GestureRecognizers>
130136
</Grid>
131137
</DataTemplate>
132138
</CollectionView.ItemTemplate>

9.0/Apps/DeveloperBalance/Pages/ProjectListPage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
Spacing="{StaticResource LayoutSpacing}">
2424
<BindableLayout.ItemTemplate>
2525
<DataTemplate x:DataType="models:Project">
26-
<Border>
26+
<Border SemanticProperties.Description="{Binding Name, StringFormat='{0} Project'}">
2727
<VerticalStackLayout Padding="10">
2828
<Label Text="{Binding Name}" FontSize="24" />
2929
<Label Text="{Binding Description}" />

0 commit comments

Comments
 (0)