Skip to content

Commit ab5bdb9

Browse files
authored
Merge pull request #571 from tj-devel709/dev/TJ/Leftovers2
More DeveloperBalance A11y Fixes
2 parents 59c18f3 + b2ab531 commit ab5bdb9

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

9.0/Apps/DeveloperBalance/Pages/ManageMetaPage.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
<Grid ColumnSpacing="{StaticResource LayoutSpacing}" ColumnDefinitions="4*,3*,30,Auto">
5757
<Entry Text="{Binding Title}" SemanticProperties.Description="{Binding Title}" Grid.Column="0" />
5858
<Entry Text="{Binding Color}" Grid.Column="1" x:Name="ColorEntry"
59-
SemanticProperties.Description="Color"
59+
SemanticProperties.Description="{Binding Title, StringFormat='{}{0} Color'}"
6060
SemanticProperties.Hint="Category color in HEX format">
6161
<Entry.Behaviors>
6262
<toolkit:TextValidationBehavior
@@ -98,7 +98,7 @@
9898
<Grid ColumnSpacing="{StaticResource LayoutSpacing}" ColumnDefinitions="4*,3*,30,Auto">
9999
<Entry Text="{Binding Title}" Grid.Column="0" SemanticProperties.Description="{Binding Title}" />
100100
<Entry Text="{Binding Color}" Grid.Column="1" x:Name="ColorEntry"
101-
SemanticProperties.Description="Color"
101+
SemanticProperties.Description="{Binding Title, StringFormat='{}{0} Color'}"
102102
SemanticProperties.Hint="Tag color in HEX format">
103103
<Entry.Behaviors>
104104
<toolkit:TextValidationBehavior

9.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@
5656

5757
<ContentPage.ToolbarItems>
5858
<ToolbarItem
59-
Text="Delete"
6059
Command="{Binding DeleteCommand}"
6160
Order="Primary"
6261
Priority="0"
63-
IconImageSource="{StaticResource IconDelete}" />
62+
IconImageSource="{StaticResource IconDelete}"
63+
SemanticProperties.Description="Delete" />
6464
</ContentPage.ToolbarItems>
6565

6666
<Grid>
@@ -97,7 +97,9 @@
9797
ItemsSource="{Binding Icons}">
9898
<CollectionView.ItemTemplate>
9999
<DataTemplate x:DataType="models:IconData">
100-
<Grid RowDefinitions="Auto,4" RowSpacing="{StaticResource size60}">
100+
<Grid RowDefinitions="Auto,4" RowSpacing="{StaticResource size60}"
101+
SemanticProperties.Description="{Binding Description}"
102+
SemanticProperties.Hint="Icon representing the type of task . Tap to select">
101103
<VisualStateManager.VisualStateGroups>
102104
<VisualStateGroup x:Name="CommonStates">
103105
<VisualState x:Name="Normal">
@@ -123,8 +125,6 @@
123125
FontSize="24"
124126
VerticalOptions="Center"
125127
HorizontalOptions="Center"
126-
SemanticProperties.Description="{Binding Description}"
127-
SemanticProperties.Hint="Icon representing the type of task . Tap to select"
128128
TextColor="{AppThemeBinding Light={StaticResource DarkOnLightBackground},Dark={StaticResource LightOnDarkBackground}}"/>
129129
<BoxView x:Name="SelectedIndicator" Color="{StaticResource Primary}" HeightRequest="4" HorizontalOptions="Fill" Grid.Row="1"/>
130130
</Grid>
@@ -166,6 +166,7 @@
166166
WidthRequest="44"
167167
IsVisible="{Binding HasCompletedTasks}"
168168
Command="{Binding CleanTasksCommand}"
169+
SemanticProperties.Description="Clean up"
169170
/>
170171
</Grid>
171172
<VerticalStackLayout

0 commit comments

Comments
 (0)