You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, whenever we set a color on a control we set the color for every single state. This means if a control becomes disabled the color doesn't change like it normally would on the platform. Ideally (?) we'd make this work similar to how WinUI works, where the color is only applied to the normal state and then the VSM of the control is used to delineate between state changes.
This issues comes from discussions on the following PR #7527 (comment)
If we end up defining all of our states inside a default applied theme then it's just on the user to update the correct state in the included style sheet and we call that "good enough"
An additional issue here is that we don't have a very good translation of VSM => platform states. Every platform has some concept of a "VSM" and we don't really map to that very well. In theory we could make the interface layer understand states a bit better and then produce more logical mappings to the platform vs just replacing every single state for every single color change
Public API Changes
TBD
Intended Use-Case
If the user were to only set the color on a checkbox
<CheckboxColor="purple" />
Then when that checkbox becomes disabled it would still apply the platforms opacity levels.
This discussion was converted from issue #8819 on May 31, 2024 21:21.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Description
Currently, whenever we set a color on a control we set the color for every single state. This means if a control becomes disabled the color doesn't change like it normally would on the platform. Ideally (?) we'd make this work similar to how WinUI works, where the color is only applied to the normal state and then the VSM of the control is used to delineate between state changes.
This issues comes from discussions on the following PR
#7527 (comment)
This issue probably clashes a bit with
#7800
If we end up defining all of our states inside a default applied theme then it's just on the user to update the correct state in the included style sheet and we call that "good enough"
An additional issue here is that we don't have a very good translation of VSM => platform states. Every platform has some concept of a "VSM" and we don't really map to that very well. In theory we could make the interface layer understand states a bit better and then produce more logical mappings to the platform vs just replacing every single state for every single color change
Public API Changes
TBD
Intended Use-Case
If the user were to only set the color on a checkbox
Then when that checkbox becomes disabled it would still apply the platforms opacity levels.
Beta Was this translation helpful? Give feedback.
All reactions