[Android] GraphicsView scaling after canvas.ResetState#31244
[Android] GraphicsView scaling after canvas.ResetState#31244kubaflo wants to merge 3 commits intodotnet:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a GraphicsView scaling issue on Android where content was being rendered at half size after calling canvas.ResetState(). The fix involves modifying the ScalingCanvas to preserve initial scale values when resetting state, eliminating the need for manual scaling in PlatformGraphicsView.
- Adds initial scale tracking to ScalingCanvas with new constructor parameter
- Removes redundant manual scaling call in PlatformGraphicsView.Draw method
- Adds comprehensive UI test to verify the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Graphics/src/Graphics/ScalingCanvas.cs | Adds initial scale tracking fields and constructor to preserve scale during ResetState() |
| src/Graphics/src/Graphics/Platforms/Android/PlatformGraphicsView.cs | Removes redundant Scale() call and uses new ScalingCanvas constructor with scale parameter |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31182.cs | Adds NUnit test to verify GraphicsView renders at correct size after ResetState() |
| src/Controls/tests/TestCases.HostApp/Issues/Issue31182.cs | Adds test page with GraphicsView that calls ResetState() to reproduce the issue |
| _blurrableCanvas = _canvas as IBlurrableCanvas; | ||
| } | ||
|
|
||
| internal ScalingCanvas(ICanvas wrapped, float scale) : this(wrapped) |
There was a problem hiding this comment.
This introduces a new public API constructor that could be a breaking change. Consider marking this constructor as internal to prevent external usage, or ensure this is documented as a new API addition if intended for public consumption.
kubaflo
added
platform/android
area-drawing
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| public void GraphicsViewShouldDrawAtFullSize() | ||
| { | ||
| App.WaitForElement("label"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshot on Windows and Android. Running a build.
There was a problem hiding this comment.
Test failing on Android:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2530
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2547
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 743
at Microsoft.Maui.TestCases.Tests.Issues.Issue31182.GraphicsViewShouldDrawAtFullSize() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31182.cs:line 17
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
| public void GraphicsViewShouldDrawAtFullSize() | ||
| { | ||
| App.WaitForElement("label"); | ||
| VerifyScreenshot(); |
| public void GraphicsViewShouldDrawAtFullSize() | ||
| { | ||
| App.WaitForElement("label"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Test failing on Android:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2530
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2547
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 743
at Microsoft.Maui.TestCases.Tests.Issues.Issue31182.GraphicsViewShouldDrawAtFullSize() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31182.cs:line 17
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
|
/rebase |
github-actions
bot
force-pushed
the
fix-31182-2
branch
from
3c41da6 to
2dbc3db
Compare
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 31244Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 31244" |
🧪 PR Test EvaluationOverall Verdict: This PR contains infrastructure and tooling improvements rather than functional bug fixes that would require test coverage. 📊 Expand Full EvaluationPR Test Evaluation ReportPR: #31244 — Remove pull_requests MCP toolset (use gh CLI instead) Overall VerdictThis PR contains GitHub Actions workflow, skill documentation, and test infrastructure improvements. No functional code changes were made that require test coverage. Special Case: Infrastructure PRThis PR modifies:
Key finding: The changes to 1. Fix Coverage — ✅ N/ANo functional fixes to cover - this is infrastructure/tooling improvements. 2. Edge Cases & Gaps — ✅ N/AInfrastructure changes don't require edge case testing in the traditional sense. 3. Test Type Appropriateness — ✅ N/ANo tests needed for documentation and workflow changes. 4. Convention Compliance —
|
🧪 PR Test EvaluationOverall Verdict: ❌ Tests are insufficient Unable to evaluate test coverage as no fix files were detected in the PR. 📊 Expand Full EvaluationPR Test Evaluation ReportPR: #31244 Overall Verdict❌ Tests are insufficient This evaluation was requested for PR #31244, but analysis shows 0 fix files and only infrastructure/test framework changes. Unable to evaluate test coverage as there are no functional changes to validate. 1. Fix Coverage — ❌No fix files detected. The evaluation script found only test infrastructure changes:
Without fix files, cannot assess whether tests adequately cover the intended changes. 2. Edge Cases & Gaps — ℹ️Covered: N/A - no fix to cover Missing: N/A - no fix to validate 3. Test Type Appropriateness — ℹ️Current: UI Test framework changes (UITest.cs) 4. Convention Compliance —
|
🧪 PR Test EvaluationOverall Verdict: ❌ Tests are insufficient This PR appears to modify testing infrastructure without providing adequate test coverage for the infrastructure changes themselves. 📊 Expand Full EvaluationPR Test Evaluation ReportPR: #31244 — Testing Infrastructure Improvements Overall Verdict❌ Tests are insufficient This PR modifies the core 1. Fix Coverage — ❌Analysis: The PR modifies critical testing infrastructure, specifically the
However, there are no tests that verify these infrastructure improvements actually work as intended. The changes could break existing test behavior without detection. 2. Edge Cases & Gaps — ❌Covered: None Missing Critical Test Cases:
3. Test Type Appropriateness — N/ACurrent: No tests 4. Convention Compliance —
|
🧪 PR Test EvaluationOverall Verdict: ✅ Tests are adequate This PR properly addresses a GraphicsView scaling issue on Android with appropriate test coverage. 📊 Expand Full EvaluationTest Coverage Analysis✅ Excellent Test Coverage1. Problem Reproduction Test
2. Automated Verification
✅ Technical Fix QualityRoot Cause Analysis: The issue occurred because:
Fix Implementation:
✅ Test Scenario ValidationThe test scenario accurately reproduces the reported issue:
Cross-Platform Consideration:
✅ Test MaintenanceSustainability:
SummaryThis PR demonstrates exemplary test practices:
The automated test will catch any future regressions in GraphicsView scaling behavior, and the fix is clean and well-targeted. Note 🔒 Integrity filtering filtered 2 itemsIntegrity filtering activated and filtered the following items during workflow execution.
|
Code Review — PR #31244Independent AssessmentWhat this changes: Fixes Inferred motivation: On Android, any Reconciliation with PR NarrativeAuthor claims: Follow-up to #31183. The Agreement/disagreement: Fully agree. The approach is sound — baking the initial scale into Findings
|
🟡 .NET MAUI Review - Changes SuggestedExpand Full Review -
|
- Add AutomationId to GraphicsView for robust element targeting - Start label invisible, show after invalidation (proper test signaling) - Remove fixed HeightRequest on VerticalStackLayout to prevent label from being clipped on Android (caused WaitForElement timeout) - Wait for StatusLabel31182 after invalidation cycle completes - Use retryTimeout on VerifyScreenshot for animation stability - Remove stale Mac/iOS snapshots (layout change invalidates them; all platform snapshots will be regenerated from CI) Fixes review feedback from jsuarezruiz: test was timing out on Android because the label overflowed the fixed-height container. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🚦 Gate - Test Before and After Fix📊 Expand Full Gate —
|
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
🖥️ Issue31182 Issue31182 |
❌ FAIL — 526s |
🔴 Without fix — 🖥️ Issue31182: ⚠️ ENV ERROR · 1645s
(truncated to last 15,000 chars)
ontrols/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
Build FAILED.
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: Mono.AndroidTools.InstallFailedException: Unexpected install output: cmd: Failure calling service package: Broken pipe (32) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Mono.AndroidTools.Internal.AdbOutputParsing.CheckInstallSuccess(String output, String packageName) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Mono.AndroidTools.AndroidDevice.<>c__DisplayClass105_0.<InstallPackage>b__0(Task`1 t) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
0 Warning(s)
1 Error(s)
Time Elapsed 00:15:32.77
* daemon not running; starting now at tcp:5037
* daemon started successfully
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:08:15.52
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Determining projects to restore...
Restored /home/vsts/work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 1.81 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 3 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 5.96 sec).
Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj (in 7.89 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 1 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 2.19 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.59 sec).
5 of 13 projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.11] Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.29] Discovered: Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 04/04/2026 22:18:54 FixtureSetup for Issue31182(Android)
>>>>> 04/04/2026 22:18:56 GraphicsViewShouldDrawAtFullSize Start
>>>>> 04/04/2026 22:19:02 GraphicsViewShouldDrawAtFullSize Stop
>>>>> 04/04/2026 22:19:03 Log types: logcat, bugreport, server
Failed GraphicsViewShouldDrawAtFullSize [6 s]
Error Message:
VisualTestUtils.VisualTestFailedException :
Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/GraphicsViewShouldDrawAtFullSize.png
Ensure new snapshot is correct: /home/vsts/work/1/a/Controls.TestCases.Shared.Tests/snapshots-diff/android/GraphicsViewShouldDrawAtFullSize.png
and if it is, push a change to add it to the 'snapshots' directory.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
Stack Trace:
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.Issues.Issue31182.GraphicsViewShouldDrawAtFullSize() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31182.cs:line 20
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Failed.
Total tests: 1
Failed: 1
Total time: 27.7318 Seconds
🟢 With fix — 🖥️ Issue31182: FAIL ❌ · 526s
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:06:31.73
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13747575
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.11] Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.33] Discovered: Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 04/04/2026 22:28:11 FixtureSetup for Issue31182(Android)
>>>>> 04/04/2026 22:28:14 GraphicsViewShouldDrawAtFullSize Start
>>>>> 04/04/2026 22:28:19 GraphicsViewShouldDrawAtFullSize Stop
>>>>> 04/04/2026 22:28:19 Log types: logcat, bugreport, server
Failed GraphicsViewShouldDrawAtFullSize [5 s]
Error Message:
VisualTestUtils.VisualTestFailedException :
Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/GraphicsViewShouldDrawAtFullSize.png
Ensure new snapshot is correct: /home/vsts/work/1/a/Controls.TestCases.Shared.Tests/snapshots-diff/android/GraphicsViewShouldDrawAtFullSize.png
and if it is, push a change to add it to the 'snapshots' directory.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
Stack Trace:
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.Issues.Issue31182.GraphicsViewShouldDrawAtFullSize() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31182.cs:line 20
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Failed.
Total tests: 1
Failed: 1
Total time: 20.9995 Seconds
⚠️ Issues found
⚠️ Issue31182 without fix:Exception calling "Matches" with "2" argument(s): "Value cannot be null. (Parameter 'input')"- ❌ Issue31182 FAILED with fix (should pass)
GraphicsViewShouldDrawAtFullSize [5 s]VisualTestUtils.VisualTestFailedException : Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/GraphicsViewShouldDra...
📁 Fix files reverted (3 files)
eng/pipelines/ci-copilot.ymlsrc/Graphics/src/Graphics/Platforms/Android/PlatformGraphicsView.cssrc/Graphics/src/Graphics/ScalingCanvas.cs
🤖 AI Summary📊 Expand Full Review —
|
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #31244 | Store initial scale in ScalingCanvas, restore on ResetState()/RestoreState(); remove manual Scale() from PlatformGraphicsView.Draw() |
❌ FAIL (Gate — test bug) | ScalingCanvas.cs, PlatformGraphicsView.cs |
Core fix is correct; test is the problem |
🔧 Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix (claude-opus-4.6) | Read DisplayScale from wrapped canvas as reset base in ResetState()/RestoreState() |
✅ PASS | ScalingCanvas.cs only |
Implicit — relies on DisplayScale being set correctly |
| 2 | try-fix (claude-sonnet-4.6) | Add internal float ResetScale { get; set; } = 1f; caller sets to density; ResetState() uses it |
✅ PASS | ScalingCanvas.cs, PlatformGraphicsView.cs |
Mutable internal property — less immutable than PR's ctor |
| 3 | try-fix (gpt-5.3-codex) | Auto-capture baseline scale from first root Scale() call in ScalingCanvas |
✅ PASS | ScalingCanvas.cs only |
Heuristic/fragile — depends on call order |
| 4 | try-fix (gpt-5.4) | DensityPreservingScalingCanvas subclass in PlatformGraphicsView reapplies density after ResetState() |
✅ PASS | PlatformGraphicsView.cs only |
Keeps ScalingCanvas unchanged; subclass only in Android |
| 5 | try-fix (claude-sonnet-4.6 cross-poll) | Per-draw instantiation: create fresh ScalingCanvas(_canvas, _scale) each Draw() call; remove _scalingCanvas field |
✅ PASS | PlatformGraphicsView.cs, ScalingCanvas.cs |
Eliminates shared mutable state; ~1 alloc/frame |
| PR | PR #31244 | _initialScaleX/Y fields + internal ctor; ResetState() restores to initial; RestoreState() stack-empty case restores to initial |
❌ FAIL (Gate — test bug) | ScalingCanvas.cs, PlatformGraphicsView.cs |
Architecturally best; test has WaitForElement timeout + missing snapshot |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| claude-opus-4.6 | 2 | No | NO NEW IDEAS — design space covered |
| claude-sonnet-4.6 | 2 | Yes | Per-draw instantiation → ran as Attempt 5 ✅ |
| gpt-5.3-codex | 2 | Yes | Split DeviceScaleX/Y + UserScaleX/Y — more invasive redesign, not attempted |
| gpt-5.4 | 2 | Yes | Snapshot full baseline canvas state — too complex, not attempted |
| claude-opus-4.6 | 3 | No | NO NEW IDEAS — remaining suggestions are strictly more invasive |
Exhausted: Yes — 4 required models queried (gemini unavailable, gpt-5.4 used); all said NO NEW IDEAS in round 3
Selected Fix: PR #31244 fix (with test fix) — Most explicit, immutable-after-construction, no reliance on runtime state, no mutable properties, no heuristics, no subclasses, no per-frame allocation. The ONLY issue is the test reliability (WaitForElement 5s timeout too short; missing Android baseline snapshot).
📋 Report — Final Recommendation
⚠️ Final Recommendation: REQUEST CHANGES
Phase Status
| Phase | Status | Notes |
|---|---|---|
| Pre-Flight | ✅ COMPLETE | Android GraphicsView density scaling bug; 2 impl + 2 test files |
| Gate | ❌ FAILED | Android — WaitForElement("StatusLabel31182") times out; missing baseline snapshot |
| Try-Fix | ✅ COMPLETE | 5 attempts, 5 passing (all via alternative approaches); PR's fix correct but test broken |
| Report | ✅ COMPLETE |
Summary
PR #31244 fixes a real Android bug where ScalingCanvas.ResetState() was wiping the device-density scale, causing GraphicsView content to render at half-size on the second Draw call. The core implementation fix is architecturally correct and independently confirmed by all 5 try-fix models. The gate failure is a test reliability problem only, not a fix regression.
The test needs two fixes before this PR can merge:
- WaitForElement timeout too short —
TimeSpan.FromSeconds(5)is too aggressive for Android emulator page load; increase to 30s - Missing Android baseline snapshot —
VerifyScreenshot()has no baseline on Android; the snapshot must be generated and committed (reported byjsuarezruizin PR discussion)
Root Cause
ScalingCanvas tracks current scale in _scaleX/_scaleY. Before the fix, ResetState() and RestoreState() (empty stack) both reset these to hardcoded 1f. PlatformGraphicsView.Draw() applied device-density scale via an explicit Scale(_scale, _scale) call after ResetState(). When a user's IDrawable.Draw() called canvas.ResetState(), it wiped that density scale mid-draw, and subsequent draw operations used 1f scale instead of the device density — rendering at 1/density size on the next frame.
Fix Quality
PR's implementation (_initialScaleX/Y fields + internal ScalingCanvas(ICanvas, float) constructor):
- ✅ Architecturally sound — scale is immutable after construction, no runtime state inference
- ✅
internalconstructor is correct — noPublicAPI.Unshipped.txtneeded - ✅
ResetState()restores to initial scale AND re-applies_canvas.Scale()to underlying canvas - ✅
RestoreState()empty-stack case also restores to initial (important forSaveState()/RestoreState()pairing) - ✅ Removes the now-redundant explicit
Scale()call fromPlatformGraphicsView.Draw() - ✅ Confirmed best approach vs 5 alternatives by all 4 try-fix models
Test fix needed (Issue31182.cs):
// BEFORE (broken):
App.WaitForElement("StatusLabel31182", timeout: TimeSpan.FromSeconds(5));
// AFTER (fix):
App.WaitForElement("StatusLabel31182", timeout: TimeSpan.FromSeconds(30));Also: generate and commit the Android baseline snapshot for VerifyScreenshot().
Changes Requested
- Increase
WaitForElementtimeout insrc/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31182.cs: changeTimeSpan.FromSeconds(5)→TimeSpan.FromSeconds(30) - Generate and commit Android snapshot — run the test locally on Android to produce the baseline screenshot, then commit it to the snapshots directory
- Optional: Consider adding
App.WaitForElement("GraphicsView31182")beforeWaitForElement("StatusLabel31182")to ensure the page is fully rendered before querying the label
MauiBot
added
s/agent-changes-requested
On Android, Appium excludes IsVisible=false elements from the accessibility tree, causing WaitForElement to time out. Instead of toggling visibility, start the label visible with 'Waiting' text and change it to 'Invalidated' after the GraphicsView invalidation cycle. Test now waits for the text change as the ready signal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Follow-up to #31183
While reviewing the snapshots, I noticed that without calling canvas.ResetState(); in the Draw method, the rendered content size was doubled.
This change removes the unnecessary call to _scalingCanvas.Scale in PlatformGraphicsView. Scaling is already accounted for in the ResetState() method
Issues Fixed
Fixes #31182