[vs17.14] Add test summary always in terminal logger (#12852)

**Description**

Running tests with dotnet test, users see inconsistent number of
projects and tests reported in the view. This is a UI only issue,
failing tests will still fail the build. It is still worth fixing the
issue because it makes the runs show repeatable numbers of tests to the
user.

The terminal node can be null before we receive the finish message. This
will cause that some summaries are not accounted for and will be missing
in the final output.

The node is null for this reason:
#12819 That fix is not
backported.

**Customer Impact:** Multiple runs of the same test suite report
different total counts of tests and projects.

**Regression?** No, this was never working correctly since the beginning
of test reporting in Terminal Logger.

**Risk:** Low, it impacts UI only.

Link the PR to the original issue and to the PR to main. 
PR to main is merged: #12801
Fixes microsoft/vstest#15307

No additional impact on packages or localization.

Author: nohwnd

eng/Versions.props

@@ -2,7 +2,7 @@
 <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
 <Project>
   <PropertyGroup>
-    <VersionPrefix>17.14.36</VersionPrefix>
+    <VersionPrefix>17.14.37</VersionPrefix>
     <DotNetFinalVersionKind>release</DotNetFinalVersionKind>
     <PackageValidationBaselineVersion>17.13.9</PackageValidationBaselineVersion>
     <AssemblyVersion>15.1.0.0</AssemblyVersion>

src/Build/Logging/TerminalLogger/TerminalLogger.cs

@@ -906,30 +906,38 @@ private void MessageRaised(object sender, BuildMessageEventArgs e)
 
             if (hasProject && project!.IsTestProject)
             {
-                var node = _nodes[NodeIndexForContext(buildEventContext)];
+                TerminalNodeStatus? node = _nodes[NodeIndexForContext(buildEventContext)];
 
                 // Consumes test update messages produced by VSTest and MSTest runner.
-                if (node != null && e is IExtendedBuildEventArgs extendedMessage)
+                if (e is IExtendedBuildEventArgs extendedMessage)
                 {
                     switch (extendedMessage.ExtendedType)
                     {
                         case "TLTESTPASSED":
                             {
-                                var indicator = extendedMessage.ExtendedMetadata!["localizedResult"]!;
-                                var displayName = extendedMessage.ExtendedMetadata!["displayName"]!;
+                                if (node != null)
+                                {
+                                    var indicator = extendedMessage.ExtendedMetadata!["localizedResult"]!;
+                                    var displayName = extendedMessage.ExtendedMetadata!["displayName"]!;
+
+                                    var status = new TerminalNodeStatus(node.Project, node.TargetFramework, TerminalColor.Green, indicator, displayName, project.Stopwatch);
+                                    UpdateNodeStatus(buildEventContext, status);
+                                }
 
-                                var status = new TerminalNodeStatus(node.Project, node.TargetFramework, TerminalColor.Green, indicator, displayName, project.Stopwatch);
-                                UpdateNodeStatus(buildEventContext, status);
                                 break;
                             }
 
                         case "TLTESTSKIPPED":
                             {
-                                var indicator = extendedMessage.ExtendedMetadata!["localizedResult"]!;
-                                var displayName = extendedMessage.ExtendedMetadata!["displayName"]!;
+                                if (node != null)
+                                {
+                                    var indicator = extendedMessage.ExtendedMetadata!["localizedResult"]!;
+                                    var displayName = extendedMessage.ExtendedMetadata!["displayName"]!;
+
+                                    var status = new TerminalNodeStatus(node.Project, node.TargetFramework, TerminalColor.Yellow, indicator, displayName, project.Stopwatch);
+                                    UpdateNodeStatus(buildEventContext, status);
+                                }
 
-                                var status = new TerminalNodeStatus(node.Project, node.TargetFramework, TerminalColor.Yellow, indicator, displayName, project.Stopwatch);
-                                UpdateNodeStatus(buildEventContext, status);
                                 break;
                             }