Skip to content

Commit 5d8159c

Browse files
authored
[automated] Merge branch 'vs17.12' => 'vs17.14' (#12134)
I detected changes in the vs17.12 branch which have not been merged yet to vs17.14. I'm a robot and am configured to help you automatically keep vs17.14 up to date, so I've opened this PR. This PR merges commits made on vs17.12 by the following committers: * @GangWang01 * @dotnet-maestro[bot] ## Instructions for merging from UI This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, *not* a squash or rebase commit. <img alt="merge button instructions" src="https://i.imgur.com/GepcNJV.png" width="300" /> If this repo does not allow creating merge commits from the GitHub UI, use command line instructions. ## Instructions for merging via command line Run these commands to merge this pull request from the command line. ``` sh git fetch git checkout vs17.12 git pull --ff-only git checkout vs17.14 git pull --ff-only git merge --no-ff vs17.12 # If there are merge conflicts, resolve them and then run git merge --continue to complete the merge # Pushing the changes to the PR branch will re-trigger PR validation. git push https://github.com/dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14 ``` <details> <summary>or if you are using SSH</summary> ``` git push [email protected]:dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14 ``` </details> After PR checks are complete push the branch ``` git push ``` ## Instructions for resolving conflicts :warning: If there are merge conflicts, you will need to resolve them manually before merging. You can do this [using GitHub][resolve-github] or using the [command line][resolve-cli]. [resolve-github]: https://help.github.com/articles/resolving-a-merge-conflict-on-github/ [resolve-cli]: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ ## Instructions for updating this pull request Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.12-to-vs17.14'. This can be done to resolve conflicts or make other changes to this pull request before it is merged. The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote. ``` git fetch git checkout -b merge/vs17.12-to-vs17.14 origin/vs17.14 git pull https://github.com/dotnet/msbuild merge/vs17.12-to-vs17.14 (make changes) git commit -m "Updated PR with my changes" git push https://github.com/dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14 ``` <details> <summary>or if you are using SSH</summary> ``` git fetch git checkout -b merge/vs17.12-to-vs17.14 origin/vs17.14 git pull [email protected]:dotnet/msbuild merge/vs17.12-to-vs17.14 (make changes) git commit -m "Updated PR with my changes" git push [email protected]:dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14 ``` </details> Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues. Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
2 parents d21f833 + 213a3f1 commit 5d8159c

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

.vsts-dotnet.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ parameters:
1616
displayName: Optional OptProfDrop Override
1717
type: string
1818
default: 'default'
19+
- name: EnableOptProf
20+
displayName: Enable OptProf data collection for this build
21+
type: boolean
22+
default: true
1923

2024
variables:
2125
# if OptProfDrop is not set, string '$(OptProfDrop)' will be passed to the build script.
@@ -33,6 +37,10 @@ variables:
3337
value: ${{parameters.OptProfDropName}}
3438
- name: SourceBranch
3539
value: ''
40+
# Override SkipApplyOptimizationData to true when disabling OptProf data collection
41+
- ${{ if eq(parameters.EnableOptProf, false) }}:
42+
- name: SkipApplyOptimizationData
43+
value: true
3644
- name: EnableReleaseOneLocBuild
3745
value: true # Enable loc for vs17.14
3846
- name: Codeql.Enabled
@@ -164,6 +172,7 @@ extends:
164172
AccessToken: '$(System.AccessToken)'
165173
feedSource: 'https://devdiv.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json'
166174
displayName: 'Install OptProf Plugin'
175+
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
167176

168177
# Required by MicroBuildBuildVSBootstrapper
169178
- task: MicroBuildSwixPlugin@4
@@ -199,7 +208,7 @@ extends:
199208
toLowerCase: false
200209
usePat: true
201210
displayName: 'OptProf - Publish to Artifact Services - ProfilingInputs'
202-
condition: succeeded()
211+
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
203212

204213
# Build VS bootstrapper
205214
# Generates $(Build.StagingDirectory)\MicroBuild\Output\BootstrapperInfo.json
@@ -210,7 +219,7 @@ extends:
210219
manifests: $(VisualStudio.SetupManifestList)
211220
outputFolder: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)\Insertion'
212221
displayName: 'OptProf - Build VS bootstrapper'
213-
condition: succeeded()
222+
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
214223

215224
# Publish run settings
216225
- task: PowerShell@2
@@ -222,7 +231,7 @@ extends:
222231
/p:BootstrapperInfoPath=$(Build.StagingDirectory)\MicroBuild\Output\BootstrapperInfo.json
223232
/p:VisualStudioIbcTrainingSettingsPath=$(Build.SourcesDirectory)\eng\config\OptProf.runsettings
224233
displayName: 'OptProf - Build IBC training settings'
225-
condition: succeeded()
234+
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
226235

227236
# Publish bootstrapper info
228237
- task: 1ES.PublishBuildArtifacts@1
@@ -231,7 +240,7 @@ extends:
231240
ArtifactName: MicroBuildOutputs
232241
ArtifactType: Container
233242
displayName: 'OptProf - Publish Artifact: MicroBuildOutputs'
234-
condition: succeeded()
243+
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
235244

236245
- task: 1ES.PublishBuildArtifacts@1
237246
displayName: 'Publish Artifact: logs'
@@ -293,7 +302,7 @@ extends:
293302
displayName: Tag build as ready for optimization training
294303
inputs:
295304
tags: 'ready-for-training'
296-
condition: succeeded()
305+
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
297306

298307
- task: ms-vseng.MicroBuildTasks.521a94ea-9e68-468a-8167-6dcf361ea776.MicroBuildCleanup@1
299308
displayName: Execute cleanup tasks

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
33
<Project>
44
<PropertyGroup>
5-
<VersionPrefix>17.14.15</VersionPrefix>
5+
<VersionPrefix>17.14.16</VersionPrefix>
66
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
77
<PackageValidationBaselineVersion>17.13.9</PackageValidationBaselineVersion>
88
<AssemblyVersion>15.1.0.0</AssemblyVersion>

0 commit comments

Comments
 (0)