Update .NET SDK to 9.0.300 (#11887)

* Initial plan for issue

* Update .NET SDK to 9.0.300

Co-authored-by: rainersigwald <[email protected]>

* Remove explicit SDK version from global.json

Co-authored-by: rainersigwald <[email protected]>

* Suppress IDE0350 warning

This is contentious--the untyped lambdas can be harder to read and for LLMs
to work with so let's not enforce it.

* Remove unused ConcurrentDictionary.AcquireAllLocks

* Switch to scouting queue to get newer VS bits

* Update .NET SDK version to 9.0.301

Co-authored-by: JanProvaznik <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: rainersigwald <[email protected]>
Co-authored-by: Rainer Sigwald <[email protected]>
Co-authored-by: JanProvaznik <[email protected]>

Author: 3 people

.editorconfig

@@ -428,6 +428,9 @@ dotnet_diagnostic.IDE0073.severity = error
 # Use 'System.Threading.Lock'
 dotnet_diagnostic.IDE0330.severity = suggestion
 
+# Use implicitly typed lambda
+dotnet_diagnostic.IDE0350.severity = none
+
 # Value types are incompatible with null values. https://xunit.net/xunit.analyzers/rules/xUnit1012
 dotnet_diagnostic.xUnit1012.severity = warning
 

.vsts-dotnet-ci.yml

@@ -218,7 +218,7 @@ jobs:
   pool:
     ${{ if eq(variables['System.TeamProject'], 'public') }}:
       name: NetCore-Public
-      demands: ImageOverride -equals windows.vs2022preview.amd64.open
+      demands: ImageOverride -equals windows.vs2022preview.scout.amd64.open
     ${{ if ne(variables['System.TeamProject'], 'public') }}:
       name: VSEngSS-MicroBuild2022-1ES
       demands: agent.os -equals Windows_NT

global.json

@@ -5,7 +5,7 @@
     "errorMessage": "The .NET SDK could not be found, please run a command-line build with ./build.cmd."
   },
   "tools": {
-    "dotnet": "9.0.106",
+    "dotnet": "9.0.301",
     "vs": {
       "version": "17.12.0"
     },

src/MSBuildTaskHost/Concurrent/ConcurrentDictionary.cs

@@ -471,22 +471,6 @@ private static void GetBucketAndLockNo(int hashcode, out int bucketNo, out int l
             Debug.Assert(lockNo >= 0 && lockNo < lockCount);
         }
 
-        /// <summary>
-        /// Acquires all locks for this hash table, and increments locksAcquired by the number
-        /// of locks that were successfully acquired. The locks are acquired in an increasing
-        /// order.
-        /// </summary>
-        private void AcquireAllLocks(ref int locksAcquired)
-        {
-            // First, acquire lock 0
-            AcquireLocks(0, 1, ref locksAcquired);
-
-            // Now that we have lock 0, the _locks array will not change (i.e., grow),
-            // and so we can safely read _locks.Length.
-            AcquireLocks(1, _tables._locks.Length, ref locksAcquired);
-            Debug.Assert(locksAcquired == _tables._locks.Length);
-        }
-
         /// <summary>
         /// Acquires a contiguous range of locks for this hash table, and increments locksAcquired
         /// by the number of locks that were successfully acquired. The locks are acquired in an