Skip to content

Move ProjectCache namespace out of experimental#11622

Closed
JanProvaznik wants to merge 8 commits intomainfrom
exp/mipavlik/project-cache-namespace
Closed

Move ProjectCache namespace out of experimental#11622
JanProvaznik wants to merge 8 commits intomainfrom
exp/mipavlik/project-cache-namespace

Conversation

@JanProvaznik
Copy link
Copy Markdown
Member

@JanProvaznik JanProvaznik commented Mar 24, 2025

Fixes #11575

Context

Reflect that the ProjectCache is no longer used experimentally.

Changes Made

Made a copy of each class in the non-experimental namespace.

Testing

Existing tests

Notes

After insertion needs adjustment in VS.

@JanProvaznik JanProvaznik changed the title Move Project cache namespace out of experimental Move ProjectCache namespace out of experimental Mar 25, 2025
@JanProvaznik JanProvaznik marked this pull request as ready for review March 25, 2025 10:38
@maridematte
Copy link
Copy Markdown
Member

In this case, why are we having a copy of each class still in experimental?

@JanProvaznik
Copy link
Copy Markdown
Member Author

JanProvaznik commented Mar 26, 2025

In this case, why are we having a copy of each class still in experimental?

In order not to break existing consumers of that API. The Experimental versions of these files would be removed some time in the future.

@JanProvaznik JanProvaznik force-pushed the exp/mipavlik/project-cache-namespace branch from 1a15622 to df5bab0 Compare April 7, 2025 12:20
@JanProvaznik
Copy link
Copy Markdown
Member Author

I redid the merge as in BuildParameters the wrong namespace was included.

@JanProvaznik
Copy link
Copy Markdown
Member Author

this commit 2e1d6d2 breaks the tests because the tests rely at the same time on the sample (which has the version 16.11 with the old namespace) and on the current implementation (using old doesn't solve it trivially nor the new)

@rainersigwald do you have an idea how to resolve? can we unpin?

@JanProvaznik
Copy link
Copy Markdown
Member Author

this needs more work, this approach does not work to maintain compatibility

@JanProvaznik JanProvaznik marked this pull request as draft June 2, 2025 12:45
@JanProvaznik
Copy link
Copy Markdown
Member Author

redoing this from scratch

@YuliiaKovalova YuliiaKovalova deleted the exp/mipavlik/project-cache-namespace branch June 20, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move ProjectCache to non-Experimental

3 participants