Skip to content

Add opt-in for default channel registrations check#11751

Closed
JaynieBai wants to merge 8 commits intodotnet:mainfrom
JaynieBai:dev/jenny/issue11214
Closed

Add opt-in for default channel registrations check#11751
JaynieBai wants to merge 8 commits intodotnet:mainfrom
JaynieBai:dev/jenny/issue11214

Conversation

@JaynieBai
Copy link
Copy Markdown
Member

@JaynieBai JaynieBai commented Apr 21, 2025

@JaynieBai JaynieBai self-assigned this Apr 21, 2025
@JaynieBai JaynieBai marked this pull request as ready for review April 22, 2025 09:26
Copilot AI review requested due to automatic review settings April 22, 2025 09:26
@JaynieBai JaynieBai requested a review from a team as a code owner April 22, 2025 09:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces an opt-in mechanism to enforce default channel registrations during the build. Key changes include:

  • Adding a new boolean parameter "requireDefaultChannels" to the post-build template
  • Forwarding the parameter through to the sdk-task invocation
  • Enabling the parameter in the .vsts-dotnet pipeline configuration

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/common/core-templates/post-build/post-build.yml Adds a new boolean parameter and passes it to the build command
.vsts-dotnet.yml Sets "requireDefaultChannels" to true to enforce the check in pipeline
Files not reviewed (1)
  • eng/common/post-build/publish-using-darc.ps1: Language not supported

@JaynieBai JaynieBai marked this pull request as draft April 22, 2025 09:28
@JanProvaznik
Copy link
Copy Markdown
Member

JanK's update of arcade is only for the main/net10. but we're consuming net9 arcade. We probably need to backport Jan's change to net9 arcade.

@JanProvaznik
Copy link
Copy Markdown
Member

the update to 9.0 arcade was merged: next step consume the update, merge to this branch, only the vsts-dotnet.yml change should be necessary

@JaynieBai
Copy link
Copy Markdown
Member Author

the update to 9.0 arcade was merged: next step consume the update, merge to this branch, only the vsts-dotnet.yml change should be necessary

@JanProvaznik There is still no change after your updates on the net9 arcade. will your updates reflected in the main branch?

@JaynieBai
Copy link
Copy Markdown
Member Author

deprecated this one since the new created PR #12028

@JaynieBai JaynieBai closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Infra] Build publishing - Opt-in into strict checking of default branch registration

4 participants