Include resources in command line arguments produced by csc in design-time build (take 2)

[tmat]

Iteration on #11893, which had to be reverted.
Adds condition to only update OutputResource if it is not set already.

[tmat]

@rainersigwald @YuliiaKovalova ptal

[Copilot]

Pull Request Overview

This PR enhances the design-time build by ensuring resource items carry an explicit output path before code generation runs.

• Introduce a new AssignEmbeddedResourceOutputPaths target and wire it into the PrepareResourceNamesDependsOn sequence.
• Refactor OutputResources to use the newly assigned %(OutputResource) metadata.
• Add a dependency for _GenerateCompileInputs on PrepareResourceNames to guarantee metadata is set.

Comments suppressed due to low confidence (2)

src/Tasks/Microsoft.Common.CurrentVersion.targets:3255

• There are no automated tests covering the new AssignEmbeddedResourceOutputPaths target. Consider adding unit or integration tests to verify that OutputResource metadata is correctly set for EmbeddedResource items.

<Target Name="AssignEmbeddedResourceOutputPaths">

src/Tasks/Microsoft.Common.CurrentVersion.targets:3253

• [nitpick] The XML comment could be expanded to note which downstream targets rely on this metadata (e.g., _GenerateCompileInputs and GetItemTargetPaths), improving clarity for future maintainers.

Sets OutputResource metadata on EmbeddedResource items. This metadata is used in design time build without running ResGen target.

[rainersigwald]

Looks ok to me but should we test it in the VMR too since it broke there?

[tmat]

@rainersigwald How do I do that?

[rainersigwald]

Create a draft PR with this same content in dotnet/dotnet's src/msbuild directory.

[tmat]

Validation PR: dotnet/dotnet#987

[tmat]

Oh, wait ... this was still broken. I had to tweak the code in the validation PR. Let me submit a fix...