Skip to content

Conversation

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Jan 30, 2026

Attempt 2 for #13089

In scope of #12753 support for translating HostServices in Out of Proc Task Host was added, but limited to NET task host.

This change removes this limitation.

@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review January 30, 2026 12:38
Copilot AI review requested due to automatic review settings January 30, 2026 12:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the limitation that HostServices/target metadata translation in the out-of-proc task host protocol only works for the .NET task host, enabling the same behavior for the CLR4 (.NET Framework) task host.

Changes:

  • Update TaskHostConfiguration.Translate to serialize/deserialize TargetName, ProjectFile, and HostServices for the CLR4 “version 0” protocol as well as packet version 2+.
  • Document special meanings of ITranslator.NegotiatedPacketVersion, including the “0” (framework-to-framework) case.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Shared/TaskHostConfiguration.cs Enables HostServices/target metadata translation for CLR4 task host communication by treating negotiated version 0 as supporting these fields.
src/Framework/ITranslator.cs Clarifies protocol/version semantics in documentation for NegotiatedPacketVersion, including special values 0/1/2+.

@YuliiaKovalova
Copy link
Member Author

YuliiaKovalova commented Jan 30, 2026

@YuliiaKovalova YuliiaKovalova merged commit 3fbe376 into main Feb 3, 2026
9 checks passed
@YuliiaKovalova YuliiaKovalova deleted the exp/ykovalova/host_services_translation_clr4 branch February 3, 2026 14:55
@YuliiaKovalova YuliiaKovalova self-assigned this Feb 3, 2026
Copilot AI pushed a commit that referenced this pull request Feb 3, 2026
Attempt 2 for #13089

In scope of #12753 support for
translating HostServices in Out of Proc Task Host was added, but limited
to NET task host.

This change removes this limitation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants