-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add hostservices translation support for clr 4 task host #13154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hostservices translation support for clr 4 task host #13154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes the limitation that HostServices/target metadata translation in the out-of-proc task host protocol only works for the .NET task host, enabling the same behavior for the CLR4 (.NET Framework) task host.
Changes:
- Update
TaskHostConfiguration.Translateto serialize/deserializeTargetName,ProjectFile, andHostServicesfor the CLR4 “version 0” protocol as well as packet version 2+. - Document special meanings of
ITranslator.NegotiatedPacketVersion, including the “0” (framework-to-framework) case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Shared/TaskHostConfiguration.cs | Enables HostServices/target metadata translation for CLR4 task host communication by treating negotiated version 0 as supporting these fields. |
| src/Framework/ITranslator.cs | Clarifies protocol/version semantics in documentation for NegotiatedPacketVersion, including special values 0/1/2+. |
Attempt 2 for #13089
In scope of #12753 support for translating HostServices in Out of Proc Task Host was added, but limited to NET task host.
This change removes this limitation.