Merge pull request #18 from jkonecki/fix_for_methods_returning_null_collections

Fix for methods returning null collections

Author: gabikliot

src/OrleansRuntime/Catalog/ActivationDirectory.cs

@@ -163,7 +163,9 @@ public void RemoveTarget(ActivationData target)
             }
         }
 
-        // Returns null if no activations exist for this grain ID, rather than an empty list
+        /// <summary>
+        /// Returns null if no activations exist for this grain ID, rather than an empty list
+        /// </summary>
         public List<ActivationData> FindTargets(GrainId key)
         {
             List<ActivationData> tmp;

src/OrleansRuntime/ConsistentRing/ConsistentRingProvider.cs

@@ -81,11 +81,17 @@ public IRingRange GetMyRange()
             return MyRange; // its immutable, so no need to clone
         }
 
+        /// <summary>
+        /// Returns null if silo is not in the list of members
+        /// </summary>
         public List<SiloAddress> GetMySucessors(int n = 1)
         {
             return FindSuccessors(MyAddress, n);
         }
 
+        /// <summary>
+        /// Returns null if silo is not in the list of members
+        /// </summary>
         public List<SiloAddress> GetMyPredecessors(int n = 1)
         {
             return FindPredecessors(MyAddress, n);
@@ -205,6 +211,9 @@ internal void RemoveServer(SiloAddress silo)
             }
         }
 
+        /// <summary>
+        /// Returns null if silo is not in the list of members
+        /// </summary>
         internal List<SiloAddress> FindPredecessors(SiloAddress silo, int count)
         {
             lock (membershipRingList)
@@ -227,6 +236,9 @@ internal List<SiloAddress> FindPredecessors(SiloAddress silo, int count)
             }
         }
 
+        /// <summary>
+        /// Returns null if silo is not in the list of members
+        /// </summary>
         internal List<SiloAddress> FindSuccessors(SiloAddress silo, int count)
         {
             lock (membershipRingList)