Skip to content

Commit d39aade

Browse files
committed
Fix DurableJobs test shard assignment signature
1 parent fc150cf commit d39aade

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

test/Orleans.Core.Tests/DurableJobs/InMemoryJobShardManagerTests.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public async Task AssignJobShardsAsync_ReturnsOwnedShards()
4545
var maxDueTime = minDueTime.AddHours(1);
4646

4747
var createdShard = await manager.CreateShardAsync(minDueTime, maxDueTime, new Dictionary<string, string>(), CancellationToken.None);
48-
var assignedShards = await manager.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
48+
var assignedShards = await manager.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
4949

5050
Assert.Single(assignedShards);
5151
Assert.Equal(createdShard.Id, assignedShards[0].Id);
@@ -69,7 +69,7 @@ public async Task AssignJobShardsAsync_OrphanedShard_IsAssignedWithoutIncrementi
6969

7070
// Silo2 picks up the orphaned shard
7171
var manager2 = new InMemoryJobShardManager(Silo2);
72-
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
72+
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
7373

7474
Assert.Single(assignedShards);
7575
Assert.Equal(shard.Id, assignedShards[0].Id);
@@ -95,7 +95,7 @@ public async Task AssignJobShardsAsync_AdoptedFromDeadSilo_IncrementsAdoptedCoun
9595

9696
// Silo2 adopts the shard from dead Silo1
9797
var manager2 = new InMemoryJobShardManager(Silo2, membershipService, maxAdoptedCount: 3);
98-
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
98+
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
9999

100100
// Shard should be assigned (adopted count = 1, under threshold)
101101
Assert.Single(assignedShards);
@@ -124,17 +124,17 @@ public async Task AssignJobShardsAsync_PoisonedShard_IsNotAssigned()
124124

125125
// Silo2 adopts from dead Silo1 (adopted count = 1)
126126
var manager2 = new InMemoryJobShardManager(Silo2, membershipService, maxAdoptedCount: 2);
127-
var shards2 = await manager2.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
127+
var shards2 = await manager2.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
128128
Assert.Single(shards2);
129129

130130
// Silo3 adopts from dead Silo2 (adopted count = 2)
131131
var manager3 = new InMemoryJobShardManager(Silo3, membershipService, maxAdoptedCount: 2);
132-
var shards3 = await manager3.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
132+
var shards3 = await manager3.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
133133
Assert.Single(shards3);
134134

135135
// Silo4 tries to adopt from dead Silo3 (adopted count would be 3, exceeds max of 2)
136136
var manager4 = new InMemoryJobShardManager(Silo4, membershipService, maxAdoptedCount: 2);
137-
var shards4 = await manager4.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
137+
var shards4 = await manager4.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
138138

139139
// Shard is poisoned and should not be assigned
140140
Assert.Empty(shards4);
@@ -155,7 +155,7 @@ public async Task AssignJobShardsAsync_MaxAdoptedCountOfZero_NeverAssignsAdopted
155155

156156
// Silo2 tries to adopt from dead Silo1 with maxAdoptedCount=0
157157
var manager2 = new InMemoryJobShardManager(Silo2, membershipService, maxAdoptedCount: 0);
158-
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
158+
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
159159

160160
// Shard should not be assigned (adopted count would be 1, exceeds max of 0)
161161
Assert.Empty(assignedShards);
@@ -183,7 +183,7 @@ public async Task UseInMemoryDurableJobs_ConfiguredMaxAdoptedCount_IsApplied()
183183
using var serviceProvider = services.BuildServiceProvider();
184184
var manager = serviceProvider.GetRequiredService<InMemoryJobShardManager>();
185185

186-
var assignedShards = await manager.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
186+
var assignedShards = await manager.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
187187
Assert.Empty(assignedShards);
188188
}
189189

@@ -202,7 +202,7 @@ public async Task AssignJobShardsAsync_ShardFromActiveSilo_IsNotAssigned()
202202

203203
// Silo2 tries to get shards - should not get Silo1's shard since Silo1 is active
204204
var manager2 = new InMemoryJobShardManager(Silo2, membershipService);
205-
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
205+
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
206206

207207
Assert.Empty(assignedShards);
208208
}
@@ -220,7 +220,7 @@ public async Task UnregisterShardAsync_WithNoJobsRemaining_RemovesShard()
220220
await manager.UnregisterShardAsync(shard, CancellationToken.None);
221221

222222
// Shard should be removed, not reassignable
223-
var assignedShards = await manager.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
223+
var assignedShards = await manager.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
224224
Assert.Empty(assignedShards);
225225
}
226226

@@ -241,7 +241,7 @@ public async Task UnregisterShardAsync_WithJobsRemaining_MarksShardAsOrphaned()
241241

242242
// Shard should be orphaned and available for another silo
243243
var manager2 = new InMemoryJobShardManager(Silo2);
244-
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, CancellationToken.None);
244+
var assignedShards = await manager2.AssignJobShardsAsync(maxDueTime, int.MaxValue, CancellationToken.None);
245245
Assert.Single(assignedShards);
246246
}
247247

0 commit comments

Comments
 (0)