Remove the usage of the dotnet-benchview variable group as we no longer use PerfCommandUploadToken. Also removed the infrastructure for rotating certain secrets as the majority were deleted, PerfCommandUploadTokenNonEscaped is no longer used and can be deleted after this PR, and pvscmdupload-storage-key and pvscmdupload-connection-string seem to only be used by this flow. (#4884)

Author: LoopedBard3

.config/dotnet-tools.json

@@ -67,29 +67,3 @@ jobs:
       jobParameters:
         ${{ if parameters.onlySanityCheck }}:
           onlySanityCheck: true
-
-  - ${{ if and(ne(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'Schedule', 'Manual')) }}:
-    # Secret Sync
-    - job: Synchronize
-      pool:
-        name: NetCore1ESPool-Internal-NoMSI
-        demands: ImageOverride -equals 1es-windows-2019
-      steps:
-      - task: UseDotNet@2
-        displayName: Install .NET 6.0 
-        inputs:
-          version: 6.x
-
-      - task: DeleteFiles@1
-        inputs:
-          Contents: global.json
-
-      - script: dotnet tool restore
-
-      - task: AzureCLI@2
-        inputs:
-          azureSubscription: .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa)
-          scriptType: ps
-          scriptLocation: inlineScript
-          inlineScript: |
-            Get-ChildItem .vault-config/*.yaml |% { dotnet secret-manager synchronize $_}

.config/settings.json

@@ -107,8 +107,6 @@ jobs:
       - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
         # for private runs, we want to upload perflab data
         - group: DotNet-HelixApi-Access
-        # perflab upload tokens still exist in this variable group
-        - group: dotnet-benchview
         - ${{ if eq(parameters.downloadPdn, true) }}:
           - name: _pdnPath
             value: '$(Build.ArtifactStagingDirectory)/PDN.zip'