enable collecting dump for gcperfsim-functional test (#4910)

Author: VincentBu

src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/GCPerfSim/GCPerfSimCommand.cs

@@ -114,6 +114,8 @@ internal static Dictionary<string, ProcessExecutionDetails> ExecuteLocally(GCPer
 
                 for (int iterationIdx = 0; iterationIdx < configuration.Environment.Iterations; iterationIdx++)
                 {
+                    // Format: (Name of Run).(corerun / name of corerun).(IterationIdx)
+                    string key = $"{runInfo.RunDetails.Key}.{runInfo.CorerunDetails.Key}.{iterationIdx}";
                     using (Process gcperfsimProcess = new())
                     {
                         gcperfsimProcess.StartInfo.FileName = processAndParameters.Item1;
@@ -155,6 +157,10 @@ internal static Dictionary<string, ProcessExecutionDetails> ExecuteLocally(GCPer
                             }
                         }
 
+                        // Set dump name
+                        string dumpPath = Path.Combine(outputPath, key + ".dmp");
+                        environmentVariables["DOTNET_DbgMiniDumpName"] = dumpPath;
+
                         // Check if the log file is specified, also store it in a run-specific location.
                         // This log file should be named in concordance with the name of the run and the benchmark.
                         const string gclogVariable = "DOTNET_GCLogFile";
@@ -170,13 +176,10 @@ internal static Dictionary<string, ProcessExecutionDetails> ExecuteLocally(GCPer
                             gcperfsimProcess.StartInfo.EnvironmentVariables[environVar.Key] = environVar.Value;
                         }
 
-                        // Format: (Name of Run).(corerun / name of corerun).(IterationIdx)
                         string? output = null;
                         string? error = null;
 
-                        string key = $"{runInfo.RunDetails.Key}.{runInfo.CorerunDetails.Key}.{iterationIdx}";
-                        string traceName = $"{runInfo.RunDetails.Key}.{runInfo.CorerunDetails.Key}.{iterationIdx}";
-                        using (TraceCollector traceCollector = new TraceCollector(traceName, collectType, outputPath))
+                        using (TraceCollector traceCollector = new TraceCollector(key, collectType, outputPath))
                         {
                             gcperfsimProcess.Start();
                             output = gcperfsimProcess.StandardOutput.ReadToEnd();
@@ -189,7 +192,7 @@ internal static Dictionary<string, ProcessExecutionDetails> ExecuteLocally(GCPer
                         if (configuration.TraceConfigurations?.Type != "none")
                         {
                             // Not checking Linux here since the local run only allows for Windows.
-                            if (!File.Exists(Path.Combine(outputPath, traceName + ".etl.zip")))
+                            if (!File.Exists(Path.Combine(outputPath, key + ".etl.zip")))
                             {
                                 AnsiConsole.MarkupLine($"[yellow bold] ({DateTime.Now}) The trace for the run wasn't successfully captured. Please check the log file for more details: {Markup.Escape(output)} Full run details: {Path.GetFileNameWithoutExtension(configuration.Name)}: {runInfo.CorerunDetails.Key} for {runInfo.RunDetails.Key} [/]");
                             }

src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/GCPerfSim/GCPerfSimFunctionalCommand.cs

@@ -360,30 +360,34 @@ private void CreateLargePages_WorkstationSuite(string gcPerfSimSuitePath, GCPerf
 
         private GCPerfSimConfiguration CreateBasicGCPerfSimConfiguration(GCPerfSimFunctionalConfiguration configuration)
         {
-            GCPerfSimConfiguration gcPerfSimNormalWorkstationConfiguration = GCPerfSimConfigurationParser.Parse(_gcPerfSimBase, true);
+            GCPerfSimConfiguration gcPerfSimBasicConfiguration = GCPerfSimConfigurationParser.Parse(_gcPerfSimBase, true);
 
             // modify gcperfsim_configurations
-            gcPerfSimNormalWorkstationConfiguration.gcperfsim_configurations.gcperfsim_path =
+            gcPerfSimBasicConfiguration.gcperfsim_configurations.gcperfsim_path =
                 configuration.gcperfsim_path;
 
             // modify coreruns
-            gcPerfSimNormalWorkstationConfiguration.coreruns = new Dictionary<string, CoreRunInfo>();
+            gcPerfSimBasicConfiguration.coreruns = new Dictionary<string, CoreRunInfo>();
             foreach (var keyValuePair in configuration.coreruns)
             {
-                gcPerfSimNormalWorkstationConfiguration.coreruns[keyValuePair.Key] = keyValuePair.Value;
+                gcPerfSimBasicConfiguration.coreruns[keyValuePair.Key] = keyValuePair.Value;
             }
 
             // modify trace_configurations
-            gcPerfSimNormalWorkstationConfiguration.TraceConfigurations.Type = configuration.trace_configuration_type;
+            gcPerfSimBasicConfiguration.TraceConfigurations.Type = configuration.trace_configuration_type;
 
             // load environment variables by deep copying them.
-            gcPerfSimNormalWorkstationConfiguration.Environment.environment_variables = new Dictionary<string, string>();
+            gcPerfSimBasicConfiguration.Environment.environment_variables = new Dictionary<string, string>();
             foreach (var c in configuration.Environment.environment_variables)
             {
-                gcPerfSimNormalWorkstationConfiguration.Environment.environment_variables[c.Key] = c.Value;
+                gcPerfSimBasicConfiguration.Environment.environment_variables[c.Key] = c.Value;
             }
 
-            return gcPerfSimNormalWorkstationConfiguration;
+            // Enable generating full dump when error occurs.
+            gcPerfSimBasicConfiguration.Environment.environment_variables["DOTNET_DbgEnableMiniDump"] = "1";
+            gcPerfSimBasicConfiguration.Environment.environment_variables["DOTNET_DbgMiniDumpType"] = "4";
+
+            return gcPerfSimBasicConfiguration;
         }
     }
 }