Fix warning in .NET 8 code around serialization

drewnoakes · drewnoakes · commit 0df4e16a6cd5 · 2024-03-06T12:15:01.000+11:00
Fixes the following warning in .NET 8 builds (currently only via the integration test project): > tests\Common\ThrowingTraceListener.cs(50,101,50,122): warning SYSLIB0051: 'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete: 'This API supports obsolete formatter-based serialization. It should not be called or extended by application code.' (https://aka.ms/dotnet-warnings/SYSLIB0051)
diff --git a/tests/Common/ThrowingTraceListener.cs b/tests/Common/ThrowingTraceListener.cs
@@ -32,7 +32,9 @@ public override void WriteLine(string message)
         {
         }
 
+#if !NET8_0_OR_GREATER
         [Serializable]
+#endif
         public class DebugAssertFailureException : Exception
         {
             public DebugAssertFailureException()
@@ -47,9 +49,11 @@ public DebugAssertFailureException(string message, Exception inner) : base(messa
             {
             }
 
+#if !NET8_0_OR_GREATER
             protected DebugAssertFailureException(SerializationInfo info, StreamingContext context) : base(info, context)
             {
             }
+#endif
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,9 @@ public override void WriteLine(string message)`
`32`	`32`	`{`
`33`	`33`	`}`
`34`	`34`
	`35`	`+#if !NET8_0_OR_GREATER`
`35`	`36`	`[Serializable]`
	`37`	`+#endif`
`36`	`38`	`public class DebugAssertFailureException : Exception`
`37`	`39`	`{`
`38`	`40`	`public DebugAssertFailureException()`
`@@ -47,9 +49,11 @@ public DebugAssertFailureException(string message, Exception inner) : base(messa`
`47`	`49`	`{`
`48`	`50`	`}`
`49`	`51`
	`52`	`+#if !NET8_0_OR_GREATER`
`50`	`53`	`protected DebugAssertFailureException(SerializationInfo info, StreamingContext context) : base(info, context)`
`51`	`54`	`{`
`52`	`55`	`}`
	`56`	`+#endif`
`53`	`57`	`}`
`54`	`58`	`}`
`55`	`59`	`}`