Merge branch 'main' into FixRenameNamespaceWithUnsavedChanged

# Conflicts:
#	src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Rename/FileMoveNotificationListener.cs

Author: MiYanni

.editorconfig

@@ -8,6 +8,9 @@ root = true
 indent_style = space
 # (Please don't specify an indent_size here; that has too many unintended consequences.)
 
+# Spell checker configuration
+spelling_exclusion_path = spelling.dic
+
 # Code files
 [*.{cs,csx,vb,vbx}]
 indent_size = 4

ProjectSystem.sln

@@ -67,6 +67,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "items", "items", "{5204CAC5
 		nuget.config = nuget.config
 		README.md = README.md
 		SECURITY.md = SECURITY.md
+		spelling.dic = spelling.dic
 		version.json = version.json
 	EndProjectSection
 EndProject

docs/build-acceleration.md

@@ -29,7 +29,7 @@ Consider this example, where a unit test project references a project that in tu
 
 Making a change in _Library 3_ and running the unit test would previously have caused four calls to MSBuild.
 
-With build acceleration enabled MSBuild is called only once, after which VS copies the output of _Library 3_ to all referencing projects
+With build acceleration enabled MSBuild is called only once, after which VS copies the output of _Library 3_ to all referencing projects.
 
 ## Configuration
 
@@ -49,9 +49,11 @@ You may disable build acceleration for specific projects in your solution by red
 
 ## Debugging
 
+### Enable logging
+
 Build acceleration runs with the FUTDC, and outputs details of its operation in the build log. To enable this logging:
 
-> Tools | Options | Projects and Solutions | .NET Core
+> Tools | Options | Projects and Solutions | SDK-Style Projects
 
 ![Projects and Solutions, .NET Core options](repo/images/options.png)
 
@@ -61,6 +63,73 @@ Setting _Logging Level_ to a value other than `None` results in messages prefixe
 - `Minimal` produces a single message per out-of-date project.
 - `Info` and `Verbose` provide increasingly detailed information about the inner workings of the check, which are useful for debugging.
 
+### Validate builds are accelerated
+
+If build acceleration cannot be enabled for any of the reasons given below, builds continue to work as before.
+
+The following prerequisites exist for build acceleration:
+
+- You are running Visual Studio 2022 version 17.5 or later.
+- The project is an SDK-style .NET project.
+- All projects it references (directly and transitively) are also SDK-style .NET projects.
+
+The following steps will validate that build acceleration is working correctly for a given project.
+
+1. Ensure `Verbose` logging is enabled (see [Enable logging](#enable-logging)).
+1. Build the project to make it up-to-date.
+1. Modify source of a referenced project (either a direct reference or transitive reference).
+1. Build the project again.
+
+Looking through the build output with the following points in mind:
+
+- ℹ️ If you see:
+
+   > This project appears to be a candidate for build acceleration. To opt in, set the 'AccelerateBuildsInVisualStudio' MSBuild property to 'true'.
+
+   Then the project does not specify the `AccelerateBuildsInVisualStudio` property, or its value was not `true` or `false`, and the project would likely benefit from build acceleration. If the project cannot use build acceleration for any reason, this message can be suppressed by setting the property to `false` explicitly. See [configuration](#configuration) to learn how to configure build acceleration correctly.
+
+- ⛔ If you see:
+
+   > Build acceleration is disabled for this project via the 'AccelerateBuildsInVisualStudio' MSBuild property.
+
+   Then the `AccelerateBuildsInVisualStudio` property was set to `false`. Even if your build files don't set this explicitly, it could come from a `.props`/`.targets` file within a NuGet package, or be related to the project type (for example, installer projects cannot be accelerated).
+
+- ⛔ If you see:
+
+   > Build acceleration data is unavailable for project with target 'C:\Solution\Project\bin\Debug\Project.dll'.
+
+   Then any project that references the indicated project (directy or transitively) cannot be accelerated. This can happen if the mentioned project uses the legacy `.csproj` format, or for any other project system within Visual Studio that doesn't support build acceleration. Currently only .NET SDK-style projects (loaded with the project system from this GitHub repository) provide the needed data.
+
+- 🗒️ TODO Add validation and output message when reference assemblies are not enabled (https://github.com/dotnet/project-system/issues/8798)
+
+- ✅ You should see a section listing items to copy:
+
+   ```
+   Checking items to copy to the output directory:
+       Checking copy items from project 'C:\Solution\Referenced\Referenced.csproj':
+           Checking PreserveNewest item
+               Source      2023-01-19 15:28:56.882: 'C:\Solution\Referenced\bin\Debug\net7.0\Referenced.dll'
+               Destination 2023-01-19 15:28:37.379: 'C:\Solution\Referencing\bin\Debug\net7.0\Referenced.dll'
+               Remembering the need to copy file 'C:\Solution\Referenced\bin\Debug\net7.0\Referenced.dll' to 'C:\Solution\Referencing\bin\Debug\net7.0\Referenced.dll'.
+       ...
+   ```
+
+   This indicates that build acceleration has identified a set of files to copy.
+
+- ✅ You should see a section indicating that files were copied and the project was up-to-date:
+
+   ```
+   Copying 2 files to accelerate build:
+       From 'C:\Solution\Library1\bin\Debug\net7.0\Library1.dll' to 'C:\Solution\Tests\bin\Debug\net7.0\Library1.dll'.
+       From 'C:\Solution\Library1\bin\Debug\net7.0\Library1.pdb' to 'C:\Solution\Tests\bin\Debug\net7.0\Library1.pdb'.
+   Project is up-to-date.
+   Up-to-date check completed in 8.8 ms
+   ```
+   
+   This indicates that rather than calling MSBuild to build the project, Visual Studio has copied the listed files directly. The check completed quickly, the project is reported as up-to-date, and the next project (if any) can start building.
+
+   ⚠️ Note that the bug described in [Discrepancies between FUTDC logging and build summary](up-to-date-check.md#discrepancies-between-futdc-logging-and-build-summary) may cause the number of succeeded projects to be overstated. This requires changes within Visual Studio, and we hope to fix this in a future release.
+
 ## Limitations
 
 MSBuild is very configurable, and there are many ways to configure a project that will prevent build acceleration from working correctly. For example, if a project's build defines post-compile steps that are important to the correct functioning of your project, then build acceleration will not correctly reproduce those steps when it bypasses MSBuild.
@@ -71,4 +140,4 @@ We recommend enabling build acceleration for all projects in the solution, as de
 
 ## Giving feedback
 
-If you encounter an issue with build acceleration, please [file an issue](https://github.com/dotnet/project-system/issues/new/choose) and we will investigate whether it's something that can be addressed.
+If you encounter an issue with build acceleration, please review the [open issue list](https://github.com/dotnet/project-system/issues?q=is%3Aissue+label%3AFeature-Build-Acceleration) to see whether it already exists. If so you can vote and comment on that issue. Otherwise, [file a new issue](https://github.com/dotnet/project-system/issues/new/choose) and we will investigate whether it's something that can be addressed.

docs/design-time-builds.md

@@ -57,7 +57,11 @@ The `AddAdditionalReferences` target will run in both normal builds _and_ design
 
 ### Determining whether a target is running in a design-time build
 
-Use both the `DesignTimeBuild` (CPS-based projects) and `BuildingProject` (legacy project system) properties to determine whether a target is running in a design-time build or a normal build. This can be used to avoid expensive calculations or work that is only needed for a normal build, helping to keep the IDE responsive.
+Checking if a target is running in a design-time build can be used to avoid expensive calculations or work that is only needed for a normal build, helping to keep the IDE responsive.
+
+Different project systems use different properties to distinguish between design-time builds and normal builds. For example, the .NET Project System in this repo builds on top of the Common Project System (CPS) components, and CPS-based project systems set the `DesignTimeBuild` property. However, non-SDK-style C# and VB projects generally use what we call the "legacy" project system, and it uses the `BuildingProject` property.
+
+As such, you should make use of both the `DesignTimeBuild` and `BuildingProject` properties to determine whether a target is running in a design-time build or a normal build: 
 
 ```xml
 <Target Name="AddAdditionalReferences" BeforeTargets="ResolveAssemblyReferences">

docs/repo/property-pages/property-specification.md

@@ -299,7 +299,7 @@ will be added as unchecked list items.
     <StringProperty.ValueEditors>
       <ValueEditor EditorType="MultiStringSelector">
         <ValueEditor.Metadata>
-          <NameValuePair Name="TypeDescriptorText" Value="Imported Namespaces" />
+          <NameValuePair Name="TypeDescriptorText" Value="Imported Namespaces" xliff:LocalizableProperties="Value" />
           <NameValuePair Name="AllowsCustomStrings" Value="True" />
         </ValueEditor.Metadata>
       </ValueEditor>

docs/up-to-date-check.md

@@ -137,7 +137,7 @@ non-zero, then the check would have determined the project was not up-to-date, r
 
 To debug issues with the up-to-date check, enable its logging.
 
-> Tools | Options | Projects and Solutions | .NET Core
+> Tools | Options | Projects and Solutions | SDK-Style Projects
 
 ![Projects and Solutions, .NET Core options](repo/images/options.png)
 

eng/imports/HostAgnostic.props

@@ -27,7 +27,7 @@
     <PackageReference Include="Nerdbank.GitVersioning"              PrivateAssets="all" />
     <PackageReference Include="System.IO.Pipelines"                 ExcludeAssets="all" />
     <PackageReference Include="Microsoft.Net.Compilers.Toolset" />
-    <PackageReference Include="XliffTasks"                          PrivateAssets="all" />
+    <PackageReference Include="Microsoft.DotNet.XliffTasks"         PrivateAssets="all" />
     <!-- Path Property: PkgMicrosoft_DiaSymReader_Pdb2Pdb -->
     <PackageReference Include="Microsoft.DiaSymReader.Pdb2Pdb"      ExcludeAssets="all" GeneratePathProperty="true" />
     <!-- Path Property: PkgCodecov -->

eng/imports/Packages.targets

@@ -9,7 +9,7 @@
     <PackageReference Update="Nerdbank.Streams"                                                       Version="2.9.112" />
     <PackageReference Update="Nerdbank.GitVersioning"                                                 Version="3.5.107" />
     <PackageReference Update="System.IO.Pipelines"                                                    Version="6.0.3" />
-    <PackageReference Update="XliffTasks"                                                             Version="1.0.0-beta.20574.1" />
+    <PackageReference Update="Microsoft.DotNet.XliffTasks"                                            Version="1.0.0-beta.23073.2" />
     <!-- This is used for publishing PDBs to the legacy symbol server. It converts portable PDBs to Windows PDBs (embedded). -->
     <!-- https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/672/Archive-Symbols-with-Symweb?anchor=portable-pdbs -->
     <PackageReference Update="Microsoft.DiaSymReader.Pdb2Pdb"                                         Version="1.1.0-beta2-22320-02" />
@@ -46,7 +46,7 @@
     <PackageReference Update="Microsoft.VisualStudio.Threading"                                       Version="17.4.16-alpha" />
     <PackageReference Update="Microsoft.VisualStudio.Threading.Analyzers"                             Version="17.4.16-alpha" />
     <PackageReference Update="Microsoft.VisualStudio.Utilities"                                       Version="17.4.0-preview-3-32908-042" />
-    <PackageReference Update="Microsoft.VisualStudio.Validation"                                      Version="17.0.64" />
+    <PackageReference Update="Microsoft.VisualStudio.Validation"                                      Version="17.6.4-alpha" />
     <PackageReference Update="Microsoft.VisualStudio.XmlEditor"                                       Version="17.3.32804.24" />
     <PackageReference Update="System.Threading.Tasks.Dataflow"                                        Version="6.0.0" />
     <PackageReference Update="Microsoft.VSDesigner"                                                   Version="17.0.0-preview-2-31223-026" />

setup/Directory.Build.targets

@@ -31,4 +31,13 @@
   <!-- Specifies the version number that is used within the 'source.extension.vsixmanifest' files for VSIX packages. -->
   <Target Name="GetVsixVersion" Outputs="$(BuildVersion)" Condition="'$(IsVsixProject)' == 'true'" />
 
+  <!--
+    Creates the Insertion folder as the full folder path is required to create the .vsix file in CreateVsixContainer.
+    This line will fail in the VsixUtil tool if the folder path does not exist:
+    https://dev.azure.com/devdiv/DevDiv/_git/VSExtensibility?path=/src/product/vssdk/tools/VsixUtil/Packager.cs&version=GBdevelop&line=82&lineEnd=83&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents
+  -->
+  <Target Name="CreateInsertionFolder" BeforeTargets="CreateVsixContainer" Condition="'$(IsVsixProject)' == 'true'">
+    <MakeDir Directories="$(VisualStudioSetupInsertionPath)" />
+  </Target>
+
 </Project>

setup/Microsoft.VisualStudio.ProjectSystem.Managed.CommonFiles/Microsoft.VisualStudio.ProjectSystem.Managed.CommonFiles.csproj

@@ -8,11 +8,6 @@
 
   <Import Project="..\..\eng\imports\VisualStudio.props" />
 
-  <PropertyGroup>
-    <!-- This VSSDK project has custom build steps and should not be accelerated. -->
-    <AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>
-  </PropertyGroup>
-
   <ItemGroup>
     <!-- Depend on projects producing XAML rules included in this Willow package -->
     <ProjectReference Include="..\..\src\Microsoft.VisualStudio.ProjectSystem.Managed\Microsoft.VisualStudio.ProjectSystem.Managed.csproj" />