Avoid instantiation Roslyn package via RenamerProjectTreeActionHandler

This code path was instantiating the Roslyn package along this path and causing Launch Profiler to take longer to initialize than it should be.

  mscorlib.dll!System.Lazy<Microsoft.VisualStudio.ProjectSystem.IProjectTreeActionHandler>.CreateValue() Unknown
  mscorlib.dll!System.Lazy<Microsoft.VisualStudio.ProjectSystem.IProjectTreeActionHandler>.LazyInitValue() Unknown
  Microsoft.VisualStudio.ProjectSystem.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.Designers.PhysicalProjectTreeProvider.ProjectTreeActionContext.GetAddNewItemDirectory(Microsoft.VisualStudio.ProjectSystem.IProjectTreeActionHandlerContext context, Microsoft.VisualStudio.ProjectSystem.IProjectTree target) Line 107 C#
  Microsoft.VisualStudio.ProjectSystem.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.Designers.PhysicalProjectTreeProvider.GetAddNewItemDirectory(Microsoft.VisualStudio.ProjectSystem.IProjectTree target) Line 550 C#
  Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.ProjectTreeProviderExtensions.GetRootedAddNewItemDirectory(Microsoft.VisualStudio.ProjectSystem.IProjectTreeProvider provider, Microsoft.VisualStudio.ProjectSystem.IProjectTree target) Unknown
  Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.SpecialFileProviders.AppDesignerFolderSpecialFileProvider.GetDefaultFileAsync(Microsoft.VisualStudio.ProjectSystem.IProjectTreeProvider provider, Microsoft.VisualStudio.ProjectSystem.IProjectTree root) Unknown
  Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.SpecialFileProviders.AppDesignerFolderSpecialFileProvider.FindAppDesignerFolderCandidateAsync(Microsoft.VisualStudio.ProjectSystem.IProjectTreeProvider provider, Microsoft.VisualStudio.ProjectSystem.IProjectTree root) Unknown
  Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.SpecialFileProviders.AppDesignerFolderSpecialFileProvider.FindFileAsync(Microsoft.VisualStudio.ProjectSystem.IProjectTreeProvider provider, Microsoft.VisualStudio.ProjectSystem.IProjectTree root) Unknown
  Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.SpecialFileProviders.AbstractSpecialFileProvider.FindFileAsync(Microsoft.VisualStudio.ProjectSystem.IProjectTreeProvider provider, Microsoft.VisualStudio.ProjectSystem.IProjectTree root, Microsoft.VisualStudio.ProjectSystem.SpecialFileFlags flags) Unknown
  [Async] Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.SpecialFileProviders.AbstractSpecialFileProvider.GetFileAsync(Microsoft.VisualStudio.ProjectSystem.SpecialFiles fileId, Microsoft.VisualStudio.ProjectSystem.SpecialFileFlags flags, System.Threading.CancellationToken cancellationToken) Unknown
> [Async] Microsoft.VisualStudio.ProjectSystem.Managed.dll!Microsoft.VisualStudio.ProjectSystem.Debug.LaunchSettingsProvider.GetLaunchSettingsFilePathNoCacheAsync() Unknown

Author: davkean

src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Rename/RenamerProjectTreeActionHandler.cs

@@ -31,15 +31,15 @@ internal partial class RenamerProjectTreeActionHandler : ProjectTreeActionHandle
         private readonly IUserNotificationServices _userNotificationServices;
         private readonly IWaitIndicator _waitService;
         private readonly IRoslynServices _roslynServices;
-        private readonly Workspace _workspace;
+        private readonly Lazy<Workspace> _workspace;
         private readonly IVsService<SVsOperationProgress, IVsOperationProgressStatusService> _operationProgressService;
         private readonly IVsService<SVsSettingsPersistenceManager, ISettingsManager> _settingsManagerService;
 
         [ImportingConstructor]
         public RenamerProjectTreeActionHandler(
             UnconfiguredProject unconfiguredProject,
             IUnconfiguredProjectVsServices projectVsServices,
-            [Import(typeof(VisualStudioWorkspace))] Workspace workspace,
+            [Import(typeof(VisualStudioWorkspace))]Lazy<Workspace> workspace,
             IEnvironmentOptions environmentOptions,
             IUserNotificationServices userNotificationServices,
             IRoslynServices roslynServices,
@@ -155,7 +155,7 @@ private async Task<Solution> PublishLatestSolutionAsync(CancellationToken cancel
             await stageStatus.WaitForCompletionAsync().WithCancellation(cancellationToken);
 
             // The result of that wait, is basically a "new" published Solution, so grab it
-            return _workspace.CurrentSolution;
+            return _workspace.Value.CurrentSolution;
         }
 
         private static async Task<(bool, Renamer.RenameDocumentActionSet?)> GetRenameSymbolsActionsAsync(CodeAnalysis.Project project, string? oldFilePath, string newFileWithExtension)
@@ -220,7 +220,7 @@ protected virtual async Task<bool> IsAutomationFunctionAsync()
         }
 
         private CodeAnalysis.Project? GetCurrentProject() =>
-            _workspace.CurrentSolution.Projects.FirstOrDefault(proj => StringComparers.Paths.Equals(proj.FilePath, _projectVsServices.Project.FullPath));
+            _workspace.Value.CurrentSolution.Projects.FirstOrDefault(proj => StringComparers.Paths.Equals(proj.FilePath, _projectVsServices.Project.FullPath));
 
         private static CodeAnalysis.Document GetDocument(CodeAnalysis.Project project, string? filePath) =>
             project.Documents.FirstOrDefault(d => StringComparers.Paths.Equals(d.FilePath, filePath));

tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTests/ProjectSystem/VS/Rename/RenamerTestsBase.cs

@@ -50,7 +50,7 @@ internal class TestRenamerProjectTreeActionHandler : RenamerProjectTreeActionHan
             public TestRenamerProjectTreeActionHandler(
                 UnconfiguredProject unconfiguredProject,
                 IUnconfiguredProjectVsServices projectVsServices,
-                [Import(typeof(VisualStudioWorkspace))] Workspace workspace,
+                [Import(typeof(VisualStudioWorkspace))]Lazy<Workspace> workspace,
                 IEnvironmentOptions environmentOptions,
                 IUserNotificationServices userNotificationServices,
                 IRoslynServices roslynServices,
@@ -108,7 +108,7 @@ internal async Task RenameAsync(string sourceCode, string oldFilePath, string ne
 
             var renamer = new TestRenamerProjectTreeActionHandler(unconfiguredProject,
                                                               projectServices,
-                                                              ws,
+                                                              new Lazy<Workspace>(() => ws),
                                                               environmentOptionsFactory,
                                                               userNotificationServices,
                                                               roslynServices,