Skip to content

Commit fd6ac06

Browse files
authored
Merge pull request #9411 from drewnoakes/fix-warning-and-net8-code
Fix two compilation warnings in the solution
2 parents b1e00e4 + e566912 commit fd6ac06

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Tree/Dependencies/Subscriptions/MSBuildDependencies/MSBuildDependencyFactoryBase.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ protected internal virtual ProjectTreeFlags UpdateTreeFlags(string id, ProjectTr
179179
/// Gets the <see cref="DiagnosticLevel"/> to set for a dependency, based on its resolved state and item properties.
180180
/// </summary>
181181
/// <param name="isResolved"><see langword="true"/> if the dependency is resolved, <see langword="false"/> if it is unresolved, or <see langword="null"/> if the status is not yet determined.</param>
182+
/// <param name="hasBuildError">Whether the MSBuild invocation that produced this data also encountered an error or not.</param>
182183
/// <param name="properties">The properties of the item.</param>
183184
/// <param name="defaultLevel">The diagnostic level to use when the property is either missing or empty. Intended to receive a dependency's current diagnostic level when an evaluation-only update is being processed.</param>
184185
/// <returns></returns>

tests/Common/ThrowingTraceListener.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ public override void WriteLine(string message)
3232
{
3333
}
3434

35+
#if !NET8_0_OR_GREATER
3536
[Serializable]
37+
#endif
3638
public class DebugAssertFailureException : Exception
3739
{
3840
public DebugAssertFailureException()
@@ -47,9 +49,11 @@ public DebugAssertFailureException(string message, Exception inner) : base(messa
4749
{
4850
}
4951

52+
#if !NET8_0_OR_GREATER
5053
protected DebugAssertFailureException(SerializationInfo info, StreamingContext context) : base(info, context)
5154
{
5255
}
56+
#endif
5357
}
5458
}
5559
}

0 commit comments

Comments
 (0)