Skip to content

Commit 142be8c

Browse files
Log warning if OOP doesn't return all of the requested tag helpers
With the current implementation, this should never happen. However, if something changes and *does* start happening, we'll log a warning.
1 parent d222e4e commit 142be8c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Discovery/OutOfProcTagHelperResolver.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,9 @@ protected virtual async ValueTask<ImmutableArray<TagHelperDescriptor>> ResolveTa
170170

171171
if (checksumsToFetch.Length != fetchedTagHelpers.Length)
172172
{
173+
_logger.LogWarning($"Expected to receive {checksumsToFetch.Length} tag helpers from Roslyn OOP, " +
174+
$"but received {fetchedTagHelpers.Length} instead. Returning a partial set of tag helpers.");
175+
173176
// We didn't receive all the tag helpers we requested. This is bad. However, instead of failing,
174177
// we'll just return the tag helpers we were able to retrieve.
175178
using var resultBuilder = new PooledArrayBuilder<TagHelperDescriptor>(capacity: result.Length);

0 commit comments

Comments
 (0)