Skip to content

Commit 1d7c262

Browse files
Make IOnInitialized a bit more general purpose
1 parent 27f8be9 commit 1d7c262

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/LanguageServer/RazorLanguageServerBenchmarkBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ await projectManager.UpdateAsync(
8787

8888
private class NoopClientNotifierService : IClientConnection, IOnInitialized
8989
{
90-
public Task OnInitializedAsync(VSInternalClientCapabilities clientCapabilities, CancellationToken cancellationToken)
90+
public Task OnInitializedAsync(ILspServices services, CancellationToken cancellationToken)
9191
{
9292
return Task.CompletedTask;
9393
}

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/ClientConnection.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using System.Threading;
66
using System.Threading.Tasks;
77
using Microsoft.AspNetCore.Razor.LanguageServer.Hosting;
8+
using Microsoft.CommonLanguageServerProtocol.Framework;
89
using Microsoft.VisualStudio.LanguageServer.Protocol;
910
using StreamJsonRpc;
1011

@@ -47,7 +48,7 @@ public async Task SendNotificationAsync(string method, CancellationToken cancell
4748
/// <summary>
4849
/// Fires when the language server is set to "Started".
4950
/// </summary>
50-
public Task OnInitializedAsync(VSInternalClientCapabilities clientCapabilities, CancellationToken cancellationToken)
51+
public Task OnInitializedAsync(ILspServices services, CancellationToken cancellationToken)
5152
{
5253
_initializedCompletionSource.TrySetResult(true);
5354
return Task.CompletedTask;

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/IOnInitialized.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33

44
using System.Threading;
55
using System.Threading.Tasks;
6+
using Microsoft.CommonLanguageServerProtocol.Framework;
67
using Microsoft.VisualStudio.LanguageServer.Protocol;
78

89
namespace Microsoft.AspNetCore.Razor.LanguageServer;
910

1011
internal interface IOnInitialized
1112
{
12-
Task OnInitializedAsync(VSInternalClientCapabilities clientCapabilities, CancellationToken cancellationToken);
13+
Task OnInitializedAsync(ILspServices services, CancellationToken cancellationToken);
1314
}

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorConfigurationEndpoint.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
using System.Threading.Tasks;
77
using Microsoft.AspNetCore.Razor.LanguageServer.EndpointContracts;
88
using Microsoft.CodeAnalysis.Razor.Logging;
9+
using Microsoft.CodeAnalysis.Razor.Protocol;
10+
using Microsoft.CommonLanguageServerProtocol.Framework;
911
using Microsoft.VisualStudio.LanguageServer.Protocol;
1012

1113
namespace Microsoft.AspNetCore.Razor.LanguageServer;
@@ -25,8 +27,11 @@ public async Task HandleNotificationAsync(DidChangeConfigurationParams request,
2527
await _optionsMonitor.UpdateAsync(cancellationToken).ConfigureAwait(false);
2628
}
2729

28-
public async Task OnInitializedAsync(VSInternalClientCapabilities clientCapabilities, CancellationToken cancellationToken)
30+
public async Task OnInitializedAsync(ILspServices services, CancellationToken cancellationToken)
2931
{
32+
var capabilitiesService = services.GetRequiredService<IClientCapabilitiesService>();
33+
var clientCapabilities = capabilitiesService.ClientCapabilities;
34+
3035
if (clientCapabilities.Workspace?.Configuration == true)
3136
{
3237
await _optionsMonitor.UpdateAsync(cancellationToken).ConfigureAwait(false);

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorInitializedEndpoint.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ internal class RazorInitializedEndpoint : INotificationHandler<InitializedParams
1919
public async Task HandleNotificationAsync(InitializedParams request, RazorRequestContext requestContext, CancellationToken cancellationToken)
2020
{
2121
var onStartedItems = requestContext.LspServices.GetRequiredServices<IOnInitialized>();
22-
var capabilitiesService = requestContext.GetRequiredService<IClientCapabilitiesService>();
2322

2423
var snapshotResolver = requestContext.LspServices.GetRequiredService<ISnapshotResolver>();
2524
await snapshotResolver.InitializeAsync(cancellationToken).ConfigureAwait(false);
@@ -29,7 +28,7 @@ public async Task HandleNotificationAsync(InitializedParams request, RazorReques
2928

3029
foreach (var onStartedItem in onStartedItems)
3130
{
32-
await onStartedItem.OnInitializedAsync(capabilitiesService.ClientCapabilities, cancellationToken).ConfigureAwait(false);
31+
await onStartedItem.OnInitializedAsync(requestContext.LspServices, cancellationToken).ConfigureAwait(false);
3332
}
3433
}
3534
}

0 commit comments

Comments
 (0)