Logger isn't null

Author: davidwengier

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget.cs

@@ -141,50 +141,50 @@ private async Task<SynchronizedResult<TVirtualDocumentSnapshot>> TrySynchronizeV
             return await _documentSynchronizer.TrySynchronizeVirtualDocumentAsync<TVirtualDocumentSnapshot>(requiredHostDocumentVersion, hostDocument.Uri, cancellationToken).ConfigureAwait(false);
         }
 
-        _logger?.LogDebug($"Trying to synchronize for {caller} to version {requiredHostDocumentVersion} of {hostDocument.Uri} for {hostDocument.GetProjectContext()?.Id ?? "(no project context)"}");
+        _logger.LogDebug($"Trying to synchronize for {caller} to version {requiredHostDocumentVersion} of {hostDocument.Uri} for {hostDocument.GetProjectContext()?.Id ?? "(no project context)"}");
 
         var virtualDocument = FindVirtualDocument<TVirtualDocumentSnapshot>(hostDocument.Uri, hostDocument.GetProjectContext());
 
         if (virtualDocument is { ProjectKey.Id: null })
         {
-            _logger?.LogDebug($"Trying to sync to a doc with no project Id. Waiting for document add.");
+            _logger.LogDebug($"Trying to sync to a doc with no project Id. Waiting for document add.");
             if (await _csharpVirtualDocumentAddListener.WaitForDocumentAddAsync(cancellationToken).ConfigureAwait(false))
             {
-                _logger?.LogDebug($"Wait successful!");
+                _logger.LogDebug($"Wait successful!");
                 virtualDocument = FindVirtualDocument<TVirtualDocumentSnapshot>(hostDocument.Uri, hostDocument.GetProjectContext());
             }
             else
             {
-                _logger?.LogDebug($"Timed out :(");
+                _logger.LogDebug($"Timed out :(");
             }
         }
 
         if (virtualDocument is null)
         {
-            _logger?.LogDebug($"No virtual document found, falling back to old code.");
+            _logger.LogDebug($"No virtual document found, falling back to old code.");
             return await _documentSynchronizer.TrySynchronizeVirtualDocumentAsync<TVirtualDocumentSnapshot>(requiredHostDocumentVersion, hostDocument.Uri, cancellationToken).ConfigureAwait(false);
         }
 
         var result = await _documentSynchronizer.TrySynchronizeVirtualDocumentAsync<TVirtualDocumentSnapshot>(requiredHostDocumentVersion, hostDocument.Uri, virtualDocument.Uri, rejectOnNewerParallelRequest, cancellationToken).ConfigureAwait(false);
-        _logger?.LogDebug($"{(result.Synchronized ? "Did" : "Did NOT")} synchronize for {caller}: Version {requiredHostDocumentVersion} for {result.VirtualSnapshot?.Uri}");
+        _logger.LogDebug($"{(result.Synchronized ? "Did" : "Did NOT")} synchronize for {caller}: Version {requiredHostDocumentVersion} for {result.VirtualSnapshot?.Uri}");
 
         // If we failed to sync on version 1, then it could be that we got new information while waiting, so try again
         if (requiredHostDocumentVersion == 1 && !result.Synchronized)
         {
-            _logger?.LogDebug($"Sync failed for v1 document. Trying to get virtual document again.");
+            _logger.LogDebug($"Sync failed for v1 document. Trying to get virtual document again.");
             virtualDocument = FindVirtualDocument<TVirtualDocumentSnapshot>(hostDocument.Uri, hostDocument.GetProjectContext());
 
             if (virtualDocument is null)
             {
-                _logger?.LogDebug($"No virtual document found, falling back to old code.");
+                _logger.LogDebug($"No virtual document found, falling back to old code.");
                 return await _documentSynchronizer.TrySynchronizeVirtualDocumentAsync<TVirtualDocumentSnapshot>(requiredHostDocumentVersion, hostDocument.Uri, cancellationToken).ConfigureAwait(false);
             }
 
-            _logger?.LogDebug($"Got virtual document after trying again {virtualDocument.Uri}. Trying to synchronize again.");
+            _logger.LogDebug($"Got virtual document after trying again {virtualDocument.Uri}. Trying to synchronize again.");
 
             // try again
             result = await _documentSynchronizer.TrySynchronizeVirtualDocumentAsync<TVirtualDocumentSnapshot>(requiredHostDocumentVersion, hostDocument.Uri, virtualDocument.Uri, rejectOnNewerParallelRequest, cancellationToken).ConfigureAwait(false);
-            _logger?.LogDebug($"{(result.Synchronized ? "Did" : "Did NOT")} synchronize for {caller}: Version {requiredHostDocumentVersion} for {result.VirtualSnapshot?.Uri}");
+            _logger.LogDebug($"{(result.Synchronized ? "Did" : "Did NOT")} synchronize for {caller}: Version {requiredHostDocumentVersion} for {result.VirtualSnapshot?.Uri}");
         }
 
         return result;

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_Diagnostics.cs

@@ -43,7 +43,7 @@ internal partial class RazorCustomMessageTarget
         {
             if (e is not OperationCanceledException)
             {
-                _logger?.LogError(e, $"Exception thrown in PullDiagnostic delegation");
+                _logger.LogError(e, $"Exception thrown in PullDiagnostic delegation");
             }
             // Return null if any of the tasks getting diagnostics results in an error
             return null;

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_SemanticTokens.cs

@@ -132,12 +132,12 @@ internal partial class RazorCustomMessageTarget
 
         if (response?.Data is null)
         {
-            _logger?.LogDebug($"Made one semantic token request to Roslyn for {semanticTokensParams.Ranges.Length} ranges but got null result back, due to sync issues");
+            _logger.LogDebug($"Made one semantic token request to Roslyn for {semanticTokensParams.Ranges.Length} ranges but got null result back, due to sync issues");
             // Weren't able to re-invoke C# semantic tokens but we have to indicate it's due to out of sync by providing the old version
             return new ProvideSemanticTokensResponse(tokens: null, hostDocumentSyncVersion: csharpDoc.HostDocumentSyncVersion ?? -1);
         }
 
-        _logger?.LogDebug($"Made one semantic token requests to Roslyn for {semanticTokensParams.Ranges.Length} ranges");
+        _logger.LogDebug($"Made one semantic token requests to Roslyn for {semanticTokensParams.Ranges.Length} ranges");
         return new ProvideSemanticTokensResponse(response.Data, semanticTokensParams.RequiredHostDocumentVersion);
     }
 

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_UpdateCSharpBuffer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT license. See License.txt in the project root for license information.
 
 using System;
@@ -40,7 +40,7 @@ internal async Task UpdateCSharpBufferCoreAsync(UpdateBufferRequest request, Can
 
         var hostDocumentUri = new Uri(request.HostDocumentFilePath);
 
-        _logger?.LogDebug($"UpdateCSharpBuffer for {request.HostDocumentVersion} of {hostDocumentUri} in {request.ProjectKeyId}");
+        _logger.LogDebug($"UpdateCSharpBuffer for {request.HostDocumentVersion} of {hostDocumentUri} in {request.ProjectKeyId}");
 
         // If we're generating unique file paths for virtual documents, then we have to take a different path here, and do more work
         if (_languageServerFeatureOptions.IncludeProjectKeyInGeneratedFilePath &&
@@ -54,7 +54,7 @@ request.ProjectKeyId is not null &&
                 // but the server clearly knows about it in a real project. That means its probably new, as Visual Studio opens a buffer
                 // for a document before we get the notifications about it being added to any projects. Lets try refreshing before
                 // we worry.
-                _logger?.LogDebug($"Refreshing virtual documents, and waiting for them, (for {hostDocumentUri})");
+                _logger.LogDebug($"Refreshing virtual documents, and waiting for them, (for {hostDocumentUri})");
 
                 var task = _csharpVirtualDocumentAddListener.WaitForDocumentAddAsync(cancellationToken);
                 _documentManager.RefreshVirtualDocuments();
@@ -70,7 +70,7 @@ request.ProjectKeyId is not null &&
                     // sync with their understanding of the document contents, and since changes come in as a list of changes,
                     // the user experience is broken. All we can do is hope the user closes and re-opens the document.
                     Debug.Fail($"Server wants to update {hostDocumentUri} in {request.ProjectKeyId} but we don't know about the document being in any projects");
-                    _logger?.LogError($"Server wants to update {hostDocumentUri} in {request.ProjectKeyId} by we only know about that document in misc files. Server and client are now out of sync.");
+                    _logger.LogError($"Server wants to update {hostDocumentUri} in {request.ProjectKeyId} by we only know about that document in misc files. Server and client are now out of sync.");
                     return;
                 }
             }
@@ -79,7 +79,7 @@ request.ProjectKeyId is not null &&
             {
                 if (virtualDocument.ProjectKey.Equals(ProjectKey.FromString(request.ProjectKeyId)))
                 {
-                    _logger?.LogDebug($"UpdateCSharpBuffer virtual doc for {request.HostDocumentVersion} of {virtualDocument.Uri}");
+                    _logger.LogDebug($"UpdateCSharpBuffer virtual doc for {request.HostDocumentVersion} of {virtualDocument.Uri}");
 
                     _documentManager.UpdateVirtualDocument<CSharpVirtualDocument>(
                         hostDocumentUri,
@@ -99,14 +99,14 @@ request.ProjectKeyId is not null &&
                 Debug.Fail("Multiple virtual documents seem to be supported, but none were updated, which is not impossible, but surprising.");
             }
 
-            _logger?.LogDebug($"UpdateCSharpBuffer couldn't find any virtual docs for {request.HostDocumentVersion} of {hostDocumentUri}");
+            _logger.LogDebug($"UpdateCSharpBuffer couldn't find any virtual docs for {request.HostDocumentVersion} of {hostDocumentUri}");
 
             // Don't know about document, no-op. This can happen if the language server found a project.razor.bin from an old build
             // and is sending us updates.
             return;
         }
 
-        _logger?.LogDebug($"UpdateCSharpBuffer fallback for {request.HostDocumentVersion} of {hostDocumentUri}");
+        _logger.LogDebug($"UpdateCSharpBuffer fallback for {request.HostDocumentVersion} of {hostDocumentUri}");
 
         _documentManager.UpdateVirtualDocument<CSharpVirtualDocument>(
             hostDocumentUri,