Improve signature of TryResolveAllProjects

Author: DustinCampbell

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/ProjectSystem/ISnapshotResolverExtensions.cs

@@ -12,29 +12,31 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer.ProjectSystem;
 
 internal static class ISnapshotResolverExtensions
 {
-    public static ImmutableArray<IProjectSnapshot> TryResolveAllProjects(
+    public static bool TryResolveAllProjects(
         this ISnapshotResolver snapshotResolver,
-        string documentFilePath)
+        string documentFilePath,
+        out ImmutableArray<IProjectSnapshot> projects)
     {
         var potentialProjects = snapshotResolver.FindPotentialProjects(documentFilePath);
 
-        using var projects = new PooledArrayBuilder<IProjectSnapshot>(capacity: potentialProjects.Length);
+        using var builder = new PooledArrayBuilder<IProjectSnapshot>(capacity: potentialProjects.Length);
 
         foreach (var project in potentialProjects)
         {
             if (project.GetDocument(documentFilePath) is not null)
             {
-                projects.Add(project);
+                builder.Add(project);
             }
         }
 
         var normalizedDocumentPath = FilePathNormalizer.Normalize(documentFilePath);
         var miscProject = snapshotResolver.GetMiscellaneousProject();
         if (miscProject.GetDocument(normalizedDocumentPath) is not null)
         {
-            projects.Add(miscProject);
+            builder.Add(miscProject);
         }
 
-        return projects.DrainToImmutable();
+        projects = builder.DrainToImmutable();
+        return projects.Length > 0;
     }
 }

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/ProjectSystem/RazorProjectService.cs

@@ -227,8 +227,7 @@ public Task UpdateDocumentAsync(string filePath, SourceText sourceText, int vers
     private void ActOnDocumentInMultipleProjects(string filePath, Action<IProjectSnapshot, string> action)
     {
         var textDocumentPath = FilePathNormalizer.Normalize(filePath);
-        var projects = _snapshotResolver.TryResolveAllProjects(textDocumentPath);
-        if (projects.IsEmpty)
+        if (!_snapshotResolver.TryResolveAllProjects(textDocumentPath, out var projects))
         {
             var miscFilesProject = _snapshotResolver.GetMiscellaneousProject();
             projects = [miscFilesProject];

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Tooltip/TagHelperTooltipFactoryBase.cs

@@ -31,8 +31,7 @@ protected TagHelperTooltipFactoryBase(ISnapshotResolver snapshotResolver)
 
     internal async Task<string?> GetProjectAvailabilityAsync(string documentFilePath, string tagHelperTypeName, CancellationToken cancellationToken)
     {
-        var projectSnapshots = _snapshotResolver.TryResolveAllProjects(documentFilePath);
-        if (projectSnapshots.IsEmpty)
+        if (!_snapshotResolver.TryResolveAllProjects(documentFilePath, out var projectSnapshots))
         {
             return null;
         }

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/SnapshotResolverTest.cs

@@ -85,10 +85,7 @@ public async Task TryResolveAllProjects_NoProjects_ReturnsFalse()
         await snapshotResolver.InitializeAsync(StrictMock.Of<ILspServices>(), DisposalToken);
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
-
-        // Assert
-        Assert.Empty(projects);
+        Assert.False(snapshotResolver.TryResolveAllProjects(documentFilePath, out _));
     }
 
     [Fact]
@@ -101,10 +98,7 @@ public async Task TryResolveAllProjects_OnlyMiscellaneousProjectDoesNotContainDo
         await snapshotResolver.InitializeAsync(StrictMock.Of<ILspServices>(), DisposalToken);
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
-
-        // Assert
-        Assert.Empty(projects);
+        Assert.False(snapshotResolver.TryResolveAllProjects(documentFilePath, out _));
     }
 
     [Fact]
@@ -116,7 +110,7 @@ public async Task TryResolveAllProjects_OnlyMiscellaneousProjectContainsDocument
         await snapshotResolver.InitializeAsync(StrictMock.Of<ILspServices>(), DisposalToken);
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
+        Assert.True(snapshotResolver.TryResolveAllProjects(documentFilePath, out var projects));
 
         // Assert
         var miscFilesProject = snapshotResolver.GetMiscellaneousProject();
@@ -138,10 +132,7 @@ await projectManager.UpdateAsync(updater =>
         });
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
-
-        // Assert
-        Assert.Empty(projects);
+        Assert.False(snapshotResolver.TryResolveAllProjects(documentFilePath, out _));
     }
 
     [Fact]
@@ -164,7 +155,7 @@ public async Task TryResolveAllProjects_OwnerProjectWithOthers_ReturnsTrue()
         });
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
+        Assert.True(snapshotResolver.TryResolveAllProjects(documentFilePath, out var projects));
 
         // Assert
         var project = Assert.Single(projects);
@@ -192,7 +183,7 @@ public async Task TryResolveAllProjects_MiscellaneousOwnerProjectWithOthers_Retu
         });
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
+        Assert.True(snapshotResolver.TryResolveAllProjects(documentFilePath, out var projects));
 
         // Assert
         var project = Assert.Single(projects);
@@ -217,7 +208,7 @@ public async Task TryResolveAllProjects_OwnerProjectDifferentCasing_ReturnsTrue(
         });
 
         // Act
-        var projects = snapshotResolver.TryResolveAllProjects(documentFilePath);
+        Assert.True(snapshotResolver.TryResolveAllProjects(documentFilePath, out var projects));
 
         // Assert
         var project = Assert.Single(projects);