CR Feedback: Use better names for HTML and non-HTML scopes

Author: DustinCampbell

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/RazorHtmlWriter.cs

@@ -93,111 +93,111 @@ private void AddSourceMapping(SourceSpan original, SourceSpan generated)
 
     public override void VisitRazorCommentBlock(RazorCommentBlockSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitRazorCommentBlock(node);
         }
     }
 
     public override void VisitRazorMetaCode(RazorMetaCodeSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitRazorMetaCode(node);
         }
     }
 
     public override void VisitMarkupTransition(MarkupTransitionSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitMarkupTransition(node);
         }
     }
 
     public override void VisitCSharpTransition(CSharpTransitionSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitCSharpTransition(node);
         }
     }
 
     public override void VisitCSharpEphemeralTextLiteral(CSharpEphemeralTextLiteralSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitCSharpEphemeralTextLiteral(node);
         }
     }
 
     public override void VisitCSharpExpressionLiteral(CSharpExpressionLiteralSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitCSharpExpressionLiteral(node);
         }
     }
 
     public override void VisitCSharpStatementLiteral(CSharpStatementLiteralSyntax node)
     {
-        using (IsNotHtml())
+        using (NonHtmlScope())
         {
             base.VisitCSharpStatementLiteral(node);
         }
     }
 
     public override void VisitMarkupStartTag(MarkupStartTagSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitMarkupStartTag(node);
         }
     }
 
     public override void VisitMarkupEndTag(MarkupEndTagSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitMarkupEndTag(node);
         }
     }
 
     public override void VisitMarkupTagHelperStartTag(MarkupTagHelperStartTagSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitMarkupTagHelperStartTag(node);
         }
     }
 
     public override void VisitMarkupTagHelperEndTag(MarkupTagHelperEndTagSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitMarkupTagHelperEndTag(node);
         }
     }
 
     public override void VisitMarkupEphemeralTextLiteral(MarkupEphemeralTextLiteralSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitMarkupEphemeralTextLiteral(node);
         }
     }
 
     public override void VisitMarkupTextLiteral(MarkupTextLiteralSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitMarkupTextLiteral(node);
         }
     }
 
     public override void VisitUnclassifiedTextLiteral(UnclassifiedTextLiteralSyntax node)
     {
-        using (IsHtml())
+        using (HtmlScope())
         {
             base.VisitUnclassifiedTextLiteral(node);
         }
@@ -215,12 +215,12 @@ public override void VisitToken(SyntaxToken token)
         }
     }
 
-    private readonly ref struct WriterStateSaver
+    private readonly ref struct WriterScope
     {
         private readonly RazorHtmlWriter _writer;
         private readonly bool _oldIsWritingHtml;
 
-        public WriterStateSaver(RazorHtmlWriter writer, bool isWritingHtml)
+        public WriterScope(RazorHtmlWriter writer, bool isWritingHtml)
         {
             _writer = writer;
             _oldIsWritingHtml = writer._isWritingHtml;
@@ -233,11 +233,11 @@ public void Dispose()
         }
     }
 
-    private WriterStateSaver IsHtml()
-        => new(this, isWritingHtml: true);
-
-    private WriterStateSaver IsNotHtml()
+    private WriterScope NonHtmlScope()
         => new(this, isWritingHtml: false);
+
+    private WriterScope HtmlScope()
+        => new(this, isWritingHtml: true);
     private void WriteHtmlToken(SyntaxToken token)
     {
         var content = token.Content;