Clean up PropertyDeclarationIntermediateNode

- Enable nullability
- Add constructor
- Remove unnecessary argument null check
- Change `Modifiers` property to return an `ImmutableArray<string>` rather than an `IList<string>` (backed by a `List<string>`).
- Make `PropertyName`, `ProeprtyType`, and `PropertyExpression` properties read-only.

Author: DustinCampbell

src/Compiler/Microsoft.AspNetCore.Razor.Language/test/CodeGeneration/DefaultDocumentWriterTest.cs

@@ -401,17 +401,11 @@ public void WriteDocument_WritesProperty()
         // Arrange
         var document = new DocumentIntermediateNode();
         var builder = IntermediateNodeBuilder.Create(document);
-        builder.Add(new PropertyDeclarationIntermediateNode()
-        {
-            Modifiers =
-                {
-                    "internal",
-                    "virtual",
-                },
-            PropertyName = "Foo",
-            PropertyType = IntermediateToken.CreateCSharpToken("string"),
-            PropertyExpression = "default"
-        });
+        builder.Add(new PropertyDeclarationIntermediateNode(
+            propertyName: "Foo",
+            propertyType: IntermediateToken.CreateCSharpToken("string"),
+            propertyExpression: "default",
+            modifiers: ["internal", "virtual"]));
 
         var codeDocument = TestRazorCodeDocument.CreateEmpty();
         var options = RazorCodeGenerationOptions.Default;

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Intermediate/PropertyDeclarationIntermediateNode.cs

@@ -1,32 +1,24 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable
-
-using System;
-using System.Collections.Generic;
+using System.Collections.Immutable;
 
 namespace Microsoft.AspNetCore.Razor.Language.Intermediate;
 
-public sealed class PropertyDeclarationIntermediateNode : MemberDeclarationIntermediateNode
+public sealed class PropertyDeclarationIntermediateNode(
+    string propertyName,
+    IntermediateToken propertyType,
+    string propertyExpression,
+    ImmutableArray<string> modifiers) : MemberDeclarationIntermediateNode
 {
-    public override IntermediateNodeCollection Children => IntermediateNodeCollection.ReadOnly;
-
-    public IList<string> Modifiers { get; } = new List<string>();
+    public string PropertyName { get; } = propertyName;
+    public IntermediateToken PropertyType { get; } = propertyType;
+    public string PropertyExpression { get; } = propertyExpression;
 
-    public string PropertyName { get; set; }
+    public ImmutableArray<string> Modifiers { get; } = modifiers.NullToEmpty();
 
-    public IntermediateToken PropertyType { get; set; }
-
-    public string PropertyExpression { get; set; }
+    public override IntermediateNodeCollection Children => IntermediateNodeCollection.ReadOnly;
 
     public override void Accept(IntermediateNodeVisitor visitor)
-    {
-        if (visitor == null)
-        {
-            throw new ArgumentNullException(nameof(visitor));
-        }
-
-        visitor.VisitPropertyDeclaration(this);
-    }
+        => visitor.VisitPropertyDeclaration(this);
 }

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Mvc/PagesPropertyInjectionPass.cs

@@ -48,13 +48,13 @@ protected override void ExecuteCore(RazorCodeDocument codeDocument, DocumentInte
         }
         else
         {
-            @class.Children.Add(new PropertyDeclarationIntermediateNode()
-            {
-                Modifiers = { "public" },
-                PropertyName = "Model",
-                PropertyType = modelType,
-                PropertyExpression = "ViewData.Model"
-            });
+            var propertyNode = new PropertyDeclarationIntermediateNode(
+                propertyName: "Model",
+                propertyType: modelType,
+                propertyExpression: "ViewData.Model",
+                modifiers: ["public"]);
+
+            @class.Children.Add(propertyNode);
         }
 
         static string nullableEnable(bool nullableEnabled, string code)