Fix RemoteInvocationException reporting (#9596)

The initial IFaultExceptionHandler MEF construction was no longer working due to refactoring. This changes it to no longer use MEF and just report directly.

Also update the ExceptionStrategy to ISerializable, since that will set the InnerException property if the other end of the connection is the same. This will make error reporting for us contain remote stacks instead of our own. If that's not the case, we still report as much as we can.

Anyone looking for more information on jsonrpc errors can look at microsoft/vs-streamjsonrpc@main/doc/exceptions.md

Author: Andrew Hall

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/JsonRPCFaultExceptionHandler.cs

@@ -164,8 +164,6 @@ protected override ILspServices ConstructLspServices()
         services.AddSingleton<WorkspaceDirectoryPathResolver, DefaultWorkspaceDirectoryPathResolver>();
         services.AddSingleton<RazorComponentSearchEngine, DefaultRazorComponentSearchEngine>();
 
-        services.AddSingleton<IFaultExceptionHandler, JsonRPCFaultExceptionHandler>();
-
         // Get the DefaultSession for telemetry. This is set by VS with
         // TelemetryService.SetDefaultSession and provides the correct
         // appinsights keys etc

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageServer.cs

@@ -2,50 +2,55 @@
 // Licensed under the MIT license. See License.txt in the project root for license information.
 
 using System;
-using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Composition;
 using Microsoft.Extensions.Logging;
 using Microsoft.VisualStudio.Telemetry;
+using StreamJsonRpc;
 
 namespace Microsoft.AspNetCore.Razor.Telemetry;
 
 [Shared]
 [Export(typeof(ITelemetryReporter))]
 internal class VSTelemetryReporter : TelemetryReporter
 {
-    private readonly IEnumerable<IFaultExceptionHandler> _faultExceptionHandlers;
     private readonly ILogger? _logger;
 
     [ImportingConstructor]
     public VSTelemetryReporter(
-        [Import(AllowDefault = true)] ILoggerFactory? loggerFactory = null,
-        [ImportMany] IEnumerable<IFaultExceptionHandler>? faultExceptionHandlers = null)
+        [Import(AllowDefault = true)] ILoggerFactory? loggerFactory = null)
             // Get the DefaultSession for telemetry. This is set by VS with
             // TelemetryService.SetDefaultSession and provides the correct
             // appinsights keys etc
             : base(ImmutableArray.Create(TelemetryService.DefaultSession))
     {
-        _faultExceptionHandlers = faultExceptionHandlers ?? Array.Empty<IFaultExceptionHandler>();
         _logger = loggerFactory?.CreateLogger<VSTelemetryReporter>();
     }
 
     protected override bool HandleException(Exception exception, string? message, params object?[] @params)
     {
-        var handled = false;
-        foreach (var handler in _faultExceptionHandlers)
+        if (exception is RemoteInvocationException remoteInvocationException)
         {
-            if (handler.HandleException(this, exception, message, @params))
-            {
-                // This behavior means that each handler still gets a chance
-                // to respond to the exception. There's no real reason for this other
-                // than best guess. When it was added, there was only one handler but
-                // it was intended to be easy to add more.
-                handled = true;
-            }
+            ReportRemoteInvocationException(remoteInvocationException);
+            return true;
         }
 
-        return handled;
+        return false;
+    }
+
+    private void ReportRemoteInvocationException(RemoteInvocationException remoteInvocationException)
+    {
+        if (remoteInvocationException.InnerException is Exception innerException)
+        {
+            ReportFault(innerException, "RIE: " + remoteInvocationException.Message);
+            return;
+        }
+
+        ReportFault(
+            remoteInvocationException,
+            remoteInvocationException.Message,
+            remoteInvocationException.ErrorCode,
+            remoteInvocationException.DeserializedErrorData);
     }
 
     protected override void LogTrace(string? message, params object?[] args)