Don't format if we didn't get a response from the Html formatter (#11646)

davidwengier · web-flow · commit 5a3144e5ee00 · 2025-03-21T08:33:35.000+11:00
Partial fix for the symptoms of #11643 Turns out there is a bug in our handling of Html documents in multi-target projects, and most likely everything has been quietly failing sometimes. Additionally it turns out that the new formatting engine doesn't format things nicely if we don't get a response from Html, so this PR fixes that, and stops things breaking users documents. I'll follow up with a proper fix soon.
diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentFormattingEndpoint.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentFormattingEndpoint.cs
@@ -56,7 +56,15 @@ public TextDocumentIdentifier GetTextDocumentIdentifier(DocumentFormattingParams
 
         var options = RazorFormattingOptions.From(request.Options, _optionsMonitor.CurrentValue.CodeBlockBraceOnNextLine);
 
-        var htmlChanges = await _htmlFormatter.GetDocumentFormattingEditsAsync(documentContext.Snapshot, documentContext.Uri, request.Options, cancellationToken).ConfigureAwait(false);
+        if (await _htmlFormatter.GetDocumentFormattingEditsAsync(
+            documentContext.Snapshot,
+            documentContext.Uri,
+            request.Options,
+            cancellationToken).ConfigureAwait(false) is not { } htmlChanges)
+        {
+            return null;
+        }
+
         var changes = await _razorFormattingService.GetDocumentFormattingChangesAsync(documentContext, htmlChanges, span: null, options, cancellationToken).ConfigureAwait(false);
 
         return [.. changes.Select(codeDocument.Source.Text.GetTextEdit)];
diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentOnTypeFormattingEndpoint.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentOnTypeFormattingEndpoint.cs
@@ -106,7 +106,17 @@ public TextDocumentIdentifier GetTextDocumentIdentifier(DocumentOnTypeFormatting
         }
         else if (triggerCharacterKind == RazorLanguageKind.Html)
         {
-            var htmlChanges = await _htmlFormatter.GetOnTypeFormattingEditsAsync(documentContext.Snapshot, documentContext.Uri, request.Position, request.Character, request.Options, cancellationToken).ConfigureAwait(false);
+            if (await _htmlFormatter.GetOnTypeFormattingEditsAsync(
+                documentContext.Snapshot,
+                documentContext.Uri,
+                request.Position,
+                request.Character,
+                request.Options,
+                cancellationToken).ConfigureAwait(false) is not { } htmlChanges)
+            {
+                return null;
+            }
+
             formattedChanges = await _razorFormattingService.GetHtmlOnTypeFormattingChangesAsync(documentContext, htmlChanges, options, hostDocumentIndex, request.Character[0], cancellationToken).ConfigureAwait(false);
         }
         else
diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentRangeFormattingEndpoint.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DocumentRangeFormattingEndpoint.cs
@@ -69,7 +69,15 @@ public TextDocumentIdentifier GetTextDocumentIdentifier(DocumentRangeFormattingP
 
         var options = RazorFormattingOptions.From(request.Options, _optionsMonitor.CurrentValue.CodeBlockBraceOnNextLine);
 
-        var htmlChanges = await _htmlFormatter.GetDocumentFormattingEditsAsync(documentContext.Snapshot, documentContext.Uri, request.Options, cancellationToken).ConfigureAwait(false);
+        if (await _htmlFormatter.GetDocumentFormattingEditsAsync(
+            documentContext.Snapshot,
+            documentContext.Uri,
+            request.Options,
+            cancellationToken).ConfigureAwait(false) is not { } htmlChanges)
+        {
+            return null;
+        }
+
         var changes = await _razorFormattingService.GetDocumentFormattingChangesAsync(documentContext, htmlChanges, request.Range.ToLinePositionSpan(), options, cancellationToken).ConfigureAwait(false);
 
         return [.. changes.Select(codeDocument.Source.Text.GetTextEdit)];
diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/HtmlFormatter.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/HtmlFormatter.cs
@@ -21,7 +21,7 @@ internal sealed class HtmlFormatter(
 {
     private readonly IClientConnection _clientConnection = clientConnection;
 
-    public async Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(
+    public async Task<ImmutableArray<TextChange>?> GetDocumentFormattingEditsAsync(
         IDocumentSnapshot documentSnapshot,
         Uri uri,
         FormattingOptions options,
@@ -44,14 +44,14 @@ public async Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(
 
         if (result?.Edits is null)
         {
-            return [];
+            return null;
         }
 
         var sourceText = await documentSnapshot.GetTextAsync(cancellationToken).ConfigureAwait(false);
         return result.Edits.SelectAsArray(sourceText.GetTextChange);
     }
 
-    public async Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(
+    public async Task<ImmutableArray<TextChange>?> GetOnTypeFormattingEditsAsync(
         IDocumentSnapshot documentSnapshot,
         Uri uri,
         Position position,
@@ -75,7 +75,7 @@ public async Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(
 
         if (result?.Edits is null)
         {
-            return [];
+            return null;
         }
 
         var sourceText = await documentSnapshot.GetTextAsync(cancellationToken).ConfigureAwait(false);
diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/IHtmlFormatter.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/IHtmlFormatter.cs
@@ -13,6 +13,6 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer.Formatting;
 
 internal interface IHtmlFormatter
 {
-    Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken);
-    Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken);
+    Task<ImmutableArray<TextChange>?> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken);
+    Task<ImmutableArray<TextChange>?> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken);
 }
diff --git a/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_HtmlFormatting.cs b/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_HtmlFormatting.cs
@@ -16,7 +16,7 @@ internal partial class RazorCustomMessageTarget
 {
     // Called by the Razor Language Server to invoke a razor/htmlFormatting request on the virtual Html buffer.
     [JsonRpcMethod(CustomMessageNames.RazorHtmlFormattingEndpoint, UseSingleObjectParameterDeserialization = true)]
-    public async Task<RazorDocumentFormattingResponse> HtmlFormattingAsync(RazorDocumentFormattingParams request, CancellationToken cancellationToken)
+    public async Task<RazorDocumentFormattingResponse?> HtmlFormattingAsync(RazorDocumentFormattingParams request, CancellationToken cancellationToken)
     {
         var response = new RazorDocumentFormattingResponse() { Edits = Array.Empty<TextEdit>() };
 
@@ -32,7 +32,7 @@ public async Task<RazorDocumentFormattingResponse> HtmlFormattingAsync(RazorDocu
         if (!synchronized || htmlDocument is null)
         {
             Debug.Fail("RangeFormatting not synchronized.");
-            return response;
+            return null;
         }
 
         var projectedUri = htmlDocument.Uri;
@@ -51,14 +51,19 @@ public async Task<RazorDocumentFormattingResponse> HtmlFormattingAsync(RazorDocu
             formattingParams,
             cancellationToken).ConfigureAwait(false);
 
-        response.Edits = edits?.Response ?? Array.Empty<TextEdit>();
+        if (edits?.Response is null)
+        {
+            return null;
+        }
+
+        response.Edits = edits.Response;
 
         return response;
     }
 
     // Called by the Razor Language Server to invoke a razor/htmlOnTypeFormatting request on the virtual Html buffer.
     [JsonRpcMethod(CustomMessageNames.RazorHtmlOnTypeFormattingEndpoint, UseSingleObjectParameterDeserialization = true)]
-    public async Task<RazorDocumentFormattingResponse> HtmlOnTypeFormattingAsync(RazorDocumentOnTypeFormattingParams request, CancellationToken cancellationToken)
+    public async Task<RazorDocumentFormattingResponse?> HtmlOnTypeFormattingAsync(RazorDocumentOnTypeFormattingParams request, CancellationToken cancellationToken)
     {
         var response = new RazorDocumentFormattingResponse() { Edits = Array.Empty<TextEdit>() };
 
@@ -69,7 +74,7 @@ public async Task<RazorDocumentFormattingResponse> HtmlOnTypeFormattingAsync(Raz
 
         if (!synchronized || htmlDocument is null)
         {
-            return response;
+            return null;
         }
 
         var formattingParams = new DocumentOnTypeFormattingParams()
@@ -88,7 +93,12 @@ public async Task<RazorDocumentFormattingResponse> HtmlOnTypeFormattingAsync(Raz
             formattingParams,
             cancellationToken).ConfigureAwait(false);
 
-        response.Edits = edits?.Response ?? Array.Empty<TextEdit>();
+        if (edits?.Response is null)
+        {
+            return null;
+        }
+
+        response.Edits = edits.Response;
 
         return response;
     }
diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingTestBase.cs b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingTestBase.cs
@@ -113,7 +113,7 @@ private async Task RunFormattingTestInternalAsync(string input, string expected,
         var htmlChanges = await htmlFormatter.GetDocumentFormattingEditsAsync(documentSnapshot, uri, options, DisposalToken);
 
         // Act
-        var changes = await formattingService.GetDocumentFormattingChangesAsync(documentContext, htmlChanges, range, razorOptions, DisposalToken);
+        var changes = await formattingService.GetDocumentFormattingChangesAsync(documentContext, htmlChanges.AssumeNotNull(), range, razorOptions, DisposalToken);
 
         // Assert
         var edited = source.WithChanges(changes);
@@ -182,7 +182,7 @@ private protected async Task RunOnTypeFormattingTestAsync(
 
             var htmlFormatter = new HtmlFormatter(client);
             var htmlChanges = await htmlFormatter.GetDocumentFormattingEditsAsync(documentSnapshot, uri, options, DisposalToken);
-            changes = await formattingService.GetHtmlOnTypeFormattingChangesAsync(documentContext, htmlChanges, razorOptions, hostDocumentIndex: positionAfterTrigger, triggerCharacter: triggerCharacter, DisposalToken);
+            changes = await formattingService.GetHtmlOnTypeFormattingChangesAsync(documentContext, htmlChanges.AssumeNotNull(), razorOptions, hostDocumentIndex: positionAfterTrigger, triggerCharacter: triggerCharacter, DisposalToken);
         }
 
         // Assert
diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/TestHtmlFormatter.cs b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/TestHtmlFormatter.cs
@@ -6,21 +6,20 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Razor.ProjectSystem;
-using Microsoft.AspNetCore.Razor.Threading;
 using Microsoft.CodeAnalysis.Text;
 using Microsoft.VisualStudio.LanguageServer.Protocol;
 
 namespace Microsoft.AspNetCore.Razor.LanguageServer.Formatting;
 
 internal class TestHtmlFormatter : IHtmlFormatter
 {
-    public Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken)
+    public Task<ImmutableArray<TextChange>?> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken)
     {
-        return SpecializedTasks.EmptyImmutableArray<TextChange>();
+        return Task.FromResult<ImmutableArray<TextChange>?>([]);
     }
 
-    public Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken)
+    public Task<ImmutableArray<TextChange>?> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken)
     {
-        return SpecializedTasks.EmptyImmutableArray<TextChange>();
+        return Task.FromResult<ImmutableArray<TextChange>?>([]);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,17 @@ public TextDocumentIdentifier GetTextDocumentIdentifier(DocumentOnTypeFormatting`
`106`	`106`	`}`
`107`	`107`	`else if (triggerCharacterKind == RazorLanguageKind.Html)`
`108`	`108`	`{`
`109`		`- var htmlChanges = await _htmlFormatter.GetOnTypeFormattingEditsAsync(documentContext.Snapshot, documentContext.Uri, request.Position, request.Character, request.Options, cancellationToken).ConfigureAwait(false);`
	`109`	`+ if (await _htmlFormatter.GetOnTypeFormattingEditsAsync(`
	`110`	`+ documentContext.Snapshot,`
	`111`	`+ documentContext.Uri,`
	`112`	`+ request.Position,`
	`113`	`+ request.Character,`
	`114`	`+ request.Options,`
	`115`	`+ cancellationToken).ConfigureAwait(false) is not { } htmlChanges)`
	`116`	`+ {`
	`117`	`+ return null;`
	`118`	`+ }`
	`119`	`+`
`110`	`120`	`formattedChanges = await _razorFormattingService.GetHtmlOnTypeFormattingChangesAsync(documentContext, htmlChanges, options, hostDocumentIndex, request.Character[0], cancellationToken).ConfigureAwait(false);`
`111`	`121`	`}`
`112`	`122`	`else`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ internal sealed class HtmlFormatter(`
`21`	`21`	`{`
`22`	`22`	`private readonly IClientConnection _clientConnection = clientConnection;`
`23`	`23`
`24`		`- public async Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(`
	`24`	`+ public async Task<ImmutableArray<TextChange>?> GetDocumentFormattingEditsAsync(`
`25`	`25`	`IDocumentSnapshot documentSnapshot,`
`26`	`26`	`Uri uri,`
`27`	`27`	`FormattingOptions options,`
`@@ -44,14 +44,14 @@ public async Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(`
`44`	`44`
`45`	`45`	`if (result?.Edits is null)`
`46`	`46`	`{`
`47`		`- return [];`
	`47`	`+ return null;`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`var sourceText = await documentSnapshot.GetTextAsync(cancellationToken).ConfigureAwait(false);`
`51`	`51`	`return result.Edits.SelectAsArray(sourceText.GetTextChange);`
`52`	`52`	`}`
`53`	`53`
`54`		`- public async Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(`
	`54`	`+ public async Task<ImmutableArray<TextChange>?> GetOnTypeFormattingEditsAsync(`
`55`	`55`	`IDocumentSnapshot documentSnapshot,`
`56`	`56`	`Uri uri,`
`57`	`57`	`Position position,`
`@@ -75,7 +75,7 @@ public async Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(`
`75`	`75`
`76`	`76`	`if (result?.Edits is null)`
`77`	`77`	`{`
`78`		`- return [];`
	`78`	`+ return null;`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`var sourceText = await documentSnapshot.GetTextAsync(cancellationToken).ConfigureAwait(false);`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer.Formatting;`
`13`	`13`
`14`	`14`	`internal interface IHtmlFormatter`
`15`	`15`	`{`
`16`		`- Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken);`
`17`		`- Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken);`
	`16`	`+ Task<ImmutableArray<TextChange>?> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken);`
	`17`	`+ Task<ImmutableArray<TextChange>?> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken);`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ internal partial class RazorCustomMessageTarget`
`16`	`16`	`{`
`17`	`17`	`// Called by the Razor Language Server to invoke a razor/htmlFormatting request on the virtual Html buffer.`
`18`	`18`	`[JsonRpcMethod(CustomMessageNames.RazorHtmlFormattingEndpoint, UseSingleObjectParameterDeserialization = true)]`
`19`		`- public async Task<RazorDocumentFormattingResponse> HtmlFormattingAsync(RazorDocumentFormattingParams request, CancellationToken cancellationToken)`
	`19`	`+ public async Task<RazorDocumentFormattingResponse?> HtmlFormattingAsync(RazorDocumentFormattingParams request, CancellationToken cancellationToken)`
`20`	`20`	`{`
`21`	`21`	`var response = new RazorDocumentFormattingResponse() { Edits = Array.Empty<TextEdit>() };`
`22`	`22`
`@@ -32,7 +32,7 @@ public async Task<RazorDocumentFormattingResponse> HtmlFormattingAsync(RazorDocu`
`32`	`32`	`if (!synchronized \|\| htmlDocument is null)`
`33`	`33`	`{`
`34`	`34`	`Debug.Fail("RangeFormatting not synchronized.");`
`35`		`- return response;`
	`35`	`+ return null;`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`var projectedUri = htmlDocument.Uri;`
`@@ -51,14 +51,19 @@ public async Task<RazorDocumentFormattingResponse> HtmlFormattingAsync(RazorDocu`
`51`	`51`	`formattingParams,`
`52`	`52`	`cancellationToken).ConfigureAwait(false);`
`53`	`53`
`54`		`- response.Edits = edits?.Response ?? Array.Empty<TextEdit>();`
	`54`	`+ if (edits?.Response is null)`
	`55`	`+ {`
	`56`	`+ return null;`
	`57`	`+ }`
	`58`	`+`
	`59`	`+ response.Edits = edits.Response;`
`55`	`60`
`56`	`61`	`return response;`
`57`	`62`	`}`
`58`	`63`
`59`	`64`	`// Called by the Razor Language Server to invoke a razor/htmlOnTypeFormatting request on the virtual Html buffer.`
`60`	`65`	`[JsonRpcMethod(CustomMessageNames.RazorHtmlOnTypeFormattingEndpoint, UseSingleObjectParameterDeserialization = true)]`
`61`		`- public async Task<RazorDocumentFormattingResponse> HtmlOnTypeFormattingAsync(RazorDocumentOnTypeFormattingParams request, CancellationToken cancellationToken)`
	`66`	`+ public async Task<RazorDocumentFormattingResponse?> HtmlOnTypeFormattingAsync(RazorDocumentOnTypeFormattingParams request, CancellationToken cancellationToken)`
`62`	`67`	`{`
`63`	`68`	`var response = new RazorDocumentFormattingResponse() { Edits = Array.Empty<TextEdit>() };`
`64`	`69`
`@@ -69,7 +74,7 @@ public async Task<RazorDocumentFormattingResponse> HtmlOnTypeFormattingAsync(Raz`
`69`	`74`
`70`	`75`	`if (!synchronized \|\| htmlDocument is null)`
`71`	`76`	`{`
`72`		`- return response;`
	`77`	`+ return null;`
`73`	`78`	`}`
`74`	`79`
`75`	`80`	`var formattingParams = new DocumentOnTypeFormattingParams()`
`@@ -88,7 +93,12 @@ public async Task<RazorDocumentFormattingResponse> HtmlOnTypeFormattingAsync(Raz`
`88`	`93`	`formattingParams,`
`89`	`94`	`cancellationToken).ConfigureAwait(false);`
`90`	`95`
`91`		`- response.Edits = edits?.Response ?? Array.Empty<TextEdit>();`
	`96`	`+ if (edits?.Response is null)`
	`97`	`+ {`
	`98`	`+ return null;`
	`99`	`+ }`
	`100`	`+`
	`101`	`+ response.Edits = edits.Response;`
`92`	`102`
`93`	`103`	`return response;`
`94`	`104`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,21 +6,20 @@`
`6`	`6`	`using System.Threading;`
`7`	`7`	`using System.Threading.Tasks;`
`8`	`8`	`using Microsoft.AspNetCore.Razor.ProjectSystem;`
`9`		`-using Microsoft.AspNetCore.Razor.Threading;`
`10`	`9`	`using Microsoft.CodeAnalysis.Text;`
`11`	`10`	`using Microsoft.VisualStudio.LanguageServer.Protocol;`
`12`	`11`
`13`	`12`	`namespace Microsoft.AspNetCore.Razor.LanguageServer.Formatting;`
`14`	`13`
`15`	`14`	`internal class TestHtmlFormatter : IHtmlFormatter`
`16`	`15`	`{`
`17`		`- public Task<ImmutableArray<TextChange>> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken)`
	`16`	`+ public Task<ImmutableArray<TextChange>?> GetDocumentFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, FormattingOptions options, CancellationToken cancellationToken)`
`18`	`17`	`{`
`19`		`- return SpecializedTasks.EmptyImmutableArray<TextChange>();`
	`18`	`+ return Task.FromResult<ImmutableArray<TextChange>?>([]);`
`20`	`19`	`}`
`21`	`20`
`22`		`- public Task<ImmutableArray<TextChange>> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken)`
	`21`	`+ public Task<ImmutableArray<TextChange>?> GetOnTypeFormattingEditsAsync(IDocumentSnapshot documentSnapshot, Uri uri, Position position, string triggerCharacter, FormattingOptions options, CancellationToken cancellationToken)`
`23`	`22`	`{`
`24`		`- return SpecializedTasks.EmptyImmutableArray<TextChange>();`
	`23`	`+ return Task.FromResult<ImmutableArray<TextChange>?>([]);`
`25`	`24`	`}`
`26`	`25`	`}`