Package the extension into a nupkg

Author: Andrew Hall

src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Microsoft.VisualStudioCode.RazorExtension.csproj

@@ -4,20 +4,29 @@
     <TargetFramework>$(NetVSCode)</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
+    <IsShippingPackage>true</IsShippingPackage>
 
-    <!-- Ensure we run our custom target, below, to copy compiler project references -->
-    <TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);CopyProjectReferencesToPackage</TargetsForTfmSpecificBuildOutput>
+    <!--
+        Build a nuget package for this project.  This is not consumed as a standard NuGet package; it just
+    contains the extension binaries to be packaged in the VS Code VSIX.
+    -->
+    <IsPackable>true</IsPackable>
+
+    <!-- This is not a standard nuget package and only consumed by the extension build. We don't care if the folder structure doesn't match what nuget expects. -->
+    <NoWarn>$(NoWarn);NU5100</NoWarn>
+
+    <BeforePack>PackPublishContent;$(BeforePack)</BeforePack>
   </PropertyGroup>
-  <ItemGroup>
-    <Compile Remove="S:\razor\src\Shared\files\LanguageSupport\IsExternalInit.cs" />
-  </ItemGroup>
 
   <ItemGroup>
+    <!-- Below package references are covered by the binaries shipped by roslyn and do not need to be packaged-->
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
     <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" />
     <PackageReference Include="Microsoft.Extensions.ObjectPool" />
     <PackageReference Include="Microsoft.Extensions.Logging" />
     <PackageReference Include="Microsoft.CodeAnalysis.ExternalAccess.Razor.Features" />
+
+    <!-- Roslyn does not use Microsoft.VisualStudio.LanguageServer.Protocol so we have to pack it -->
     <PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol" GeneratePathProperty="True" />
   </ItemGroup>
 
@@ -31,24 +40,29 @@
     <InternalsVisibleTo Include="Microsoft.VisualStudioCode.RazorExtension.Test" Key="$(RazorKey)" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Content Include="$(PkgMicrosoft_VisualStudio_LanguageServer_Protocol)\lib\netstandard2.0\Microsoft.VisualStudio.LanguageServer.Protocol.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
-  </ItemGroup>
-
-  <!--
-    Include the build output of project references in the package created. We need to do this because the compiler packages
-    are published via a separate process to tooling, so anything that references this package will try to transitively pull
-    in the compiler packages, but will be unable to find packages with the same version.
-
-    This means we end up with the package for this project including the following additional DLLs:
-      * Microsoft.CodeAnalysis.Razor.Compiler.dll
-      * Microsoft.AspNetCore.Razor.Utilities.Shared.dll
-
-    (and Microsoft.VisualStudioCode.RazorExtension.dll obviously)
-  -->
-  <Target DependsOnTargets="ResolveReferences" Name="CopyProjectReferencesToPackage">
+  <Target Name="PackPublishContent" DependsOnTargets="Publish">
     <ItemGroup>
-      <BuildOutputInPackage Include="@(ReferenceCopyLocalPaths-&gt;WithMetadataValue('ReferenceSourceTarget', 'ProjectReference'))" />
+      <Content Include="$(PkgMicrosoft_VisualStudio_LanguageServer_Protocol)\lib\netstandard2.0\Microsoft.VisualStudio.LanguageServer.Protocol.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(TargetPath)" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
+
+      <Content Include="$(PublishDir)\Microsoft.AspNetCore.Razor.Utilities.Shared.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\Microsoft.CodeAnalysis.Razor.Compiler.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\Microsoft.CodeAnalysis.Razor.Workspaces.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
+      
+      <!-- We don't need to include everything in the bin folder but we do need to add localization resources for the compiler dll -->
+      <Content Include="$(PublishDir)\cs\**\*.*" Pack="true" PackagePath="content\cs\" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\de\**\*.*" Pack="true" PackagePath="content\de\" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\es\**\*.*" Pack="true" PackagePath="content\es\" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\fr\**\*.*" Pack="true" PackagePath="content\fr\" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\it\**\*.*" Pack="true" PackagePath="content\it\" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\ja\**\*.*" Pack="true" PackagePath="content\ja\" CopyToOutputDirectory="PreserveNewest" />
+      <Content Include="$(PublishDir)\ko\**\*.*" Pack="true" PackagePath="content\ko\" CopyToOutputDirectory="false" />
+      <Content Include="$(PublishDir)\pl\**\*.*" Pack="true" PackagePath="content\pl\" CopyToOutputDirectory="false" />
+      <Content Include="$(PublishDir)\pt-BR\**\*.*" Pack="true" PackagePath="content\pt-BR\" CopyToOutputDirectory="false" />
+      <Content Include="$(PublishDir)\ru\**\*.*" Pack="true" PackagePath="content\ru\" CopyToOutputDirectory="false" />
+      <Content Include="$(PublishDir)\tr\**\*.*" Pack="true" PackagePath="content\tr\" CopyToOutputDirectory="false" />
+      <Content Include="$(PublishDir)\zh-Hans\**\*.*" Pack="true" PackagePath="content\zh-Hans\" CopyToOutputDirectory="false" />
+      <Content Include="$(PublishDir)\zh-Hant\**\*.*" Pack="true" PackagePath="content\zh-Hant\" CopyToOutputDirectory="false" />
     </ItemGroup>
   </Target>
 </Project>