Commit 64ba82d
Andrew Hall
Remove Razor EA For Roslyn (#11510)
Razor side of dotnet/roslyn#77715
* Remove `Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace`, we
no longer ship an EA for Roslyn
* Add a new `Microsoft.VisualStudioCode.RazorExtension` and package that
will be put in `.razorExtension` in VS Code
* This will contain endpoints and LSP services that will be loaded in
the roslyn language server for VS Code.
* Remove `Microsoft.AspNetCore.Razor.ProjectEngineHost` as that layer of
separation is no longer needed
Copilot description below
-----------------------------------------------------------------------------------
This pull request includes several changes to the `Razor` project,
focusing on project restructuring and dependency updates. The most
important changes include adding a new package version, renaming and
removing projects, and updating the `RazorWorkspaceListenerBase` class.
### Project restructuring:
*
[`Razor.sln`](diffhunk://#diff-2561476bb155e6bc1eba8028e5a49517b814ef36031e472459611e82a894b7baL109-R111):
Renamed `Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace` to
`Microsoft.VisualStudioCode.RazorExtension` and removed
`Microsoft.AspNetCore.Razor.ProjectEngineHost` and its test project.
[[1]](diffhunk://#diff-2561476bb155e6bc1eba8028e5a49517b814ef36031e472459611e82a894b7baL109-R111)
[[2]](diffhunk://#diff-2561476bb155e6bc1eba8028e5a49517b814ef36031e472459611e82a894b7baL421-L428)
[[3]](diffhunk://#diff-2561476bb155e6bc1eba8028e5a49517b814ef36031e472459611e82a894b7baL594)
*
[`docs/ProjectsAndLayering.md`](diffhunk://#diff-719f03eb5eb40ba6369e5c7987571576b6a119f40667a0fffc63667c55f2928cL108-R108):
Updated documentation to reflect the new project name.
### Code updates:
*
[`RazorWorkspaceListenerBase.cs`](diffhunk://#diff-30acd8a866ed49034848667c8d9bc0def03390f1ffe494fae192cb667028b497R45-L60):
Replaced `_disposed` with `_disposeTokenSource.IsCancellationRequested`
for better disposal handling and added `_tagHelperResolver` and
`_projectChecksums` fields.
[[1]](diffhunk://#diff-30acd8a866ed49034848667c8d9bc0def03390f1ffe494fae192cb667028b497R45-L60)
[[2]](diffhunk://#diff-30acd8a866ed49034848667c8d9bc0def03390f1ffe494fae192cb667028b497L96-R95)
[[3]](diffhunk://#diff-30acd8a866ed49034848667c8d9bc0def03390f1ffe494fae192cb667028b497L176-R175)
[[4]](diffhunk://#diff-30acd8a866ed49034848667c8d9bc0def03390f1ffe494fae192cb667028b497L238-R267)
### Project removals:
* Removed `Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace`
project and its related files.
[[1]](diffhunk://#diff-0accfb04f401ca4d46e88623878593903f55f5dd25885a95668f3f6d0dc98da9L1-L46)
[[2]](diffhunk://#diff-9ef9168b7e136073656fa86159c46abf47a068f616c37046de8facd164c10c64L1-L6)
[[3]](diffhunk://#diff-30acd8a866ed49034848667c8d9bc0def03390f1ffe494fae192cb667028b497R6-L30)File tree
233 files changed
+1258
-2314
lines changed- docs
- eng
- src
- Compiler
- Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test
- Microsoft.CodeAnalysis.Razor.Compiler/src
- Razor
- benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks
- ProjectSystem
- src
- Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace
- Microsoft.AspNetCore.Razor.LanguageServer
- Extensions
- ProjectSystem
- Microsoft.AspNetCore.Razor.ProjectEngineHost
- ProjectSystem
- PublicAPI
- Resources
- xlf
- Microsoft.CodeAnalysis.Razor.Workspaces
- Extensions
- ProjectEngineHost
- ProjectSystem
- Resources
- xlf
- Serialization
- MessagePack
- Formatters
- TagHelpers
- Resolvers
- Telemetry
- Threading
- Tooltip
- Utilities
- Microsoft.CodeAnalysis.Remote.Razor
- ProjectSystem
- TagHelpers
- Microsoft.VisualStudio.DevKit.Razor
- Microsoft.VisualStudio.LanguageServices.Razor
- DynamicFiles
- LanguageClient
- Cohost
- ProjectSystem
- Microsoft.VisualStudio.LegacyEditor.Razor
- Parsing
- Microsoft.VisualStudio.RazorExtension
- Microsoft.VisualStudioCode.RazorExtension
- Endpoints
- Services
- rzls
- test
- Microsoft.AspNetCore.Razor.LanguageServer.Test
- DocumentHighlighting
- Formatting_NetFx
- Hover
- MapCode
- Microsoft.AspNetCore.Razor.ProjectEngineHost.Test
- Serialization
- Utilities
- Microsoft.AspNetCore.Razor.Test.Common.Tooling
- LanguageServer
- ProjectSystem
- Workspaces
- Microsoft.CodeAnalysis.Razor.Workspaces.Test
- Formatting
- ProjectEngineHost
- ProjectSystem
- Utilities
- Microsoft.VisualStudio.LanguageServices.Razor.Test
- Cohost
- Discovery
- LanguageClient
- DynamicFiles
- Microsoft.VisualStudio.LegacyEditor.Razor.Test
- Parsing
- Microsoft.VisualStudioCode.RazorExtension.Test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
233 files changed
+1258
-2314
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | | - | |
| 90 | + | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
| |||
106 | 107 | | |
107 | 108 | | |
108 | 109 | | |
109 | | - | |
| 110 | + | |
110 | 111 | | |
111 | 112 | | |
112 | | - | |
| 113 | + | |
113 | 114 | | |
114 | | - | |
115 | | - | |
| 115 | + | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
| 111 | + | |
114 | 112 | | |
115 | 113 | | |
116 | 114 | | |
117 | 115 | | |
118 | 116 | | |
119 | 117 | | |
120 | 118 | | |
121 | | - | |
122 | | - | |
123 | 119 | | |
124 | 120 | | |
125 | 121 | | |
| |||
418 | 414 | | |
419 | 415 | | |
420 | 416 | | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | 417 | | |
430 | 418 | | |
431 | 419 | | |
| |||
458 | 446 | | |
459 | 447 | | |
460 | 448 | | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | 449 | | |
470 | 450 | | |
471 | 451 | | |
| |||
591 | 571 | | |
592 | 572 | | |
593 | 573 | | |
594 | | - | |
595 | 574 | | |
596 | 575 | | |
597 | 576 | | |
598 | 577 | | |
599 | | - | |
600 | 578 | | |
601 | 579 | | |
602 | 580 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
0 commit comments