Skip to content

Commit 6e8d2aa

Browse files
committed
Nits
1 parent dcee923 commit 6e8d2aa

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Razor/ExtractToNewComponentCodeActionProvider.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,8 @@ public Task<ImmutableArray<RazorVSInternalCodeAction>> ProvideAsync(RazorCodeAct
5252
return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
5353
}
5454

55-
var (startElementNode, endElementNode) = GetStartAndEndElements(context, syntaxTree, _logger);
56-
5755
// Make sure the selection starts on an element tag
56+
var (startElementNode, endElementNode) = GetStartAndEndElements(context, syntaxTree, _logger);
5857
if (startElementNode is null)
5958
{
6059
return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
@@ -72,7 +71,7 @@ public Task<ImmutableArray<RazorVSInternalCodeAction>> ProvideAsync(RazorCodeAct
7271
AddComponentDependenciesInRange(dependencyScanRoot,
7372
actionParams.ExtractStart,
7473
actionParams.ExtractEnd,
75-
ref actionParams);
74+
actionParams);
7675

7776
if (IsMultiPointSelection(context.Request.Range))
7877
{
@@ -273,7 +272,7 @@ private static (SyntaxNode? Start, SyntaxNode? End) FindContainingSiblingPair(Sy
273272
return null;
274273
}
275274

276-
private static void AddComponentDependenciesInRange(SyntaxNode root, int extractStart, int extractEnd, ref ExtractToNewComponentCodeActionParams actionParams)
275+
private static void AddComponentDependenciesInRange(SyntaxNode root, int extractStart, int extractEnd, ExtractToNewComponentCodeActionParams actionParams)
277276
{
278277
var components = new HashSet<string>();
279278
var extractSpan = new TextSpan(extractStart, extractEnd - extractStart);
@@ -285,7 +284,7 @@ private static void AddComponentDependenciesInRange(SyntaxNode root, int extract
285284
var tagHelperInfo = GetTagHelperInfo(node);
286285
if (tagHelperInfo != null)
287286
{
288-
AddDependenciesFromTagHelperInfo(tagHelperInfo, components, ref actionParams);
287+
AddDependenciesFromTagHelperInfo(tagHelperInfo, components, actionParams);
289288
}
290289
}
291290
}
@@ -307,7 +306,7 @@ private static bool IsMarkupTagHelperElement(SyntaxNode node, TextSpan extractSp
307306
return null;
308307
}
309308

310-
private static void AddDependenciesFromTagHelperInfo(TagHelperInfo tagHelperInfo, HashSet<string> components, ref ExtractToNewComponentCodeActionParams actionParams)
309+
private static void AddDependenciesFromTagHelperInfo(TagHelperInfo tagHelperInfo, HashSet<string> components, ExtractToNewComponentCodeActionParams actionParams)
311310
{
312311
foreach (var descriptor in tagHelperInfo.BindingResult.Descriptors)
313312
{

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/CodeActions/Razor/ExtractToNewComponentCodeActionProviderTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public async Task Handle_InProperMarkup_ReturnsEmpty()
238238
// Arrange
239239
var documentPath = "c:/Test.razor";
240240
var contents = """
241-
page "/"
241+
@page "/"
242242
243243
<PageTitle>Home</PageTitle>
244244

0 commit comments

Comments
 (0)