OpenDocumentGenerator: Move logging message to ProcessBatchAsync

Move a logging message from the point that a document is enqueued to the point that is dequeued and processed. This also avoids instantiating a DocumentSnapshot to get its Version until later.

Author: DustinCampbell

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/OpenDocumentGenerator.cs

@@ -85,6 +85,8 @@ private async ValueTask ProcessBatchAsync(ImmutableArray<DocumentKey> items, Can
                 continue;
             }
 
+            _logger.LogDebug($"Generating {key} at version {document.Version}");
+
             var codeDocument = await document.GetGeneratedOutputAsync(token).ConfigureAwait(false);
 
             foreach (var listener in _listeners)
@@ -117,10 +119,7 @@ private void ProjectManager_Changed(object? sender, ProjectChangeEventArgs args)
 
                     foreach (var documentFilePath in newProject.DocumentFilePaths)
                     {
-                        if (newProject.TryGetDocument(documentFilePath, out var document))
-                        {
-                            EnqueueIfNecessary(document.Key, document.Version);
-                        }
+                        EnqueueIfNecessary(new(newProject.Key, documentFilePath));
                     }
 
                     break;
@@ -135,13 +134,13 @@ private void ProjectManager_Changed(object? sender, ProjectChangeEventArgs args)
                     var newProject = args.Newer.AssumeNotNull();
                     var documentFilePath = args.DocumentFilePath.AssumeNotNull();
 
+                    EnqueueIfNecessary(new(newProject.Key, documentFilePath));
+
                     if (newProject.TryGetDocument(documentFilePath, out var document))
                     {
-                        EnqueueIfNecessary(document.Key, document.Version);
-
                         foreach (var relatedDocument in newProject.GetRelatedDocuments(document))
                         {
-                            EnqueueIfNecessary(relatedDocument.Key, relatedDocument.Version);
+                            EnqueueIfNecessary(relatedDocument.Key);
                         }
                     }
 
@@ -162,7 +161,7 @@ private void ProjectManager_Changed(object? sender, ProjectChangeEventArgs args)
 
                             if (newProject.TryGetDocument(relatedDocumentFilePath, out var newRelatedDocument))
                             {
-                                EnqueueIfNecessary(newRelatedDocument.Key, newRelatedDocument.Version);
+                                EnqueueIfNecessary(newRelatedDocument.Key);
                             }
                         }
                     }
@@ -177,16 +176,14 @@ private void ProjectManager_Changed(object? sender, ProjectChangeEventArgs args)
                 }
         }
 
-        void EnqueueIfNecessary(DocumentKey documentKey, int documentVersion)
+        void EnqueueIfNecessary(DocumentKey documentKey)
         {
             if (!_options.UpdateBuffersForClosedDocuments &&
                 !_projectManager.IsDocumentOpen(documentKey.FilePath))
             {
                 return;
             }
 
-            _logger.LogDebug($"Enqueuing generation of {documentKey.FilePath} in {documentKey.ProjectKey.Id} at version {documentVersion}");
-
             _workQueue.AddWork(documentKey);
         }
     }