Change IFallbackProjectManager.IsFallbackProject to take a ProjectKey

Update IFallbackProjectManager.IsFallbackProject(...) to take a ProjectKey rather than a ProjectSnapshot. In addition, this commit includes a couple of changes to reorder some checks to avoid creating a ProjectSnapshot if it's not a fallback project.

Author: DustinCampbell

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Documents/EditorDocumentManagerListener.cs

@@ -247,8 +247,8 @@ private Task Document_OpenedAsync(object sender, CancellationToken cancellationT
                 {
                     var (document, fallbackProjectManager, telemetryReporter, cancellationToken) = state;
 
-                    if (updater.TryGetProject(document.ProjectKey, out var project) &&
-                        fallbackProjectManager.IsFallbackProject(project))
+                    if (fallbackProjectManager.IsFallbackProject(document.ProjectKey) &&
+                        updater.TryGetProject(document.ProjectKey, out var project))
                     {
                         // The user is opening a document that is part of a fallback project. This is a scenario we are very interested in knowing more about
                         // so fire some telemetry. We can't log details about the project, for PII reasons, but we can use document count and tag helper count

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/DynamicFiles/BackgroundDocumentGenerator.cs

@@ -96,7 +96,7 @@ public virtual void Enqueue(ProjectSnapshot project, DocumentSnapshot document)
             return;
         }
 
-        if (_fallbackProjectManager.IsFallbackProject(project))
+        if (_fallbackProjectManager.IsFallbackProject(project.Key))
         {
             // We don't support closed file code generation for fallback projects
             return;

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/FallbackProjectManager.cs

@@ -70,8 +70,8 @@ private void ProjectManager_Changed(object sender, ProjectChangeEventArgs e)
         }
     }
 
-    public bool IsFallbackProject(ProjectSnapshot project)
-        => _fallbackProjects.Contains(project.Key);
+    public bool IsFallbackProject(ProjectKey projectKey)
+        => _fallbackProjects.Contains(projectKey);
 
     internal void DynamicFileAdded(
         ProjectId projectId,
@@ -84,7 +84,7 @@ internal void DynamicFileAdded(
         {
             if (_projectManager.TryGetProject(razorProjectKey, out var project))
             {
-                if (IsFallbackProject(project))
+                if (IsFallbackProject(razorProjectKey))
                 {
                     // If this is a fallback project, then Roslyn may not track documents in the project, so these dynamic file notifications
                     // are the only way to know about files in the project.
@@ -114,8 +114,8 @@ internal void DynamicFileRemoved(
     {
         try
         {
-            if (_projectManager.TryGetProject(razorProjectKey, out var project) &&
-                IsFallbackProject(project))
+            if (IsFallbackProject(razorProjectKey) &&
+                _projectManager.TryGetProject(razorProjectKey, out var project))
             {
                 // If this is a fallback project, then Roslyn may not track documents in the project, so these dynamic file notifications
                 // are the only way to know about files in the project.

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/IFallbackProjectManager.cs

@@ -1,11 +1,11 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT license. See License.txt in the project root for license information.
 
-using Microsoft.CodeAnalysis.Razor.ProjectSystem;
+using Microsoft.AspNetCore.Razor.ProjectSystem;
 
 namespace Microsoft.VisualStudio.Razor.ProjectSystem;
 
 internal interface IFallbackProjectManager
 {
-    bool IsFallbackProject(ProjectSnapshot project);
+    bool IsFallbackProject(ProjectKey projectKey);
 }

src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/DocumentGenerator/BackgroundDocumentGeneratorTest.cs

@@ -34,7 +34,7 @@ public class BackgroundDocumentGeneratorTest(ITestOutputHelper testOutput) : Vis
     private static readonly HostProject s_hostProject2 = TestProjectData.AnotherProject with { Configuration = FallbackRazorConfiguration.MVC_1_0 };
 
     private static IFallbackProjectManager s_fallbackProjectManager = StrictMock.Of<IFallbackProjectManager>(x =>
-        x.IsFallbackProject(It.IsAny<ProjectSnapshot>()) == false);
+        x.IsFallbackProject(It.IsAny<ProjectKey>()) == false);
 
     private readonly TestDynamicFileInfoProvider _dynamicFileInfoProvider = new();
 

src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Documents/EditorDocumentManagerListenerTest.cs

@@ -32,7 +32,7 @@ public class EditorDocumentManagerListenerTest(ITestOutputHelper testOutput) : V
         targetPath: "/path/to/file1.razor");
 
     private static IFallbackProjectManager s_fallbackProjectManager = StrictMock.Of<IFallbackProjectManager>(x =>
-        x.IsFallbackProject(It.IsAny<ProjectSnapshot>()) == false);
+        x.IsFallbackProject(It.IsAny<ProjectKey>()) == false);
 
     [UIFact]
     public async Task ProjectManager_Changed_RemoveDocument_RemovesDocument()

src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/ProjectSystem/FallbackProjectManagerTest.cs

@@ -75,7 +75,7 @@ await _projectManager.UpdateAsync(updater =>
         await WaitForProjectManagerUpdatesAsync();
 
         var project = Assert.Single(_projectManager.GetProjects());
-        Assert.False(_fallbackProjectManger.IsFallbackProject(project));
+        Assert.False(_fallbackProjectManger.IsFallbackProject(project.Key));
     }
 
     [UIFact]
@@ -102,7 +102,7 @@ public async Task DynamicFileAdded_UnknownProject_Adds()
         Assert.Equal("DisplayName", project.DisplayName);
         Assert.Equal("RootNamespace", project.RootNamespace);
 
-        Assert.True(_fallbackProjectManger.IsFallbackProject(project));
+        Assert.True(_fallbackProjectManger.IsFallbackProject(project.Key));
 
         var documentFilePath = Assert.Single(project.DocumentFilePaths);
         Assert.Equal(SomeProjectFile1.FilePath, documentFilePath);
@@ -130,7 +130,7 @@ public async Task DynamicFileAdded_UnknownToKnownProject_NotFallbackHostProject(
         await WaitForProjectManagerUpdatesAsync();
 
         var project = Assert.Single(_projectManager.GetProjects());
-        Assert.True(_fallbackProjectManger.IsFallbackProject(project));
+        Assert.True(_fallbackProjectManger.IsFallbackProject(project.Key));
 
         var hostProject = SomeProject with
         {
@@ -144,7 +144,7 @@ await _projectManager.UpdateAsync(updater =>
         });
 
         project = Assert.Single(_projectManager.GetProjects());
-        Assert.False(_fallbackProjectManger.IsFallbackProject(project));
+        Assert.False(_fallbackProjectManger.IsFallbackProject(project.Key));
     }
 
     [UIFact]