Clean up TypeParameter

- Enable nullability
- Add constructor
- Make properties readonly

Author: DustinCampbell

src/Compiler/Microsoft.AspNetCore.Razor.Language/test/CodeGeneration/DefaultDocumentWriterTest.cs

@@ -176,8 +176,8 @@ public void WriteDocument_WritesClass()
             BaseType = new BaseTypeWithModel("TestBase"),
             Interfaces = [IntermediateToken.CreateCSharpToken("IFoo"), IntermediateToken.CreateCSharpToken("IBar")],
             TypeParameters = [
-                new TypeParameter() { ParameterName = "TKey" },
-                new TypeParameter() { ParameterName = "TValue" }
+                new TypeParameter("TKey"),
+                new TypeParameter("TValue")
             ],
             ClassName = "TestClass",
         });
@@ -219,8 +219,8 @@ public void WriteDocument_WithNullableContext_WritesClass()
             BaseType = new BaseTypeWithModel("TestBase"),
             Interfaces = [IntermediateToken.CreateCSharpToken("IFoo"), IntermediateToken.CreateCSharpToken("IBar")],
             TypeParameters = [
-                new TypeParameter() { ParameterName = "TKey" },
-                new TypeParameter() { ParameterName = "TValue" }
+                new TypeParameter("TKey"),
+                new TypeParameter("TValue")
             ],
             ClassName = "TestClass",
             NullableContext = true,
@@ -265,8 +265,8 @@ public void WriteDocument_WritesClass_ConstrainedGenericTypeParameters()
             BaseType = new BaseTypeWithModel("TestBase"),
             Interfaces = [IntermediateToken.CreateCSharpToken("IFoo"), IntermediateToken.CreateCSharpToken("IBar")],
             TypeParameters = [
-                new TypeParameter() { ParameterName = "TKey", Constraints = "where TKey : class" },
-                new TypeParameter() { ParameterName = "TValue", Constraints = "where TValue : class" }
+                new TypeParameter("TKey", constraints: "where TKey : class"),
+                new TypeParameter("TValue", constraints: "where TValue : class")
             ],
             ClassName = "TestClass",
         });

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs

@@ -130,13 +130,11 @@ protected override void OnDocumentStructureCreated(
                 var typeParameter = typeParamNode.Tokens.First();
                 var constraints = typeParamNode.Tokens.Skip(1).FirstOrDefault();
 
-                typeParameters.Add(new TypeParameter()
-                {
-                    ParameterName = typeParameter.Content,
-                    ParameterNameSource = typeParameter.Source,
-                    Constraints = constraints?.Content,
-                    ConstraintsSource = constraints?.Source,
-                });
+                typeParameters.Add(new TypeParameter(
+                    typeParameter.Content,
+                    typeParameter.Source,
+                    constraints?.Content,
+                    constraints?.Source));
             }
 
             @class.UpdateTypeParameters(typeParameters.ToImmutableAndClear());

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Intermediate/TypeParameter.cs

@@ -1,14 +1,16 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable
-
 namespace Microsoft.AspNetCore.Razor.Language.Intermediate;
 
-public sealed class TypeParameter
+public sealed class TypeParameter(
+    string parameterName,
+    SourceSpan? parameterNameSource = null,
+    string? constraints = null,
+    SourceSpan? constraintsSource = null)
 {
-    public string ParameterName { get; set; }
-    public SourceSpan? ParameterNameSource { get; init; }
-    public string Constraints { get; set; }
-    public SourceSpan? ConstraintsSource { get; init; }
+    public string ParameterName { get; } = parameterName;
+    public SourceSpan? ParameterNameSource { get; } = parameterNameSource;
+    public string? Constraints { get; } = constraints;
+    public SourceSpan? ConstraintsSource { get; } = constraintsSource;
 }