Normalize line endings in on type formatting (#12398)

Fixes #12395
Fixes #10836

This just brings the fix from #10802
to on type formatting. I was surprised it was that easy, but I suspect
the simplification due to only having one formatting engine might have
helped. Extra evidence for this is that all of the other tests we had
that skipped LF endings passed without any effort on my behalf really.

Author: davidwengier

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/SourceTextExtensions.cs

@@ -341,13 +341,12 @@ public static bool HasLFLineEndings(this SourceText text)
 
         foreach (var line in text.Lines)
         {
-            var lineBreakSpan = TextSpan.FromBounds(line.End, line.EndIncludingLineBreak);
-            var lineBreak = line.Text?.ToString(lineBreakSpan) ?? string.Empty;
-            if (lineBreak == "\r\n")
+            var lineBreakLength = line.EndIncludingLineBreak - line.End;
+            if (lineBreakLength == 2)
             {
                 crlfCount++;
             }
-            else if (lineBreak == "\n")
+            else if (lineBreakLength != 0)
             {
                 lfCount++;
             }

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/RazorFormattingService.cs

@@ -300,6 +300,7 @@ private async Task<ImmutableArray<TextChange>> ApplyFormattedChangesAsync(
 
         var result = await formattingPass.ExecuteAsync(context, generatedDocumentChanges, cancellationToken).ConfigureAwait(false);
         var originalText = context.SourceText;
+        result = NormalizeLineEndings(originalText, result);
         var razorChanges = originalText.MinimizeTextChanges(result);
 
         if (validate)

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/CodeDirectiveFormattingTest.cs

@@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer.Formatting;
 public class CodeDirectiveFormattingTest(FormattingTestContext context, HtmlFormattingFixture fixture, ITestOutputHelper testOutput)
     : FormattingTestBase(context, fixture.Service, testOutput), IClassFixture<FormattingTestContext>
 {
-    [FormattingTestFact(SkipFlipLineEnding = true)]
+    [FormattingTestFact]
     [WorkItem("https://github.com/dotnet/razor-tooling/issues/5648")]
     public async Task GenericComponentWithCascadingTypeParameter()
     {
@@ -123,7 +123,7 @@ await RunFormattingTestAsync(
             tagHelpers: GetComponentWithCascadingTypeParameter());
     }
 
-    [FormattingTestFact(SkipFlipLineEnding = true)] // tracked by https://github.com/dotnet/razor/issues/10836
+    [FormattingTestFact]
     [WorkItem("https://github.com/dotnet/razor-tooling/issues/5648")]
     public async Task GenericComponentWithCascadingTypeParameter_MultipleParameters()
     {

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/DocumentFormattingTest.cs

@@ -1872,14 +1872,18 @@ void Method() { }
                     """);
     }
 
-    [FormattingTestFact(SkipFlipLineEnding = true)] // tracked by https://github.com/dotnet/razor/issues/10836
+    [FormattingTestFact]
     public async Task FormatsShortBlock()
     {
         await RunFormattingTestAsync(
             input: """
+                    <div>
+                    </div>
                     @{<p></p>}
                     """,
             expected: """
+                    <div>
+                    </div>
                     @{
                         <p></p>
                     }

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/HtmlFormattingTest.cs

@@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer.Formatting;
 public class HtmlFormattingTest(FormattingTestContext context, HtmlFormattingFixture fixture, ITestOutputHelper testOutput)
     : FormattingTestBase(context, fixture.Service, testOutput), IClassFixture<FormattingTestContext>
 {
-    [FormattingTestFact(SkipFlipLineEnding = true)] // tracked by https://github.com/dotnet/razor/issues/10836
+    [FormattingTestFact]
     public async Task FormatsComponentTags()
     {
         var tagHelpers = GetComponents();
@@ -363,7 +363,7 @@ await RunFormattingTestAsync(
             tagHelpers: GetComponents());
     }
 
-    [FormattingTestFact(SkipFlipLineEnding = true)] // tracked by https://github.com/dotnet/razor/issues/10836
+    [FormattingTestFact]
     [WorkItem("https://github.com/dotnet/razor/issues/6211")]
     public async Task FormatCascadingValueWithCascadingTypeParameter()
     {