Don't replace the slashes in hint names (#12477)

* Don't replace the slashes in hintnames
* Add test
* Normalize line endings + don't allow first char to be a slash

Author: chsienki

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/SourceGenerators/RazorSourceGenerator.Helpers.cs

@@ -21,7 +21,9 @@ internal static string GetIdentifierFromPath(ReadOnlySpan<char> filePath)
             {
                 switch (filePath[i])
                 {
-                    case ':' or '\\' or '/':
+                    case '\\' or '/' when i > 0:
+                        builder.Append('/');
+                        break;
                     case char ch when !char.IsLetterOrDigit(ch):
                         builder.Append('_');
                         break;

src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTests.cs

@@ -238,8 +238,8 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_razor.g.cs"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_razor.g.cs"),
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
         }
 
@@ -456,7 +456,7 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                 e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Pages/Counter.razor"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
         }
 
@@ -843,7 +843,7 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                 e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Pages/Counter.razor"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
         }
 
@@ -1017,7 +1017,7 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
                e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-               e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+               e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
         }
 
@@ -1172,7 +1172,7 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_razor.g.cs")
             );
 
             // Verify caching
@@ -1381,8 +1381,8 @@ internal sealed class Views_Shared__Layout : global::Microsoft.AspNetCore.Mvc.Ra
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.cshtml", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Views/Shared/_Layout.cshtml", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Views/Shared/_Layout.cshtml", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_cshtml.g.cs"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Views_Shared__Layout_cshtml.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_cshtml.g.cs"),
+                e => e.AssertSingleItem("AddSyntaxTrees", "Views/Shared/_Layout_cshtml.g.cs")
             );
         }
 
@@ -1722,7 +1722,7 @@ internal sealed class Views_Shared__Layout : global::Microsoft.AspNetCore.Mvc.Ra
                e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Views/Shared/_Layout.cshtml"),
                e => e.AssertPair("RazorCodeGenerateStart", "Views/Shared/_Layout.cshtml", "Runtime"),
                e => e.AssertPair("RazorCodeGenerateStop", "Views/Shared/_Layout.cshtml", "Runtime"),
-               e => e.AssertSingleItem("AddSyntaxTrees", "Views_Shared__Layout_cshtml.g.cs")
+               e => e.AssertSingleItem("AddSyntaxTrees", "Views/Shared/_Layout_cshtml.g.cs")
             );
         }
 
@@ -2056,7 +2056,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
                 e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Views/Shared/_Layout.cshtml"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Index.cshtml", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.cshtml", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_cshtml.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_cshtml.g.cs")
            );
         }
 
@@ -2723,8 +2723,8 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_razor.g.cs"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_razor.g.cs"),
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
                 );
 
             // flip the suppression state back to off
@@ -2845,8 +2845,8 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
                 e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Pages/Index.razor"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Index.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_razor.g.cs"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_razor.g.cs"),
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
 
             // Flip suppression on, change the compilation, no changes
@@ -2874,8 +2874,8 @@ public class MyViewComponent : Microsoft.AspNetCore.Mvc.ViewComponent{}
                e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Pages/Index.razor"),
                e => e.AssertSingleItem("CheckAndRewriteTagHelpersStart", "Pages/Counter.razor"),
                e => e.AssertSingleItem("CheckAndRewriteTagHelpersStop", "Pages/Counter.razor"),
-               e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_razor.g.cs"),
-               e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+               e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_razor.g.cs"),
+               e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
 
             // Flip suppression on, change the parse options, no changes
@@ -2917,8 +2917,8 @@ public class MyViewComponent : Microsoft.AspNetCore.Mvc.ViewComponent{}
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStart", "Pages/Counter.razor", "Runtime"),
                 e => e.AssertPair("RazorCodeGenerateStop", "Pages/Counter.razor", "Runtime"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Index_razor.g.cs"),
-                e => e.AssertSingleItem("AddSyntaxTrees", "Pages_Counter_razor.g.cs")
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Index_razor.g.cs"),
+                e => e.AssertSingleItem("AddSyntaxTrees", "Pages/Counter_razor.g.cs")
             );
 
             GeneratorDriver SetSuppressionState(bool state)
@@ -3570,7 +3570,7 @@ public async Task IncrementalCompilation_RerunsGenerator_When_AdditionalFileRena
                     e => e.AssertPair("RazorCodeGenerateStop", "Pages/Index.razor", "Runtime"),
                     e => e.AssertPair("RazorCodeGenerateStart", "Pages/NewCounter.razor", "Runtime"),
                     e => e.AssertPair("RazorCodeGenerateStop", "Pages/NewCounter.razor", "Runtime"),
-                    e => e.AssertSingleItem("AddSyntaxTrees", "Pages_NewCounter_razor.g.cs")
+                    e => e.AssertSingleItem("AddSyntaxTrees", "Pages/NewCounter_razor.g.cs")
             );
 
             // Verify the generated source has the correct namespace and class name

src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/TestFiles/RazorSourceGeneratorComponentTests/EmptyRootNamespace/Shared_Component1_razor.g.cs renamed to src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/TestFiles/RazorSourceGeneratorComponentTests/EmptyRootNamespace/Shared/Component1_razor.g.cs

@@ -23,6 +23,7 @@ protected override void BuildRenderTree(global::Microsoft.AspNetCore.Components.
 #nullable restore
 #line (1,39)-(1,50) 24 "Shared/Component1.razor"
 __builder.AddContent(2, RaiseHere()
+
 #line default
 #line hidden
 #nullable disable