Only offer on start tag name, or end tag, and add tests

Author: davidwengier

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/CodeActions/Razor/SimplifyFullyQualifiedComponentCodeActionProvider.cs

@@ -38,15 +38,15 @@ public Task<ImmutableArray<RazorVSInternalCodeAction>> ProvideAsync(RazorCodeAct
             return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
         }
 
-        // Find the start tag at the cursor position - we only want to trigger on the start tag, not content
-        var owner = syntaxRoot.FindInnermostNode(context.StartAbsoluteIndex, includeWhitespace: true)?.FirstAncestorOrSelf<MarkupTagHelperStartTagSyntax>();
-        if (owner is not MarkupTagHelperStartTagSyntax startTag)
+        // Find the tag at the cursor position, if it's on the start tag (name portion) or end tag only.
+        var owner = syntaxRoot.FindInnermostNode(context.StartAbsoluteIndex, includeWhitespace: true) switch
         {
-            return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
-        }
+            MarkupTagHelperStartTagSyntax startTag when startTag.Name.Span.Contains(context.StartAbsoluteIndex) => startTag.Parent,
+            MarkupTagHelperEndTagSyntax endTag => endTag.Parent,
+            _ => null
+        };
 
-        // Get the parent element to access tag helper binding information
-        if (startTag.Parent is not MarkupTagHelperElementSyntax markupElementSyntax)
+        if (owner is not MarkupTagHelperElementSyntax markupElementSyntax)
         {
             return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
         }

src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/SimplifyFullyQualifiedComponentTests.cs

@@ -362,4 +362,39 @@ await VerifyCodeActionAsync(
             expected: null,
             codeActionName: LanguageServerConstants.CodeActions.SimplifyFullyQualifiedComponent);
     }
+
+    [Fact]
+    public async Task DoNotOfferInAttribute()
+    {
+        await VerifyCodeActionAsync(
+            input: """
+                <Microsoft.AspNetCore.Components.Forms.InputText class="bo[||]ld"></Microsoft.AspNetCore.Components.Forms.InputText>
+                """,
+            expected: null,
+            codeActionName: LanguageServerConstants.CodeActions.SimplifyFullyQualifiedComponent);
+    }
+
+    [Fact]
+    public async Task SimplifyFullyQualifiedComponent_EndTag()
+    {
+        // Microsoft.AspNetCore.Components.Forms is automatically in scope, so no using directive should be added
+        await VerifyCodeActionAsync(
+            input: """
+                <div></div>
+
+                <Microsoft.AspNetCore.Components.Forms.InputText>
+                </Microsoft.AspNetCore.Components.Forms.Input[||]Text>
+
+                <div></div>
+                """,
+            expected: """
+                <div></div>
+
+                <InputText>
+                </InputText>
+
+                <div></div>
+                """,
+            codeActionName: LanguageServerConstants.CodeActions.SimplifyFullyQualifiedComponent);
+    }
 }