Remove synchronous ProjectSnapshotManager.Update(...) methods

Author: DustinCampbell

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/IProjectSnapshotManager.cs

@@ -22,11 +22,6 @@ internal interface IProjectSnapshotManager
     bool IsDocumentOpen(string documentFilePath);
     ImmutableArray<string> GetOpenDocuments();
 
-    void Update(Action<ProjectSnapshotManager.Updater> updater);
-    void Update<TState>(Action<ProjectSnapshotManager.Updater, TState> updater, TState state);
-    TResult Update<TResult>(Func<ProjectSnapshotManager.Updater, TResult> updater);
-    TResult Update<TState, TResult>(Func<ProjectSnapshotManager.Updater, TState, TResult> updater, TState state);
-
     Task UpdateAsync(Action<ProjectSnapshotManager.Updater> updater, CancellationToken cancellationToken);
     Task UpdateAsync<TState>(Action<ProjectSnapshotManager.Updater, TState> updater, TState state, CancellationToken cancellationToken);
     Task<TResult> UpdateAsync<TResult>(Func<ProjectSnapshotManager.Updater, TResult> updater, CancellationToken cancellationToken);

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotManager.cs

@@ -569,30 +569,6 @@ private bool TryChangeEntry_UsesLock(
         }
     }
 
-    public void Update(Action<Updater> updater)
-    {
-        _dispatcher.AssertRunningOnDispatcher();
-        updater(new(this));
-    }
-
-    public void Update<TState>(Action<Updater, TState> updater, TState state)
-    {
-        _dispatcher.AssertRunningOnDispatcher();
-        updater(new(this), state);
-    }
-
-    public TResult Update<TResult>(Func<Updater, TResult> updater)
-    {
-        _dispatcher.AssertRunningOnDispatcher();
-        return updater(new(this));
-    }
-
-    public TResult Update<TState, TResult>(Func<Updater, TState, TResult> updater, TState state)
-    {
-        _dispatcher.AssertRunningOnDispatcher();
-        return updater(new(this), state);
-    }
-
     public Task UpdateAsync(Action<Updater> updater, CancellationToken cancellationToken)
     {
         return _dispatcher.RunAsync(

src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/ProjectSystem/DefaultProjectSnapshotManagerTest.cs

@@ -15,6 +15,7 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Razor.ProjectSystem;
 using Microsoft.CodeAnalysis.Text;
+using Microsoft.VisualStudio.Threading;
 using Moq;
 using Xunit;
 using Xunit.Abstractions;
@@ -812,13 +813,13 @@ await _projectManager.UpdateAsync(updater =>
 
             if (args.Kind == ProjectChangeKind.DocumentAdded)
             {
-                _projectManager.Update(updater =>
-                    updater.DocumentOpened(s_hostProject.Key, s_documents[0].FilePath, _sourceText));
+                _projectManager.UpdateAsync(updater =>
+                    updater.DocumentOpened(s_hostProject.Key, s_documents[0].FilePath, _sourceText)).Forget();
             }
             else if (args.Kind == ProjectChangeKind.DocumentChanged)
             {
-                _projectManager.Update(updater =>
-                    updater.DocumentRemoved(s_hostProject.Key, s_documents[0]));
+                _projectManager.UpdateAsync(updater =>
+                    updater.DocumentRemoved(s_hostProject.Key, s_documents[0])).Forget();
             }
         };