Prefer AssumeNotNull over the null forgiveness operator

DustinCampbell · DustinCampbell · commit af45a1743513 · 2023-11-27T10:18:50.000-08:00
diff --git a/src/Compiler/Microsoft.AspNetCore.Razor.Language/src/Syntax/SyntaxListOfT.cs b/src/Compiler/Microsoft.AspNetCore.Razor.Language/src/Syntax/SyntaxListOfT.cs
@@ -82,7 +82,7 @@ public TNode this[int index]
                 {
                     if (unchecked((uint)index < (uint)Node.SlotCount))
                     {
-                        return (TNode)Node.GetNodeSlot(index)!;
+                        return (TNode)Node.GetNodeSlot(index).AssumeNotNull();
                     }
                 }
                 else if (index == 0)

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public TNode this[int index]`
`82`	`82`	`{`
`83`	`83`	`if (unchecked((uint)index < (uint)Node.SlotCount))`
`84`	`84`	`{`
`85`		`- return (TNode)Node.GetNodeSlot(index)!;`
	`85`	`+ return (TNode)Node.GetNodeSlot(index).AssumeNotNull();`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`	`else if (index == 0)`