Cherrypick "Fix issue with Checksum and long strings" to 17.9 (#9591)

Cherrypick "Fix issue with Checksum and long strings" to 17.9

* Fix issue with Checksum and long strings

There is a logic error in Checksum.Builder that causes an
ArgumentOutOfRangeException to be thrown on .NET Framework when a
string larger than 4KB is appened.

* Use WorkItem attribute

---------

Co-authored-by: Dustin Campbell <[email protected]>

Author: phil-allen-msft

src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/ChecksumTests.cs

@@ -143,4 +143,17 @@ public void TestTagHelperEquality()
             }
         }
     }
+
+    [Fact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1909377")]
+    public void TestLargeString()
+    {
+        object? largeString = RazorTestResources.GetResourceText("FormattingTest.razor");
+
+        var builder = new Checksum.Builder();
+        builder.AppendData(largeString);
+
+        var result = builder.FreeAndGetChecksum();
+
+        Assert.NotNull(result);
+    }
 }

src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Utilities/Checksum.Builder.cs

@@ -148,7 +148,7 @@ static void AppendData(HashingType hash, byte[] buffer, string value)
                 var index = 0;
                 while (index < stringBytes.Length)
                 {
-                    var remaining = stringBytes.Length;
+                    var remaining = stringBytes.Length - index;
                     var toCopy = Math.Min(remaining, buffer.Length);
 
                     stringBytes.Slice(index, toCopy).CopyTo(buffer);