Remove IErrorReporter from VisualStudioRazorParser

Author: DustinCampbell

src/Razor/src/Microsoft.VisualStudio.LegacyEditor.Razor/Parsing/VisualStudioRazorParser.cs

@@ -13,6 +13,7 @@
 using Microsoft.AspNetCore.Razor.Language.Legacy;
 using Microsoft.AspNetCore.Razor.ProjectEngineHost;
 using Microsoft.CodeAnalysis.Razor;
+using Microsoft.CodeAnalysis.Razor.Logging;
 using Microsoft.CodeAnalysis.Razor.Settings;
 using Microsoft.Extensions.Internal;
 using Microsoft.VisualStudio.Language.Intellisense;
@@ -40,7 +41,7 @@ internal class VisualStudioRazorParser : IVisualStudioRazorParser, IDisposable
     private readonly IVisualStudioDocumentTracker _documentTracker;
     private readonly JoinableTaskContext _joinableTaskContext;
     private readonly IProjectEngineFactoryProvider _projectEngineFactoryProvider;
-    private readonly IErrorReporter _errorReporter;
+    private readonly ILogger _logger;
     private readonly List<CodeDocumentRequest> _codeDocumentRequests;
     private readonly TaskScheduler _uiThreadScheduler;
     private RazorProjectEngine? _projectEngine;
@@ -55,12 +56,12 @@ public VisualStudioRazorParser(
         IVisualStudioDocumentTracker documentTracker,
         IProjectEngineFactoryProvider projectEngineFactoryProvider,
         ICompletionBroker completionBroker,
-        IErrorReporter errorReporter,
+        ILoggerFactory loggerFactory,
         JoinableTaskContext joinableTaskContext)
     {
         _joinableTaskContext = joinableTaskContext;
         _projectEngineFactoryProvider = projectEngineFactoryProvider;
-        _errorReporter = errorReporter;
+        _logger = loggerFactory.GetOrCreateLogger<VisualStudioRazorParser>();
         _completionBroker = completionBroker;
         _documentTracker = documentTracker;
         _codeDocumentRequests = new List<CodeDocumentRequest>();
@@ -413,7 +414,7 @@ private void Timer_Tick()
         catch (Exception ex)
         {
             // This is something totally unexpected, let's just send it over to the workspace.
-            _errorReporter.ReportError(ex);
+            _logger.LogError(ex);
         }
 
         async Task OnIdle_QueueOnUIThreadAsync()

src/Razor/src/Microsoft.VisualStudio.LegacyEditor.Razor/Parsing/VisualStudioRazorParserFactory.cs

@@ -3,7 +3,7 @@
 
 using System.ComponentModel.Composition;
 using Microsoft.AspNetCore.Razor.ProjectEngineHost;
-using Microsoft.CodeAnalysis.Razor;
+using Microsoft.CodeAnalysis.Razor.Logging;
 using Microsoft.VisualStudio.Language.Intellisense;
 using Microsoft.VisualStudio.Razor.Extensions;
 using Microsoft.VisualStudio.Threading;
@@ -15,12 +15,12 @@ namespace Microsoft.VisualStudio.LegacyEditor.Razor.Parsing;
 internal sealed class VisualStudioRazorParserFactory(
     IProjectEngineFactoryProvider projectEngineFactoryProvider,
     ICompletionBroker completionBroker,
-    IErrorReporter errorReporter,
+    ILoggerFactory loggerFactory,
     JoinableTaskContext joinableTaskContext) : IVisualStudioRazorParserFactory
 {
     private readonly IProjectEngineFactoryProvider _projectEngineFactoryProvider = projectEngineFactoryProvider;
     private readonly ICompletionBroker _completionBroker = completionBroker;
-    private readonly IErrorReporter _errorReporter = errorReporter;
+    private readonly ILoggerFactory _loggerFactory = loggerFactory;
     private readonly JoinableTaskContext _joinableTaskContext = joinableTaskContext;
 
     public IVisualStudioRazorParser Create(IVisualStudioDocumentTracker documentTracker)
@@ -31,7 +31,7 @@ public IVisualStudioRazorParser Create(IVisualStudioDocumentTracker documentTrac
             documentTracker,
             _projectEngineFactoryProvider,
             _completionBroker,
-            _errorReporter,
+            _loggerFactory,
             _joinableTaskContext);
     }
 }

src/Razor/test/Microsoft.VisualStudio.LegacyEditor.Razor.Test/Parsing/VisualStudioRazorParserIntegrationTest.cs

@@ -566,7 +566,7 @@ private TestParserManager CreateParserManager(IVisualStudioDocumentTracker docum
             documentTracker,
             _projectEngineFactoryProvider,
             new TestCompletionBroker(),
-            ErrorReporter,
+            LoggerFactory,
             JoinableTaskFactory.Context)
         {
             // We block idle work with the below reset events. Therefore, make tests fast and have the idle timer fire as soon as possible.

src/Razor/test/Microsoft.VisualStudio.LegacyEditor.Razor.Test/Parsing/VisualStudioRazorParserTest.cs

@@ -60,7 +60,7 @@ private VisualStudioRazorParser CreateParser(IVisualStudioDocumentTracker docume
             documentTracker,
             _projectEngineFactoryProvider,
             StrictMock.Of<ICompletionBroker>(),
-            ErrorReporter,
+            LoggerFactory,
             JoinableTaskContext);
 
     [UIFact]