Skip to content

Commit c2b14bd

Browse files
committed
Remove ability to skip LF endings in tests
1 parent 945348b commit c2b14bd

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingTestCase.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,6 @@ protected override string GetDisplayName(IAttributeInfo factAttribute, string di
3131
(_shouldFlipLineEndings ? " (LF)" : " (CRLF)");
3232
}
3333

34-
protected override string GetSkipReason(IAttributeInfo factAttribute)
35-
{
36-
if (_shouldFlipLineEndings && factAttribute.GetNamedArgument<bool>(nameof(FormattingTestFactAttribute.SkipFlipLineEnding)))
37-
{
38-
return "Some tests fail with LF line endings";
39-
}
40-
41-
return base.GetSkipReason(factAttribute);
42-
}
43-
4434
public override Task<RunSummary> RunAsync(IMessageSink diagnosticMessageSink, IMessageBus messageBus, object[] constructorArguments, ExceptionAggregator aggregator, CancellationTokenSource cancellationTokenSource)
4535
{
4636
Debug.Assert(constructorArguments.Length >= 1 && constructorArguments[0] is FormattingTestContext, $"{TestMethod.TestClass.Class.Name}.{TestMethod.Method.Name} uses a formatting test attribute in a class without a FormattingTestContext parameter?");

src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingTestFactAttribute.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@ namespace Microsoft.AspNetCore.Razor.Test.Common;
1111
[XunitTestCaseDiscoverer($"Microsoft.AspNetCore.Razor.Test.Common.{nameof(FormattingFactDiscoverer)}", "Microsoft.AspNetCore.Razor.Test.Common")]
1212
internal sealed class FormattingTestFactAttribute : FactAttribute
1313
{
14-
public bool SkipFlipLineEnding { get; set; }
1514
}

src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingTestTheoryAttribute.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@ namespace Microsoft.AspNetCore.Razor.Test.Common;
1212
internal sealed class FormattingTestTheoryAttribute : TheoryAttribute
1313
{
1414
// NOTE: Property names need to match FormattingTestFactAttribute
15-
public bool SkipFlipLineEnding { get; set; }
1615
}

0 commit comments

Comments
 (0)