Skip to content

Commit caa579d

Browse files
authored
Get integration tests running again (#10285)
Restores the reference to `xunit.runners.visualstudio` that was inadvertently lost when moving to CPM. Run is happening now, but signs are positive: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9450237
2 parents e95df60 + c67cb6d commit caa579d

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/Microsoft.VisualStudio.Razor.IntegrationTests.csproj

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,17 @@
3636
<PackageReference Include="Microsoft.Internal.VisualStudio.Shell.Framework" />
3737
<PackageReference Include="xunit" />
3838
<PackageReference Include="xunit.runner.utility" />
39+
40+
<!--
41+
We need to reference XUnit, but Arcade won't import it because the test runner above is MSTest,
42+
and we can't just reference the package we need because they are implicit references in Arcade
43+
for other projects, and CPM doesn't play nicely with those. We could try to manually import
44+
the Arcade XUnit.targets file, but finding that file is a pain, so instead we can just manually
45+
import the package ourselves, but as an implicit definition to stop Nuget complaining.
46+
TL;DR: MSBuild was designed to cause pain.
47+
-->
48+
<PackageReference Include="xunit.runner.console" Version="$(XUnitRunnerConsoleVersion)" IsImplicitlyDefined="true" PrivateAssets="all" Publish="true"/>
49+
<PackageReference Include="xunit.runner.visualstudio" Version="$(XUnitRunnerVisualStudioVersion)" IsImplicitlyDefined="true" PrivateAssets="all" Publish="true"/>
3950
</ItemGroup>
4051

4152
<ItemGroup>

0 commit comments

Comments
 (0)