Additional feedback for "allowing Razor completion items on deletion" PR (#11996)

Author: alexgav

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Completion/RazorCompletionListProvider.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
-using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Microsoft.AspNetCore.Razor;
@@ -38,11 +37,6 @@ internal class RazorCompletionListProvider(
         HashSet<string>? existingCompletions,
         RazorCompletionOptions completionOptions)
     {
-        if (!IsApplicableTriggerContext(completionContext))
-        {
-            return null;
-        }
-
         var reason = completionContext.TriggerKind switch
         {
             CompletionTriggerKind.TriggerForIncompleteCompletions => CompletionReason.Invoked,
@@ -262,24 +256,4 @@ internal static bool TryConvert(
         completionItem = null;
         return false;
     }
-
-    // Internal for testing
-    internal static bool IsApplicableTriggerContext(CompletionContext context)
-    {
-        if (context is not VSInternalCompletionContext vsCompletionContext)
-        {
-            Debug.Fail("Completion context should always be converted into a VSCompletionContext (even in VSCode).");
-
-            // We do not support providing completions on delete.
-            return false;
-        }
-
-        if (vsCompletionContext.TriggerKind == CompletionTriggerKind.TriggerForIncompleteCompletions)
-        {
-            // For incomplete completions we want to re-provide information if we would have originally.
-            return true;
-        }
-
-        return true;
-    }
 }

src/Razor/test/Microsoft.CodeAnalysis.Razor.Workspaces.Test/Completion/RazorCompletionListProviderTest.cs

@@ -61,54 +61,6 @@ private static IRazorCompletionItemProvider[] GetCompletionProviders()
             new TagHelperCompletionProvider(new TagHelperCompletionService())
         ];
 
-    [Fact]
-    public void IsApplicableTriggerContext_Deletion_ReturnsTrue()
-    {
-        // Arrange
-        var completionContext = new VSInternalCompletionContext()
-        {
-            InvokeKind = VSInternalCompletionInvokeKind.Deletion
-        };
-
-        // Act
-        var result = RazorCompletionListProvider.IsApplicableTriggerContext(completionContext);
-
-        // Assert
-        Assert.True(result);
-    }
-
-    [Fact]
-    public void IsApplicableTriggerContext_Explicit_ReturnsTrue()
-    {
-        // Arrange
-        var completionContext = new VSInternalCompletionContext()
-        {
-            InvokeKind = VSInternalCompletionInvokeKind.Explicit
-        };
-
-        // Act
-        var result = RazorCompletionListProvider.IsApplicableTriggerContext(completionContext);
-
-        // Assert
-        Assert.True(result);
-    }
-
-    [Fact]
-    public void IsApplicableTriggerContext_Typing_ReturnsTrue()
-    {
-        // Arrange
-        var completionContext = new VSInternalCompletionContext()
-        {
-            InvokeKind = VSInternalCompletionInvokeKind.Typing
-        };
-
-        // Act
-        var result = RazorCompletionListProvider.IsApplicableTriggerContext(completionContext);
-
-        // Assert
-        Assert.True(result);
-    }
-
     [Fact]
     public void TryConvert_Directive_ReturnsTrue()
     {