Make enums byte-sized

Author: DustinCampbell

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/RequiredAttributeDescriptorFlags.cs

@@ -6,7 +6,7 @@
 namespace Microsoft.AspNetCore.Razor.Language;
 
 [Flags]
-internal enum RequiredAttributeDescriptorFlags
+internal enum RequiredAttributeDescriptorFlags : byte
 {
     None = 0,
     CaseSensitive = 1 << 0,

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/RequiredAttributeNameComparison.cs

@@ -6,7 +6,7 @@ namespace Microsoft.AspNetCore.Razor.Language;
 /// <summary>
 /// Acceptable <see cref="RequiredAttributeDescriptor.NameComparison"/> comparison values.
 /// </summary>
-public enum RequiredAttributeNameComparison
+public enum RequiredAttributeNameComparison : byte
 {
     /// <summary>
     /// HTML attribute name case insensitively matches <see cref="RequiredAttributeDescriptor.Name"/>.

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/RequiredAttributeValueComparison.cs

@@ -6,7 +6,7 @@ namespace Microsoft.AspNetCore.Razor.Language;
 /// <summary>
 /// Acceptable <see cref="RequiredAttributeDescriptor.ValueComparison"/> values.
 /// </summary>
-public enum RequiredAttributeValueComparison
+public enum RequiredAttributeValueComparison : byte
 {
     /// <summary>
     /// HTML attribute value always matches <see cref="RequiredAttributeDescriptor.Value"/>.

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Serialization/MessagePack/Formatters/TagHelpers/RequiredAttributeFormatter.cs

@@ -21,11 +21,11 @@ public override RequiredAttributeDescriptor Deserialize(ref MessagePackReader re
     {
         reader.ReadArrayHeaderAndVerify(PropertyCount);
 
-        var flags = (RequiredAttributeDescriptorFlags)reader.ReadInt32();
+        var flags = (RequiredAttributeDescriptorFlags)reader.ReadByte();
         var name = CachedStringFormatter.Instance.Deserialize(ref reader, options);
-        var nameComparison = (RequiredAttributeNameComparison)reader.ReadInt32();
+        var nameComparison = (RequiredAttributeNameComparison)reader.ReadByte();
         var value = CachedStringFormatter.Instance.Deserialize(ref reader, options);
-        var valueComparison = (RequiredAttributeValueComparison)reader.ReadInt32();
+        var valueComparison = (RequiredAttributeValueComparison)reader.ReadByte();
 
         var diagnostics = reader.Deserialize<ImmutableArray<RazorDiagnostic>>(options);
 
@@ -37,11 +37,11 @@ public override void Serialize(ref MessagePackWriter writer, RequiredAttributeDe
     {
         writer.WriteArrayHeader(PropertyCount);
 
-        writer.Write((int)value.Flags);
+        writer.Write((byte)value.Flags);
         CachedStringFormatter.Instance.Serialize(ref writer, value.Name, options);
-        writer.Write((int)value.NameComparison);
+        writer.Write((byte)value.NameComparison);
         CachedStringFormatter.Instance.Serialize(ref writer, value.Value, options);
-        writer.Write((int)value.ValueComparison);
+        writer.Write((byte)value.ValueComparison);
 
         writer.Serialize(value.Diagnostics, options);
     }

src/Shared/Microsoft.AspNetCore.Razor.Serialization.Json/ObjectReaders_TagHelpers.cs

@@ -129,11 +129,11 @@ static RequiredAttributeDescriptor ReadRequiredAttribute(JsonDataReader reader)
 
             static RequiredAttributeDescriptor ReadFromProperties(JsonDataReader reader)
             {
-                var flags = (RequiredAttributeDescriptorFlags)reader.ReadInt32(nameof(RequiredAttributeDescriptor.Flags));
+                var flags = (RequiredAttributeDescriptorFlags)reader.ReadByte(nameof(RequiredAttributeDescriptor.Flags));
                 var name = reader.ReadString(nameof(RequiredAttributeDescriptor.Name));
-                var nameComparison = (RequiredAttributeNameComparison)reader.ReadInt32OrZero(nameof(RequiredAttributeDescriptor.NameComparison));
+                var nameComparison = (RequiredAttributeNameComparison)reader.ReadByteOrZero(nameof(RequiredAttributeDescriptor.NameComparison));
                 var value = reader.ReadStringOrNull(nameof(RequiredAttributeDescriptor.Value));
-                var valueComparison = (RequiredAttributeValueComparison)reader.ReadInt32OrZero(nameof(RequiredAttributeDescriptor.ValueComparison));
+                var valueComparison = (RequiredAttributeValueComparison)reader.ReadByteOrZero(nameof(RequiredAttributeDescriptor.ValueComparison));
 
                 var diagnostics = reader.ReadImmutableArrayOrEmpty(nameof(RequiredAttributeDescriptor.Diagnostics), ReadDiagnostic);
 

src/Shared/Microsoft.AspNetCore.Razor.Serialization.Json/ObjectWriters_TagHelpers.cs

@@ -89,11 +89,11 @@ static void WriteRequiredAttribute(JsonDataWriter writer, RequiredAttributeDescr
         {
             writer.WriteObject(value, static (writer, value) =>
             {
-                writer.Write(nameof(value.Flags), (int)value.Flags);
+                writer.Write(nameof(value.Flags), (byte)value.Flags);
                 writer.Write(nameof(value.Name), value.Name);
-                writer.WriteIfNotZero(nameof(value.NameComparison), (int)value.NameComparison);
+                writer.WriteIfNotZero(nameof(value.NameComparison), (byte)value.NameComparison);
                 writer.WriteIfNotNull(nameof(value.Value), value.Value);
-                writer.WriteIfNotZero(nameof(value.ValueComparison), (int)value.ValueComparison);
+                writer.WriteIfNotZero(nameof(value.ValueComparison), (byte)value.ValueComparison);
                 writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
             });
         }