Skip to content

Commit f195130

Browse files
committed
Convert static helper into a extension method
1 parent 5fe03dc commit f195130

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DirectoryHelper.cs renamed to src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/IFileSystemExtensions.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
namespace Microsoft.AspNetCore.Razor.LanguageServer;
1313

14-
internal static class DirectoryHelper
14+
internal static class IFileSystemExtensions
1515
{
1616
/// <summary>
1717
/// Finds all the files in a directory which meet the given criteria.
@@ -24,10 +24,10 @@ internal static class DirectoryHelper
2424
/// <returns>A list of files within the given directory that meet the search criteria.</returns>
2525
/// <remarks>This method is needed to avoid problematic folders such as "node_modules" which are known not to yield the desired results or may cause performance issues.</remarks>
2626
internal static IEnumerable<string> GetFilteredFiles(
27+
this IFileSystem fileSystem,
2728
string workspaceDirectory,
2829
string searchPattern,
2930
IReadOnlyCollection<string> ignoredDirectories,
30-
IFileSystem fileSystem,
3131
ILogger logger)
3232
{
3333
IEnumerable<string> files;
@@ -94,7 +94,7 @@ internal static IEnumerable<string> GetFilteredFiles(
9494
var directory = Path.GetFileName(path);
9595
if (!ignoredDirectories.Contains(directory, FilePathComparer.Instance))
9696
{
97-
foreach (var result in GetFilteredFiles(path, searchPattern, ignoredDirectories, fileSystem, logger))
97+
foreach (var result in GetFilteredFiles(fileSystem, path, searchPattern, ignoredDirectories, logger))
9898
{
9999
yield return result;
100100
}

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorFileChangeDetector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ protected virtual ImmutableArray<string> GetExistingRazorFiles(string workspaceD
224224

225225
foreach (var extension in s_razorFileExtensions)
226226
{
227-
var existingFiles = DirectoryHelper.GetFilteredFiles(workspaceDirectory, "*" + extension, s_ignoredDirectories, _fileSystem, _logger);
227+
var existingFiles = _fileSystem.GetFilteredFiles(workspaceDirectory, "*" + extension, s_ignoredDirectories, _logger);
228228
result.AddRange(existingFiles);
229229
}
230230

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/DirectoryHelperTest.cs renamed to src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/IFileSystemExtensionsTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
namespace Microsoft.AspNetCore.Razor.LanguageServer.Test;
1313

14-
public class DirectoryHelperTest(ITestOutputHelper testOutput) : TagHelperServiceTestBase(testOutput)
14+
public class IFileSystemExtensionsTest(ITestOutputHelper testOutput) : TagHelperServiceTestBase(testOutput)
1515
{
1616
[Fact]
1717
public void GetFilteredFiles_FindsFiles()
@@ -38,7 +38,7 @@ public void GetFilteredFiles_FindsFiles()
3838
var fileSystem = new TestFileSystem(fileResults, directoryResults);
3939

4040
// Act
41-
var files = DirectoryHelper.GetFilteredFiles(workspaceDirectory, searchPattern, ignoredDirectories, fileSystem, Logger);
41+
var files = fileSystem.GetFilteredFiles(workspaceDirectory, searchPattern, ignoredDirectories, Logger);
4242

4343
// Assert
4444
Assert.Collection(files,

0 commit comments

Comments
 (0)