Remove PooledArrayBuilder<T>.SetCapacityIfLarger method

This method is a bit tricky because it can cause a pooled `ImmutableArray<T>.Builder` to grow with a capacity that isn't a power of two. However, none of the callers of this method really need to use it. So, we can just remove it.

Author: DustinCampbell

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentEventHandlerLoweringPass.cs

@@ -172,8 +172,7 @@ private static IntermediateNode RewriteUsage(IntermediateNode parent, TagHelperD
         // correct context for intellisense when typing in the attribute.
         var eventArgsType = node.TagHelper.GetEventArgsType();
 
-        using var tokens = new PooledArrayBuilder<IntermediateToken>(original.Length + 2);
-        tokens.SetCapacityIfLarger(original.Length + 2);
+        using var tokens = new PooledArrayBuilder<IntermediateToken>(capacity: original.Length + 2);
 
         tokens.Add(
             new IntermediateToken()

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Syntax/SyntaxRewriter.cs

@@ -47,7 +47,7 @@ public virtual SyntaxList<TNode> VisitList<TNode>(SyntaxList<TNode> list)
             return list;
         }
 
-        using PooledArrayBuilder<TNode> builder = [];
+        using var builder = new PooledArrayBuilder<TNode>(capacity: count);
 
         var isUpdating = false;
 
@@ -61,8 +61,6 @@ public virtual SyntaxList<TNode> VisitList<TNode>(SyntaxList<TNode> list)
             {
                 // The list is being updated, so we need to initialize the builder
                 // add the items we've seen so far.
-                builder.SetCapacityIfLarger(count);
-
                 builder.AddRange(list, startIndex: 0, count: i);
 
                 isUpdating = true;
@@ -93,7 +91,7 @@ public virtual SyntaxTokenList VisitList(SyntaxTokenList list)
             return list;
         }
 
-        using PooledArrayBuilder<SyntaxToken> builder = [];
+        using var builder =  new PooledArrayBuilder<SyntaxToken>(count);
 
         var isUpdating = false;
 
@@ -107,8 +105,6 @@ public virtual SyntaxTokenList VisitList(SyntaxTokenList list)
             {
                 // The list is being updated, so we need to initialize the builder
                 // add the items we've seen so far.
-                builder.SetCapacityIfLarger(count);
-
                 builder.AddRange(list, startIndex: 0, count: i);
 
                 isUpdating = true;

src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/PooledObjects/PooledArrayBuilder`1.cs

@@ -8,7 +8,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using Microsoft.AspNetCore.Razor;
 using Microsoft.AspNetCore.Razor.Utilities;
 using Microsoft.Extensions.ObjectPool;
 
@@ -251,27 +250,6 @@ public readonly int Count
     public readonly int Capacity
         => _builder?.Capacity ?? _capacity ?? InlineCapacity;
 
-    public void SetCapacityIfLarger(int value)
-    {
-        if (value > Capacity)
-        {
-            // For pooled arrays, we prefer exponential growth minimize the number of times
-            // the internal array has to be resized.
-            var newCapacity = Math.Max(value, Capacity * 2);
-
-            if (TryGetBuilder(out var builder))
-            {
-                Debug.Assert(newCapacity > builder.Capacity);
-                builder.Capacity = newCapacity;
-            }
-            else
-            {
-                Debug.Assert(newCapacity > (_capacity ?? InlineCapacity));
-                _capacity = newCapacity;
-            }
-        }
-    }
-
     public void Add(T item)
         => Insert(Count, item);
 
@@ -1600,7 +1578,11 @@ private void MoveInlineItemsToBuilder()
 
         if (_capacity is int capacity)
         {
-            builder.SetCapacityIfLarger(capacity);
+            builder.Capacity = capacity;
+        }
+        else if (builder.Capacity < InlineCapacity)
+        {
+            builder.Capacity = InlineCapacity;
         }
 
         _builder = builder;