Nits

Author: marcarro

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Razor/ExtractToNewComponentCodeActionProvider.cs

@@ -51,9 +51,8 @@ public Task<ImmutableArray<RazorVSInternalCodeAction>> ProvideAsync(RazorCodeAct
             return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
         }
 
-        var (startElementNode, endElementNode) = GetStartAndEndElements(context, syntaxTree, _logger);
-
         // Make sure the selection starts on an element tag
+        var (startElementNode, endElementNode) = GetStartAndEndElements(context, syntaxTree, _logger);
         if (startElementNode is null)
         {
             return SpecializedTasks.EmptyImmutableArray<RazorVSInternalCodeAction>();
@@ -71,7 +70,7 @@ public Task<ImmutableArray<RazorVSInternalCodeAction>> ProvideAsync(RazorCodeAct
         AddComponentDependenciesInRange(dependencyScanRoot,
                                         actionParams.ExtractStart,
                                         actionParams.ExtractEnd,
-                                        ref actionParams);
+                                        actionParams);
 
         if (IsMultiPointSelection(context.Request.Range))
         {
@@ -288,7 +287,7 @@ private static (SyntaxNode? Start, SyntaxNode? End) FindContainingSiblingPair(Sy
         return null;
     }
 
-    private static void AddComponentDependenciesInRange(SyntaxNode root, int extractStart, int extractEnd, ref ExtractToNewComponentCodeActionParams actionParams)
+    private static void AddComponentDependenciesInRange(SyntaxNode root, int extractStart, int extractEnd, ExtractToNewComponentCodeActionParams actionParams)
     {
         var components = new HashSet<string>();
         var extractSpan = new TextSpan(extractStart, extractEnd - extractStart);
@@ -300,7 +299,7 @@ private static void AddComponentDependenciesInRange(SyntaxNode root, int extract
                 var tagHelperInfo = GetTagHelperInfo(node);
                 if (tagHelperInfo != null)
                 {
-                    AddDependenciesFromTagHelperInfo(tagHelperInfo, components, ref actionParams);
+                    AddDependenciesFromTagHelperInfo(tagHelperInfo, components, actionParams);
                 }
             }
         }
@@ -322,7 +321,7 @@ private static bool IsMarkupTagHelperElement(SyntaxNode node, TextSpan extractSp
         return null;
     }
 
-    private static void AddDependenciesFromTagHelperInfo(TagHelperInfo tagHelperInfo, HashSet<string> components, ref ExtractToNewComponentCodeActionParams actionParams)
+    private static void AddDependenciesFromTagHelperInfo(TagHelperInfo tagHelperInfo, HashSet<string> components, ExtractToNewComponentCodeActionParams actionParams)
     {
         foreach (var descriptor in tagHelperInfo.BindingResult.Descriptors)
         {

src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/CodeActions/Razor/ExtractToNewComponentCodeActionProviderTest.cs

@@ -232,7 +232,7 @@ public async Task Handle_InProperMarkup_ReturnsEmpty()
         // Arrange
         var documentPath = "c:/Test.razor";
         var contents = """
-            page "/"
+            @page "/"
             
             <PageTitle>Home</PageTitle>
             
@@ -289,7 +289,7 @@ private static RazorCodeActionContext CreateRazorCodeActionContext(VSCodeActionP
         codeDocument.SetFileKind(FileKinds.Component);
         codeDocument.SetCodeGenerationOptions(RazorCodeGenerationOptions.Create(o =>
         {
-            o.RootNamespace = "ExtractToCodeBehindTest";
+            o.RootNamespace = "ExtractToNewComponentTest";
         }));
         codeDocument.SetSyntaxTree(syntaxTree);
 
@@ -304,6 +304,34 @@ private static RazorCodeActionContext CreateRazorCodeActionContext(VSCodeActionP
         return context;
     }
 
+    //private static IDocumentSnapshot CreateSupplementaryRazorFile(string filePath, string text, bool supportsFileCreation = true)
+    //    => CreateSupplementaryRazorFile(filePath, text, relativePath: filePath, supportsFileCreation: supportsFileCreation);
+
+    //private static IDocumentSnapshot CreateSupplementaryRazorFile(string filePath, string text, string? relativePath, bool supportsFileCreation = true)
+    //{
+    //    var sourceDocument = RazorSourceDocument.Create(text, RazorSourceDocumentProperties.Create(filePath, relativePath));
+    //    var options = RazorParserOptions.Create(o =>
+    //    {
+    //        o.Directives.Add(ComponentCodeDirective.Directive);
+    //        o.Directives.Add(FunctionsDirective.Directive);
+    //    });
+    //    var syntaxTree = RazorSyntaxTree.Parse(sourceDocument, options);
+
+    //    var codeDocument = TestRazorCodeDocument.Create(sourceDocument, imports: default);
+    //    codeDocument.SetFileKind(FileKinds.Component);
+    //    codeDocument.SetCodeGenerationOptions(RazorCodeGenerationOptions.Create(o =>
+    //    {
+    //        o.RootNamespace = "ExtractToNewComponentTest";
+    //    }));
+    //    codeDocument.SetSyntaxTree(syntaxTree);
+
+    //    var documentSnapshot = Mock.Of<IDocumentSnapshot>(document =>
+    //        document.GetGeneratedOutputAsync() == Task.FromResult(codeDocument) &&
+    //        document.GetTextAsync() == Task.FromResult(codeDocument.GetSourceText()), MockBehavior.Strict);
+
+    //    return documentSnapshot;
+    //}
+
     private static void AddMultiPointSelectionToContext(ref RazorCodeActionContext context, TextSpan selectionSpan)
     {
         var sourceText = context.CodeDocument.GetSourceText();