Switch to collection expressions (#76653)

Author: CyrusNajmabadi

src/Analyzers/CSharp/Analyzers/ConvertNamespace/ConvertToBlockScopedNamespaceDiagnosticAnalyzer.cs

@@ -59,7 +59,7 @@ private void AnalyzeNamespace(SyntaxNodeAnalysisContext context)
             diagnosticLocation,
             option.Notification,
             context.Options,
-            ImmutableArray.Create(declaration.GetLocation()),
+            [declaration.GetLocation()],
             ImmutableDictionary<string, string?>.Empty);
     }
 }

src/Analyzers/CSharp/Analyzers/ConvertNamespace/ConvertToFileScopedNamespaceDiagnosticAnalyzer.cs

@@ -62,7 +62,7 @@ private void AnalyzeNamespace(SyntaxNodeAnalysisContext context)
             diagnosticLocation,
             option.Notification,
             context.Options,
-            ImmutableArray.Create(declaration.GetLocation()),
+            [declaration.GetLocation()],
             ImmutableDictionary<string, string?>.Empty);
     }
 }

src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertToTopLevelStatementsDiagnosticAnalyzer.cs

@@ -78,7 +78,7 @@ private void ProcessCompilationUnit(SyntaxNodeAnalysisContext context)
                             methodDeclaration, isHidden: option.Notification.Severity.WithDefaultSeverity(DiagnosticSeverity.Hidden) == ReportDiagnostic.Hidden),
                         option.Notification,
                         context.Options,
-                        ImmutableArray.Create(methodDeclaration.GetLocation()),
+                        [methodDeclaration.GetLocation()],
                         ImmutableDictionary<string, string?>.Empty));
                 }
 

src/Analyzers/CSharp/Analyzers/MakeLocalFunctionStatic/MakeLocalFunctionStaticDiagnosticAnalyzer.cs

@@ -55,7 +55,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                 localFunction.Identifier.GetLocation(),
                 option.Notification,
                 context.Options,
-                additionalLocations: ImmutableArray.Create(localFunction.GetLocation()),
+                additionalLocations: [localFunction.GetLocation()],
                 properties: null));
         }
     }

src/Analyzers/CSharp/Analyzers/MakeStructMemberReadOnly/CSharpMakeStructMemberReadOnlyAnalyzer.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Diagnostics.CodeAnalysis;
@@ -140,7 +141,7 @@ private void AnalyzeBlock(
             return;
 
         var (location, additionalLocation) = GetDiagnosticLocation(owningMethod, cancellationToken);
-        if (location == null || !context.ShouldAnalyzeSpan(location.SourceSpan))
+        if (location == null || additionalLocation == null || !context.ShouldAnalyzeSpan(location.SourceSpan))
             return;
 
         foreach (var blockOperation in context.OperationBlocks)
@@ -163,7 +164,7 @@ private void AnalyzeBlock(
                 location,
                 notificationOption,
                 context.Options,
-                additionalLocations: ImmutableArray.Create(additionalLocation),
+                additionalLocations: [additionalLocation],
                 properties: null);
         }
     }

src/Analyzers/CSharp/Analyzers/MakeStructReadOnly/CSharpMakeStructReadOnlyDiagnosticAnalyzer.cs

@@ -62,7 +62,7 @@ protected override void InitializeWorker(AnalysisContext context)
                         location,
                         option.Notification,
                         context.Options,
-                        additionalLocations: ImmutableArray.Create(additionalLocation),
+                        additionalLocations: [additionalLocation],
                         properties: null));
                 });
             }, SymbolKind.NamedType);

src/Analyzers/CSharp/Analyzers/NewLines/ConstructorInitializerPlacement/ConstructorInitializerPlacementDiagnosticAnalyzer.cs

@@ -93,7 +93,7 @@ private void ProcessConstructorInitializer(
             colonToken.GetLocation(),
             notificationOption,
             context.Options,
-            additionalLocations: ImmutableArray.Create(initializer.GetLocation()),
+            additionalLocations: [initializer.GetLocation()],
             properties: null));
     }
 }

src/Analyzers/CSharp/Analyzers/RemoveConfusingSuppression/CSharpRemoveConfusingSuppressionDiagnosticAnalyzer.cs

@@ -45,7 +45,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
             ((PostfixUnaryExpressionSyntax)left).OperatorToken.GetLocation(),
             NotificationOption2.Warning,
             context.Options,
-            ImmutableArray.Create(node.GetLocation()),
+            [node.GetLocation()],
             properties: null));
     }
 }

src/Analyzers/CSharp/Analyzers/SimplifyPropertyPattern/CSharpSimplifyPropertyPatternDiagnosticAnalyzer.cs

@@ -67,7 +67,7 @@ private void AnalyzeSubpattern(SyntaxNodeAnalysisContext syntaxContext)
             expressionColon.GetLocation(),
             styleOption.Notification,
             syntaxContext.Options,
-            ImmutableArray.Create(subpattern.GetLocation()),
+            [subpattern.GetLocation()],
             properties: null));
     }
 }

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForArrayDiagnosticAnalyzer.cs

@@ -196,7 +196,7 @@ private void AnalyzeArrayInitializerExpression(SyntaxNodeAnalysisContext context
                 initializer.OpenBraceToken.GetLocation(),
                 option.Notification,
                 context.Options,
-                additionalLocations: ImmutableArray.Create(initializer.GetLocation()),
+                additionalLocations: [initializer.GetLocation()],
                 properties: changesSemantics ? ChangesSemantics : null));
         }
     }