Remove parameter

CyrusNajmabadi · CyrusNajmabadi · commit 09f90e38e196 · 2025-01-05T20:19:04.000-08:00
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/CodeGeneration/ParameterGenerator.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/CodeGeneration/ParameterGenerator.cs
@@ -69,7 +69,7 @@ internal static ParameterSyntax GetParameter(IParameterSymbol parameter, CSharpC
             .WithAttributeLists(GenerateAttributes(parameter, isExplicit, info))
             .WithModifiers(GenerateModifiers(parameter, isFirstParam))
             .WithType(parameter.Type.GenerateTypeSyntax(allowVar: false))
-            .WithDefault(GenerateEqualsValueClause(info.Generator, parameter, isExplicit, seenOptional));
+            .WithDefault(GenerateEqualsValueClause(parameter, isExplicit, seenOptional));
     }
 
     private static SyntaxTokenList GenerateModifiers(
@@ -88,7 +88,6 @@ parameter.ContainingSymbol is IMethodSymbol methodSymbol &&
     }
 
     private static EqualsValueClauseSyntax? GenerateEqualsValueClause(
-        SyntaxGenerator generator,
         IParameterSymbol parameter,
         bool isExplicit,
         bool seenOptional)
@@ -102,14 +101,14 @@ parameter.ContainingSymbol is IMethodSymbol methodSymbol &&
                     return null;
 
                 return EqualsValueClause(
-                    GenerateEqualsValueClauseWorker(generator, parameter, defaultValue));
+                    GenerateEqualsValueClauseWorker(parameter, defaultValue));
             }
         }
 
         return null;
     }
 
-    private static ExpressionSyntax GenerateEqualsValueClauseWorker(SyntaxGenerator generator, IParameterSymbol parameter, object? value)
+    private static ExpressionSyntax GenerateEqualsValueClauseWorker(IParameterSymbol parameter, object? value)
         => ExpressionGenerator.GenerateExpression(parameter.Type, value, canUseFieldReference: true);
 
     private static SyntaxList<AttributeListSyntax> GenerateAttributes(

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ internal static ParameterSyntax GetParameter(IParameterSymbol parameter, CSharpC`
`69`	`69`	`.WithAttributeLists(GenerateAttributes(parameter, isExplicit, info))`
`70`	`70`	`.WithModifiers(GenerateModifiers(parameter, isFirstParam))`
`71`	`71`	`.WithType(parameter.Type.GenerateTypeSyntax(allowVar: false))`
`72`		`- .WithDefault(GenerateEqualsValueClause(info.Generator, parameter, isExplicit, seenOptional));`
	`72`	`+ .WithDefault(GenerateEqualsValueClause(parameter, isExplicit, seenOptional));`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`private static SyntaxTokenList GenerateModifiers(`
`@@ -88,7 +88,6 @@ parameter.ContainingSymbol is IMethodSymbol methodSymbol &&`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`private static EqualsValueClauseSyntax? GenerateEqualsValueClause(`
`91`		`- SyntaxGenerator generator,`
`92`	`91`	`IParameterSymbol parameter,`
`93`	`92`	`bool isExplicit,`
`94`	`93`	`bool seenOptional)`
`@@ -102,14 +101,14 @@ parameter.ContainingSymbol is IMethodSymbol methodSymbol &&`
`102`	`101`	`return null;`
`103`	`102`
`104`	`103`	`return EqualsValueClause(`
`105`		`- GenerateEqualsValueClauseWorker(generator, parameter, defaultValue));`
	`104`	`+ GenerateEqualsValueClauseWorker(parameter, defaultValue));`
`106`	`105`	`}`
`107`	`106`	`}`
`108`	`107`
`109`	`108`	`return null;`
`110`	`109`	`}`
`111`	`110`
`112`		`- private static ExpressionSyntax GenerateEqualsValueClauseWorker(SyntaxGenerator generator, IParameterSymbol parameter, object? value)`
	`111`	`+ private static ExpressionSyntax GenerateEqualsValueClauseWorker(IParameterSymbol parameter, object? value)`
`113`	`112`	`=> ExpressionGenerator.GenerateExpression(parameter.Type, value, canUseFieldReference: true);`
`114`	`113`
`115`	`114`	`private static SyntaxList<AttributeListSyntax> GenerateAttributes(`