Skip to content

Commit 2eca5b2

Browse files
authored
Change PR Val builds to be unsigned (#76358)
Disables signing for build artifacts to improve the turn around time for getting results back from a validation run. Measuring from `SignToolTask starting` to `SignToolTask execution finished`. - Real signing: varies but is a whole lotta time (could be over an hour) - Test signing: ~7min - No signing: <1sec Test Run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10705817&view=results (microsoft)
2 parents fe3a243 + dc71f98 commit 2eca5b2

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

azure-pipelines-pr-validation.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ variables:
3333
value: false
3434
- name: Codeql.SkipTaskAutoInjection
3535
value: true
36+
- name: SignType
37+
value: ''
3638

3739
# To retrieve OptProf data we need to authenticate to the VS drop storage.
3840
# If the pipeline is running in DevDiv, the account has access to the VS drop storage.

eng/Signing.props

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,19 @@
6161
<FileSignInfo Include="Microsoft.VisualStudio.Threading.dll" CertificateName="MicrosoftSHA2" />
6262
<FileSignInfo Include="StreamJsonRpc.dll" CertificateName="MicrosoftSHA2" />
6363
</ItemGroup>
64+
65+
<!--
66+
We do not intend to ship the artifacts produced for PR validation build so we can skip signing the artifacts.
67+
-->
68+
<Choose>
69+
<When Condition="'$(PreReleaseVersionLabel)' == 'pr-validation' And '$(SignType)' == ''">
70+
<ItemGroup>
71+
<ItemsToSign Remove="@(ItemsToSign)" />
72+
</ItemGroup>
73+
74+
<PropertyGroup>
75+
<AllowEmptySignList>true</AllowEmptySignList>
76+
</PropertyGroup>
77+
</When>
78+
</Choose>
6479
</Project>

0 commit comments

Comments
 (0)